Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Issue 2850793002: Replace VideoReceiveStream::Config with new rtclog::StreamConfig in RtcEventLog. (Closed)

Created:
3 years, 7 months ago by perkj_webrtc
Modified:
3 years, 7 months ago
Reviewers:
the sun, terelius
CC:
webrtc-reviews_webrtc.org, AleBzk, Andrew MacDonald, henrika_webrtc, stefan-webrtc, tterriberry_mozilla.com, audio-team_agora.io, peah-webrtc, minyue-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Replace VideoReceiveStream::Config with new rtclog::StreamConfig in RtcEventLog. BUG=webrtc:7538 Review-Url: https://codereview.webrtc.org/2850793002 Cr-Commit-Position: refs/heads/master@{#18220} Committed: https://chromium.googlesource.com/external/webrtc/+/09e71daec503f9983938fd7e621657fc4cff2440

Patch Set 1 #

Patch Set 2 : Fix rtc_event_log_parser.h #

Patch Set 3 : Fixed rtc_event_log2text. #

Patch Set 4 : Fix payload_id in tests. #

Patch Set 5 : Rebased #

Patch Set 6 : rebased #

Patch Set 7 : Fix merge. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+170 lines, -135 lines) Patch
M webrtc/call/call.cc View 1 2 3 4 2 chunks +20 lines, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/mock/mock_rtc_event_log.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.h View 4 chunks +31 lines, -3 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.cc View 1 2 3 4 2 chunks +15 lines, -16 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log2text.cc View 1 2 3 4 5 6 1 chunk +5 lines, -5 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_parser.h View 1 1 chunk +2 lines, -3 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_parser.cc View 1 2 3 chunks +31 lines, -29 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest.cc View 1 2 3 4 chunks +13 lines, -19 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_unittest_helper.cc View 1 2 3 chunks +44 lines, -47 lines 0 comments Download
M webrtc/tools/event_log_visualizer/analyzer.cc View 1 2 3 4 5 1 chunk +5 lines, -5 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 2 3 4 1 chunk +2 lines, -5 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 37 (29 generated)
perkj_webrtc
Please?
3 years, 7 months ago (2017-04-28 14:55:01 UTC) #10
hlundin-webrtc
On 2017/04/28 14:55:01, perkj_webrtc wrote: > Please? Drive-by nit: typo in CL title.
3 years, 7 months ago (2017-05-02 07:05:48 UTC) #13
perkj_webrtc
On 2017/05/02 07:05:48, hlundin-webrtc wrote: > On 2017/04/28 14:55:01, perkj_webrtc wrote: > > Please? > ...
3 years, 7 months ago (2017-05-02 09:27:04 UTC) #15
terelius
lgtm
3 years, 7 months ago (2017-05-19 17:09:36 UTC) #20
perkj_webrtc
Solenberg, can you please review call.cc and voiceengine.cc ? And the rest if you want....
3 years, 7 months ago (2017-05-21 19:26:29 UTC) #22
the sun
On 2017/05/21 19:26:29, perkj_webrtc wrote: > Solenberg, can you please review call.cc and voiceengine.cc ? ...
3 years, 7 months ago (2017-05-22 09:14:50 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2850793002/120001
3 years, 7 months ago (2017-05-22 10:24:18 UTC) #34
commit-bot: I haz the power
3 years, 7 months ago (2017-05-22 10:26:56 UTC) #37
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/external/webrtc/+/09e71daec503f9983938fd7e6...

Powered by Google App Engine
This is Rietveld 408576698