Reland of Extract iOS SDK helpers to separate target.

Reland of Extract iOS SDK helpers to separate target. (patchset #1 id:1 of https://codereview.webrtc.org/2853273002/ )

Reason for revert:
Trying to reland after: https://codereview.webrtc.org/2855103003.

Original issue's description:
> Revert of Extract iOS SDK helpers to separate target. (patchset #3 id:40001 of https://codereview.webrtc.org/2849823002/ )
> 
> Reason for revert:
> https://chromium.googlesource.com/external/webrtc/+/3c1e558449309be965815e1bf...
> 
> I suspect this breaks Chrome ios. 
> https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bu...
> https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2...
> 
> Undefined symbols for architecture x86_64:
>   "base::allocator::g_replaced_default_zone", referenced from:
>       base::allocator::IsAllocatorInitialized() in libbase.a(allocator_check.o)
> ld: symbol(s) not found for architecture x86_64
> clang: error: linker command failed with exit code 1 (use -v to see invocation)
> Traceback (most recent call last):
>   File "../../build/toolchain/mac/linker_driver.py", line 229, in <module>
>     Main(sys.argv)
>   File "../../build/toolchain/mac/linker_driver.py", line 79, in Main
>     subprocess.check_call(compiler_driver_args)
>   File
> "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
> line 540, in check_call
>     raise CalledProcessError(retcode, cmd)
> 
> Original issue's description:
> > Extract iOS SDK helpers to separate target.
> > 
> > This will reduce the redundant objects built
> > in Chromium when opening up test_support for the fuzzer
> > tests.
> > 
> > BUG=webrtc:6828
> > NOTRY=True
> > 
> > Review-Url: https://codereview.webrtc.org/2849823002
> > Cr-Commit-Position: refs/heads/master@{#17972}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/3c1e558449309be965815e1bf67d2391500343ce
> 
> TBR=mbonadei@webrtc.org,kjellander@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6828
> 
> Review-Url: https://codereview.webrtc.org/2853273002
> Cr-Commit-Position: refs/heads/master@{#17979}
> Committed: https://chromium.googlesource.com/external/webrtc/+/80e230239ebcb09c6e31b6b50ca1e61ae49ef1fb

TBR=kjellander@webrtc.org,perkj@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6828
Review-Url: https://codereview.webrtc.org/2852323003
Cr-Commit-Position: refs/heads/master@{#17992}
Committed: https://chromium.googlesource.com/external/webrtc/+/fafd6d850d0710e7279901dda94b67cba5996aba

[mbonadei, 2017-05-03 12:20:45]

Created Reland of Extract iOS SDK helpers to separate target.

[mbonadei, 2017-05-03 12:56:25]

The CQ bit was checked by mbonadei@webrtc.org

[commit-bot: I haz the power, 2017-05-03 12:56:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-03 12:56:31]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1493816185065030, "parent_rev":
"debaa442ed0317e215706c8c7d91c880e6bd6051", "commit_rev":
"fafd6d850d0710e7279901dda94b67cba5996aba"}

[commit-bot: I haz the power, 2017-05-03 12:56:33]

Description was changed from

==========
Reland of Extract iOS SDK helpers to separate target. (patchset #1 id:1 of
https://codereview.webrtc.org/2853273002/ )

Reason for revert:
Trying to reland after: https://codereview.webrtc.org/2855103003.

Original issue's description:
> Revert of Extract iOS SDK helpers to separate target. (patchset #3 id:40001 of
https://codereview.webrtc.org/2849823002/ )
> 
> Reason for revert:
>
https://chromium.googlesource.com/external/webrtc/+/3c1e558449309be965815e1bf...
> 
> I suspect this breaks Chrome ios. 
>
https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bu...
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2...
> 
> Undefined symbols for architecture x86_64:
>   "base::allocator::g_replaced_default_zone", referenced from:
>       base::allocator::IsAllocatorInitialized() in
libbase.a(allocator_check.o)
> ld: symbol(s) not found for architecture x86_64
> clang: error: linker command failed with exit code 1 (use -v to see
invocation)
> Traceback (most recent call last):
>   File "../../build/toolchain/mac/linker_driver.py", line 229, in <module>
>     Main(sys.argv)
>   File "../../build/toolchain/mac/linker_driver.py", line 79, in Main
>     subprocess.check_call(compiler_driver_args)
>   File
>
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
> line 540, in check_call
>     raise CalledProcessError(retcode, cmd)
> 
> Original issue's description:
> > Extract iOS SDK helpers to separate target.
> > 
> > This will reduce the redundant objects built
> > in Chromium when opening up test_support for the fuzzer
> > tests.
> > 
> > BUG=webrtc:6828
> > NOTRY=True
> > 
> > Review-Url: https://codereview.webrtc.org/2849823002
> > Cr-Commit-Position: refs/heads/master@{#17972}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/3c1e558449309be965815e1bf...
> 
> TBR=mbonadei@webrtc.org,kjellander@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6828
> 
> Review-Url: https://codereview.webrtc.org/2853273002
> Cr-Commit-Position: refs/heads/master@{#17979}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/80e230239ebcb09c6e31b6b50...

TBR=kjellander@webrtc.org,perkj@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6828
==========

to

==========
Reland of Extract iOS SDK helpers to separate target. (patchset #1 id:1 of
https://codereview.webrtc.org/2853273002/ )

Reason for revert:
Trying to reland after: https://codereview.webrtc.org/2855103003.

Original issue's description:
> Revert of Extract iOS SDK helpers to separate target. (patchset #3 id:40001 of
https://codereview.webrtc.org/2849823002/ )
> 
> Reason for revert:
>
https://chromium.googlesource.com/external/webrtc/+/3c1e558449309be965815e1bf...
> 
> I suspect this breaks Chrome ios. 
>
https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bu...
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2...
> 
> Undefined symbols for architecture x86_64:
>   "base::allocator::g_replaced_default_zone", referenced from:
>       base::allocator::IsAllocatorInitialized() in
libbase.a(allocator_check.o)
> ld: symbol(s) not found for architecture x86_64
> clang: error: linker command failed with exit code 1 (use -v to see
invocation)
> Traceback (most recent call last):
>   File "../../build/toolchain/mac/linker_driver.py", line 229, in <module>
>     Main(sys.argv)
>   File "../../build/toolchain/mac/linker_driver.py", line 79, in Main
>     subprocess.check_call(compiler_driver_args)
>   File
>
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
> line 540, in check_call
>     raise CalledProcessError(retcode, cmd)
> 
> Original issue's description:
> > Extract iOS SDK helpers to separate target.
> > 
> > This will reduce the redundant objects built
> > in Chromium when opening up test_support for the fuzzer
> > tests.
> > 
> > BUG=webrtc:6828
> > NOTRY=True
> > 
> > Review-Url: https://codereview.webrtc.org/2849823002
> > Cr-Commit-Position: refs/heads/master@{#17972}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/3c1e558449309be965815e1bf...
> 
> TBR=mbonadei@webrtc.org,kjellander@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6828
> 
> Review-Url: https://codereview.webrtc.org/2853273002
> Cr-Commit-Position: refs/heads/master@{#17979}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/80e230239ebcb09c6e31b6b50...

TBR=kjellander@webrtc.org,perkj@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6828

Review-Url: https://codereview.webrtc.org/2852323003
Cr-Commit-Position: refs/heads/master@{#17992}
Committed:
https://chromium.googlesource.com/external/webrtc/+/fafd6d850d0710e7279901dda...
==========

[commit-bot: I haz the power, 2017-05-03 12:56:35]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/fafd6d850d0710e7279901dda...

[kjellander_webrtc, 2017-05-03 13:29:10]

Description was changed from

==========
Reland of Extract iOS SDK helpers to separate target. (patchset #1 id:1 of
https://codereview.webrtc.org/2853273002/ )

Reason for revert:
Trying to reland after: https://codereview.webrtc.org/2855103003.

Original issue's description:
> Revert of Extract iOS SDK helpers to separate target. (patchset #3 id:40001 of
https://codereview.webrtc.org/2849823002/ )
> 
> Reason for revert:
>
https://chromium.googlesource.com/external/webrtc/+/3c1e558449309be965815e1bf...
> 
> I suspect this breaks Chrome ios. 
>
https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bu...
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2...
> 
> Undefined symbols for architecture x86_64:
>   "base::allocator::g_replaced_default_zone", referenced from:
>       base::allocator::IsAllocatorInitialized() in
libbase.a(allocator_check.o)
> ld: symbol(s) not found for architecture x86_64
> clang: error: linker command failed with exit code 1 (use -v to see
invocation)
> Traceback (most recent call last):
>   File "../../build/toolchain/mac/linker_driver.py", line 229, in <module>
>     Main(sys.argv)
>   File "../../build/toolchain/mac/linker_driver.py", line 79, in Main
>     subprocess.check_call(compiler_driver_args)
>   File
>
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
> line 540, in check_call
>     raise CalledProcessError(retcode, cmd)
> 
> Original issue's description:
> > Extract iOS SDK helpers to separate target.
> > 
> > This will reduce the redundant objects built
> > in Chromium when opening up test_support for the fuzzer
> > tests.
> > 
> > BUG=webrtc:6828
> > NOTRY=True
> > 
> > Review-Url: https://codereview.webrtc.org/2849823002
> > Cr-Commit-Position: refs/heads/master@{#17972}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/3c1e558449309be965815e1bf...
> 
> TBR=mbonadei@webrtc.org,kjellander@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6828
> 
> Review-Url: https://codereview.webrtc.org/2853273002
> Cr-Commit-Position: refs/heads/master@{#17979}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/80e230239ebcb09c6e31b6b50...

TBR=kjellander@webrtc.org,perkj@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6828

Review-Url: https://codereview.webrtc.org/2852323003
Cr-Commit-Position: refs/heads/master@{#17992}
Committed:
https://chromium.googlesource.com/external/webrtc/+/fafd6d850d0710e7279901dda...
==========

to

==========
Reland of Extract iOS SDK helpers to separate target. (patchset #1 id:1 of
https://codereview.webrtc.org/2853273002/ )

Reason for revert:
Trying to reland after: https://codereview.webrtc.org/2855103003.

Original issue's description:
> Revert of Extract iOS SDK helpers to separate target. (patchset #3 id:40001 of
https://codereview.webrtc.org/2849823002/ )
> 
> Reason for revert:
>
https://chromium.googlesource.com/external/webrtc/+/3c1e558449309be965815e1bf...
> 
> I suspect this breaks Chrome ios. 
>
https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bu...
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2...
> 
> Undefined symbols for architecture x86_64:
>   "base::allocator::g_replaced_default_zone", referenced from:
>       base::allocator::IsAllocatorInitialized() in
libbase.a(allocator_check.o)
> ld: symbol(s) not found for architecture x86_64
> clang: error: linker command failed with exit code 1 (use -v to see
invocation)
> Traceback (most recent call last):
>   File "../../build/toolchain/mac/linker_driver.py", line 229, in <module>
>     Main(sys.argv)
>   File "../../build/toolchain/mac/linker_driver.py", line 79, in Main
>     subprocess.check_call(compiler_driver_args)
>   File
>
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
> line 540, in check_call
>     raise CalledProcessError(retcode, cmd)
> 
> Original issue's description:
> > Extract iOS SDK helpers to separate target.
> > 
> > This will reduce the redundant objects built
> > in Chromium when opening up test_support for the fuzzer
> > tests.
> > 
> > BUG=webrtc:6828
> > NOTRY=True
> > 
> > Review-Url: https://codereview.webrtc.org/2849823002
> > Cr-Commit-Position: refs/heads/master@{#17972}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/3c1e558449309be965815e1bf...
> 
> TBR=mbonadei@webrtc.org,kjellander@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:6828
> 
> Review-Url: https://codereview.webrtc.org/2853273002
> Cr-Commit-Position: refs/heads/master@{#17979}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/80e230239ebcb09c6e31b6b50...

TBR=kjellander@webrtc.org,perkj@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:6828

Review-Url: https://codereview.webrtc.org/2852323003
Cr-Commit-Position: refs/heads/master@{#17992}
Committed:
https://chromium.googlesource.com/external/webrtc/+/fafd6d850d0710e7279901dda...
==========

[mbonadei, 2017-05-03 13:41:52]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2857953003/ by mbonadei@webrtc.org.

The reason for reverting is: It is still breaking chromium trybots:

Undefined symbols for architecture x86_64:
  "base::allocator::g_replaced_default_zone", referenced from:
      base::allocator::IsAllocatorInitialized() in libbase.a(allocator_check.o)
ld: symbol(s) not found for architecture x86_64.

[kjellander (google.com), 2017-05-03 13:43:16]

On 2017/05/03 13:41:52, mbonadei wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.webrtc.org/2857953003/ by mailto:mbonadei@webrtc.org.
> 
> The reason for reverting is: It is still breaking chromium trybots:
> 
> Undefined symbols for architecture x86_64:
>   "base::allocator::g_replaced_default_zone", referenced from:
>       base::allocator::IsAllocatorInitialized() in
libbase.a(allocator_check.o)
> ld: symbol(s) not found for architecture x86_64.

Yes, we were a bit too trigger happy relanding this. We need to land a roll into
Chromium first to be sure we're testing the right thing when running trybots for
this. In addition to that I haven't even looked at the error for this, which
probably needs further code changes.

[kjellander_webrtc, 2017-05-05 13:48:41]

Kári: do you know what caused this kind of error? If you were working on making
similar changes, maybe you can take this over?

We wanted to do this to unblock https://codereview.webrtc.org/2845323002/

[kthelgason, 2017-05-08 11:19:15]

On 2017/05/05 13:48:41, kjellander_webrtc wrote:
> Kári: do you know what caused this kind of error? If you were working on
making
> similar changes, maybe you can take this over?
> 
> We wanted to do this to unblock https://codereview.webrtc.org/2845323002/

The compile step without the patch fails with the same error (at least that's
what it looks like to me).
Does that make any sense to you? I've not seen this before at least.

[kjellander_webrtc, 2017-05-08 18:53:29]

On 2017/05/08 11:19:15, kthelgason wrote:
> On 2017/05/05 13:48:41, kjellander_webrtc wrote:
> > Kári: do you know what caused this kind of error? If you were working on
> making
> > similar changes, maybe you can take this over?
> > 
> > We wanted to do this to unblock https://codereview.webrtc.org/2845323002/
> 
> The compile step without the patch fails with the same error (at least that's
> what it looks like to me).
> Does that make any sense to you? I've not seen this before at least.

OK that was strange. I reopened the CL and ran two new trybots and now it's only
failing at the compile step with the patch:
https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bu...
I wonder what happened in the previous one...

[mbonadei, 2017-05-09 07:37:04]

On 2017/05/08 18:53:29, kjellander_webrtc wrote:
> On 2017/05/08 11:19:15, kthelgason wrote:
> > On 2017/05/05 13:48:41, kjellander_webrtc wrote:
> > > Kári: do you know what caused this kind of error? If you were working on
> > making
> > > similar changes, maybe you can take this over?
> > > 
> > > We wanted to do this to unblock https://codereview.webrtc.org/2845323002/
> > 
> > The compile step without the patch fails with the same error (at least
that's
> > what it looks like to me).
> > Does that make any sense to you? I've not seen this before at least.
> 
> OK that was strange. I reopened the CL and ran two new trybots and now it's
only
> failing at the compile step with the patch:
>
https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bu...
> I wonder what happened in the previous one...

I have the same error on https://codereview.webrtc.org/2845323002/ but with a
smaller
change in webrtc/sdk/BUILD.gn
(https://codereview.webrtc.org/2845323002/diff/260001/webrtc/sdk/BUILD.gn).