Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1157)

Issue 2855103003: Adding virtualsocketserver to rtc_base sources (Closed)

Created:
3 years, 7 months ago by mbonadei
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Adding virtualsocketserver to rtc_base sources virtualsocketserver.h and virtualsocketserver.cc were excluded from the sources list if build_with_chromium is true. This causes a chromium compilation error because after [1] some deps are explicit. [1] - https://codereview.webrtc.org/2852663002 BUG=chromium:717832 NOTRY=True Review-Url: https://codereview.webrtc.org/2855103003 Cr-Commit-Position: refs/heads/master@{#17989} Committed: https://chromium.googlesource.com/external/webrtc/+/0b16a6294b40ecd8f4a5e45b4ce1c44825d7e955

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M webrtc/base/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
mbonadei
3 years, 7 months ago (2017-05-03 07:36:10 UTC) #2
kjellander_webrtc
lgtm but you might want a base owner to have a look, or TBR that ...
3 years, 7 months ago (2017-05-03 08:49:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2855103003/1
3 years, 7 months ago (2017-05-03 12:20:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/0b16a6294b40ecd8f4a5e45b4ce1c44825d7e955
3 years, 7 months ago (2017-05-03 12:22:39 UTC) #9
perkj_webrtc
lgtm
3 years, 7 months ago (2017-05-03 12:30:42 UTC) #11
perkj_webrtc
lgtm
3 years, 7 months ago (2017-05-03 12:30:43 UTC) #12
kjellander_webrtc
3 years, 7 months ago (2017-05-03 12:59:58 UTC) #13
Message was sent while issue was closed.
On 2017/05/03 12:30:43, perkj_webrtc wrote:
> lgtm

I verified this solves the problem we were seeing in Chromium's libfuzzer bots
by running this with src/third_party/webrtc patched with this CL:
gn gen out/libfuzzer --args='enable_nacl=false ffmpeg_branding="ChromeOS"
is_asan=true is_debug=true pdf_enable_xfa=true proprietary_codecs=true
use_libfuzzer=true'
ninja -C out/libfuzzer/ rtp_packet_fuzzer rtp_header_fuzzer
congestion_controller_feedback_fuzzer audio_decoder_ilbc_fuzzer
audio_decoder_isac_fuzzer audio_decoder_isac_incoming_packet_fuzzer
audio_decoder_isacfix_fuzzer h264_depacketizer_fuzzer vp8_depacketizer_fuzzer
vp9_depacketizer_fuzzer vp8_qp_parser_fuzzer h264_bitstream_parser_fuzzer
flexfec_header_reader_fuzzer flexfec_sender_fuzzer ulpfec_header_reader_fuzzer
ulpfec_generator_fuzzer flexfec_receiver_fuzzer packet_buffer_fuzzer
rtcp_receiver_fuzzer audio_decoder_opus_fuzzer
audio_decoder_opus_redundant_fuzzer turn_unwrap_fuzzer neteq_rtp_fuzzer
sdp_parser_fuzzer stun_parser_fuzzer stun_validator_fuzzer
pseudotcp_parser_fuzzer transport_feedback_packet_loss_tracker_fuzzer

Powered by Google App Engine
This is Rietveld 408576698