Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Issue 2853273002: Revert of Extract iOS SDK helpers to separate target. (Closed)

Created:
3 years, 7 months ago by perkj_webrtc
Modified:
3 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, audio-team_agora.io, sdk-team_agora.io, peah-webrtc, henrika_webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Extract iOS SDK helpers to separate target. (patchset #3 id:40001 of https://codereview.webrtc.org/2849823002/ ) Reason for revert: https://chromium.googlesource.com/external/webrtc/+/3c1e558449309be965815e1bf... I suspect this breaks Chrome ios. https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bu... https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2... Undefined symbols for architecture x86_64: "base::allocator::g_replaced_default_zone", referenced from: base::allocator::IsAllocatorInitialized() in libbase.a(allocator_check.o) ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) Traceback (most recent call last): File "../../build/toolchain/mac/linker_driver.py", line 229, in <module> Main(sys.argv) File "../../build/toolchain/mac/linker_driver.py", line 79, in Main subprocess.check_call(compiler_driver_args) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 540, in check_call raise CalledProcessError(retcode, cmd) Original issue's description: > Extract iOS SDK helpers to separate target. > > This will reduce the redundant objects built > in Chromium when opening up test_support for the fuzzer > tests. > > BUG=webrtc:6828 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2849823002 > Cr-Commit-Position: refs/heads/master@{#17972} > Committed: https://chromium.googlesource.com/external/webrtc/+/3c1e558449309be965815e1bf67d2391500343ce TBR=mbonadei@webrtc.org,kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6828 Review-Url: https://codereview.webrtc.org/2853273002 Cr-Commit-Position: refs/heads/master@{#17979} Committed: https://chromium.googlesource.com/external/webrtc/+/80e230239ebcb09c6e31b6b50ca1e61ae49ef1fb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -24 lines) Patch
M webrtc/modules/audio_device/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/sdk/BUILD.gn View 7 chunks +7 lines, -21 lines 0 comments Download
M webrtc/test/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
perkj_webrtc
Created Revert of Extract iOS SDK helpers to separate target.
3 years, 7 months ago (2017-05-02 14:23:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2853273002/1
3 years, 7 months ago (2017-05-02 14:23:14 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/80e230239ebcb09c6e31b6b50ca1e61ae49ef1fb
3 years, 7 months ago (2017-05-02 14:23:22 UTC) #6
mbonadei
3 years, 7 months ago (2017-05-03 12:20:45 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2852323003/ by mbonadei@webrtc.org.

The reason for reverting is: Trying to reland after:
https://codereview.webrtc.org/2855103003..

Powered by Google App Engine
This is Rietveld 408576698