Extract iOS SDK helpers to separate target.

Extract iOS SDK helpers to separate target.

This will reduce the redundant objects built
in Chromium when opening up test_support for the fuzzer
tests.

BUG=webrtc:6828
NOTRY=True

Review-Url: https://codereview.webrtc.org/2849823002
Cr-Commit-Position: refs/heads/master@{#17972}
Committed: https://chromium.googlesource.com/external/webrtc/+/3c1e558449309be965815e1bf67d2391500343ce

[kjellander_webrtc, 2017-04-28 12:22:26]

kjellander@webrtc.org changed reviewers:
+ mbonadei@webrtc.org

[mbonadei, 2017-04-28 12:30:22]

On 2017/04/28 12:22:29, kjellander_webrtc wrote:

lgtm

[mbonadei, 2017-05-02 07:37:29]

I am touching the same files in https://codereview.webrtc.org/2845323002.

So I think we should land this one before continuing to work
on the last "gn check" effort. :)

https://codereview.webrtc.org/2849823002/diff/1/webrtc/test/BUILD.gn
File webrtc/test/BUILD.gn (right):

https://codereview.webrtc.org/2849823002/diff/1/webrtc/test/BUILD.gn#newcode303
webrtc/test/BUILD.gn:303: deps += [ "//webrtc/sdk:rtc_sdk_helpers_objc" ]
Looking at the error it seems that we have to use the relative path here.

[kjellander_webrtc, 2017-05-02 09:03:47]

https://codereview.webrtc.org/2849823002/diff/1/webrtc/test/BUILD.gn
File webrtc/test/BUILD.gn (right):

https://codereview.webrtc.org/2849823002/diff/1/webrtc/test/BUILD.gn#newcode303
webrtc/test/BUILD.gn:303: deps += [ "//webrtc/sdk:rtc_sdk_helpers_objc" ]
On 2017/05/02 07:37:29, mbonadei wrote:
> Looking at the error it seems that we have to use the relative path here.

Thanks. I'm glad I ran the Chromium trybots.

[kjellander_webrtc, 2017-05-02 09:03:55]

Description was changed from

==========
Extract iOS SDK helpers to separate target.

This will reduce the redundant objects built
in Chromium when opening up test_support for the fuzzer
tests.

BUG=webrtc:6828
==========

to

==========
Extract iOS SDK helpers to separate target.

This will reduce the redundant objects built
in Chromium when opening up test_support for the fuzzer
tests.

BUG=webrtc:6828
NOTRY=True
==========

[kjellander_webrtc, 2017-05-02 11:49:06]

The CQ bit was checked by kjellander@webrtc.org

[kjellander_webrtc, 2017-05-02 11:49:07]

The patchset sent to the CQ was uploaded after l-g-t-m from mbonadei@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2849823002/#ps40001 (title:
"Fix more targets in //webrtc/sdk")

[commit-bot: I haz the power, 2017-05-02 11:49:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-02 11:51:40]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493725746767780,
"parent_rev": "c1524301f72f1764bfe8b86134170e12dad68761", "commit_rev":
"3c1e558449309be965815e1bf67d2391500343ce"}

[commit-bot: I haz the power, 2017-05-02 11:51:44]

Description was changed from

==========
Extract iOS SDK helpers to separate target.

This will reduce the redundant objects built
in Chromium when opening up test_support for the fuzzer
tests.

BUG=webrtc:6828
NOTRY=True
==========

to

==========
Extract iOS SDK helpers to separate target.

This will reduce the redundant objects built
in Chromium when opening up test_support for the fuzzer
tests.

BUG=webrtc:6828
NOTRY=True

Review-Url: https://codereview.webrtc.org/2849823002
Cr-Commit-Position: refs/heads/master@{#17972}
Committed:
https://chromium.googlesource.com/external/webrtc/+/3c1e558449309be965815e1bf...
==========

[commit-bot: I haz the power, 2017-05-02 11:51:44]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/webrtc/+/3c1e558449309be965815e1bf...

[perkj_webrtc, 2017-05-02 14:22:40]

On 2017/05/02 11:51:44, commit-bot: I haz the power wrote:
> Committed patchset #3 (id:40001) as
>
https://chromium.googlesource.com/external/webrtc/+/3c1e558449309be965815e1bf...

I suspect this breaks Chrome ios. 
https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bu...
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2...

Undefined symbols for architecture x86_64:
  "base::allocator::g_replaced_default_zone", referenced from:
      base::allocator::IsAllocatorInitialized() in libbase.a(allocator_check.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Traceback (most recent call last):
  File "../../build/toolchain/mac/linker_driver.py", line 229, in <module>
    Main(sys.argv)
  File "../../build/toolchain/mac/linker_driver.py", line 79, in Main
    subprocess.check_call(compiler_driver_args)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
line 540, in check_call
    raise CalledProcessError(retcode, cmd)

[perkj_webrtc, 2017-05-02 14:23:02]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.webrtc.org/2853273002/ by perkj@webrtc.org.

The reason for reverting is:
https://chromium.googlesource.com/external/webrtc/+/3c1e558449309be965815e1bf...

I suspect this breaks Chrome ios. 
https://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bu...
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2...

Undefined symbols for architecture x86_64:
  "base::allocator::g_replaced_default_zone", referenced from:
      base::allocator::IsAllocatorInitialized() in libbase.a(allocator_check.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
Traceback (most recent call last):
  File "../../build/toolchain/mac/linker_driver.py", line 229, in <module>
    Main(sys.argv)
  File "../../build/toolchain/mac/linker_driver.py", line 79, in Main
    subprocess.check_call(compiler_driver_args)
  File
"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py",
line 540, in check_call
    raise CalledProcessError(retcode, cmd).