Enabling 'gn check' on webrtc/test.

Enabling 'gn check' on webrtc/test.

This is the second attempt of enabling 'gn check' on the directory
webrtc/test.

BUG=webrtc:6828
NOTRY=True

[mbonadei, 2017-05-02 12:41:07]

mbonadei@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[mbonadei, 2017-05-02 12:41:08]

Hopefully this is the last one. :)

[kjellander_webrtc, 2017-05-02 12:47:37]

lgtm if all trybots are happy (and you update .gn)

https://codereview.webrtc.org/2845323002/diff/160001/.gn
File .gn (right):

https://codereview.webrtc.org/2845323002/diff/160001/.gn#newcode40
.gn:40: "//webrtc/test",
Should it be //webrtc/test/* ?

And if it's the last one, replace all with //webrtc/* ?

[mbonadei, 2017-05-02 12:53:51]

https://codereview.webrtc.org/2845323002/diff/160001/.gn
File .gn (right):

https://codereview.webrtc.org/2845323002/diff/160001/.gn#newcode40
.gn:40: "//webrtc/test",
On 2017/05/02 12:47:36, kjellander_webrtc wrote:
> Should it be //webrtc/test/* ?
> 
> And if it's the last one, replace all with //webrtc/* ?

Done.

I will create a new CL for "//webrtc/*".

[mbonadei, 2017-05-02 12:54:40]

Description was changed from

==========
Enabling 'gn check' on webrtc/test.

This is the second attempt of enabling 'gn check' on the directory
webrtc/test.

BUG=webrtc:6828
==========

to

==========
Enabling 'gn check' on webrtc/test.

This is the second attempt of enabling 'gn check' on the directory
webrtc/test.

BUG=webrtc:6828
NOTRY=True
==========

[mbonadei, 2017-05-02 13:50:34]

The CQ bit was checked by mbonadei@webrtc.org

[mbonadei, 2017-05-02 13:50:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2845323002/#ps180001 (title:
"fixing typo in .gn")

[commit-bot: I haz the power, 2017-05-02 13:50:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-02 13:54:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 13:54:30]

Try jobs failed on following builders:
  presubmit on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/16649)

[mbonadei, 2017-05-02 14:21:45]

The CQ bit was checked by mbonadei@webrtc.org

[mbonadei, 2017-05-02 14:21:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2845323002/#ps200001 (title:
"rebasing after eb1fde4a26f1a863c7488a63923eaf782c3ba177")

[commit-bot: I haz the power, 2017-05-02 14:21:52]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-02 14:24:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 14:24:25]

Failed to apply patch for webrtc/sdk/BUILD.gn:
While running git apply --index -3 -p1;
  error: patch failed: webrtc/sdk/BUILD.gn:434
  Falling back to three-way merge...
  Applied patch to 'webrtc/sdk/BUILD.gn' with conflicts.
  U webrtc/sdk/BUILD.gn

Patch:       webrtc/sdk/BUILD.gn
Index: webrtc/sdk/BUILD.gn
diff --git a/webrtc/sdk/BUILD.gn b/webrtc/sdk/BUILD.gn
index
1b27218745d9d9355231983d0b0d2efc5a8b0ae9..5c7f68e8b3695bd2938c812fafcc7af8db84ce68
100644
--- a/webrtc/sdk/BUILD.gn
+++ b/webrtc/sdk/BUILD.gn
@@ -434,8 +434,8 @@ if (is_ios || is_mac) {
     complete_static_lib = true
     deps = [
       ":rtc_sdk_peerconnection_objc",
-      "..//system_wrappers:field_trial_default",
-      "..//system_wrappers:metrics_default",
+      "../system_wrappers:field_trial_default",
+      "../system_wrappers:metrics_default",
     ]
   }

[mbonadei, 2017-05-02 14:26:46]

On 2017/05/02 14:24:25, commit-bot: I haz the power wrote:
> Failed to apply patch for webrtc/sdk/BUILD.gn:
> While running git apply --index -3 -p1;
>   error: patch failed: webrtc/sdk/BUILD.gn:434
>   Falling back to three-way merge...
>   Applied patch to 'webrtc/sdk/BUILD.gn' with conflicts.
>   U webrtc/sdk/BUILD.gn
> 
> Patch:       webrtc/sdk/BUILD.gn
> Index: webrtc/sdk/BUILD.gn
> diff --git a/webrtc/sdk/BUILD.gn b/webrtc/sdk/BUILD.gn
> index
>
1b27218745d9d9355231983d0b0d2efc5a8b0ae9..5c7f68e8b3695bd2938c812fafcc7af8db84ce68
> 100644
> --- a/webrtc/sdk/BUILD.gn
> +++ b/webrtc/sdk/BUILD.gn
> @@ -434,8 +434,8 @@ if (is_ios || is_mac) {
>      complete_static_lib = true
>      deps = [
>        ":rtc_sdk_peerconnection_objc",
> -      "..//system_wrappers:field_trial_default",
> -      "..//system_wrappers:metrics_default",
> +      "../system_wrappers:field_trial_default",
> +      "../system_wrappers:metrics_default",
>      ]
>    }

Failed because https://codereview.webrtc.org/2849823002 has been landed minutes
before.
I will wait for that reland before trying to land this CL.

[mbonadei, 2017-05-30 10:55:33]

On 2017/05/02 14:26:46, mbonadei wrote:
> On 2017/05/02 14:24:25, commit-bot: I haz the power wrote:
> > Failed to apply patch for webrtc/sdk/BUILD.gn:
> > While running git apply --index -3 -p1;
> >   error: patch failed: webrtc/sdk/BUILD.gn:434
> >   Falling back to three-way merge...
> >   Applied patch to 'webrtc/sdk/BUILD.gn' with conflicts.
> >   U webrtc/sdk/BUILD.gn
> > 
> > Patch:       webrtc/sdk/BUILD.gn
> > Index: webrtc/sdk/BUILD.gn
> > diff --git a/webrtc/sdk/BUILD.gn b/webrtc/sdk/BUILD.gn
> > index
> >
>
1b27218745d9d9355231983d0b0d2efc5a8b0ae9..5c7f68e8b3695bd2938c812fafcc7af8db84ce68
> > 100644
> > --- a/webrtc/sdk/BUILD.gn
> > +++ b/webrtc/sdk/BUILD.gn
> > @@ -434,8 +434,8 @@ if (is_ios || is_mac) {
> >      complete_static_lib = true
> >      deps = [
> >        ":rtc_sdk_peerconnection_objc",
> > -      "..//system_wrappers:field_trial_default",
> > -      "..//system_wrappers:metrics_default",
> > +      "../system_wrappers:field_trial_default",
> > +      "../system_wrappers:metrics_default",
> >      ]
> >    }
> 
> Failed because https://codereview.webrtc.org/2849823002 has been landed
minutes
> before.
> I will wait for that reland before trying to land this CL.

Closing this CL. I will create a new one since the iOS SDK targets split 
CL is now landed (https://codereview.webrtc.org/2913753003). This will
simplify a lot this effort.