Reland of Split iOS sdk in to separate targets

Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2911053002/ )

Reason for revert:
Take three of relanding this after all internal issues have been resolved.

Original issue's description:
> Revert of Split iOS sdk in to separate targets (patchset #3 id:320001 of https://codereview.webrtc.org/2893843003/ )
> 
> Reason for revert:
> Breaks downstream project.
> 
> Original issue's description:
> > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2893593002/ )
> > 
> > Reason for revert:
> > Take two of fixing downstream issues?
> > 
> > Original issue's description:
> > > Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890733003/ )
> > > 
> > > Reason for revert:
> > > Still problems with downstream projects
> > > 
> > > Original issue's description:
> > > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of https://codereview.webrtc.org/2890513002/ )
> > > > 
> > > > Reason for revert:
> > > > Fixing downstream breakages
> > > > 
> > > > Original issue's description:
> > > > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001 of https://codereview.webrtc.org/2862543002/ )
> > > > > 
> > > > > Reason for revert:
> > > > > Breaking downstream projects.
> > > > > 
> > > > > Original issue's description:
> > > > > > Split iOS sdk in to separate targets
> > > > > > 
> > > > > > This CL splits the iOS sdk into separate static libraries for video,
> > > > > > audio, ui, common, and peerconnection-related code. This will in the
> > > > > > future make it easier to compile WebRTC without unneeded components.
> > > > > > 
> > > > > > BUG=webrtc:4867
> > > > > > 
> > > > > > Review-Url: https://codereview.webrtc.org/2862543002
> > > > > > Cr-Commit-Position: refs/heads/master@{#18166}
> > > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/52c83fe7102f566cf35a7533092873d58b38f426
> > > > > 
> > > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,kthelgason@webrtc.org
> > > > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > > > NOPRESUBMIT=true
> > > > > NOTREECHECKS=true
> > > > > NOTRY=true
> > > > > BUG=webrtc:4867
> > > > > 
> > > > > Review-Url: https://codereview.webrtc.org/2890513002
> > > > > Cr-Commit-Position: refs/heads/master@{#18170}
> > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/9756238084707787f735e1294e896e462e459717
> > > > 
> > > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org
> > > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > > NOPRESUBMIT=true
> > > > NOTREECHECKS=true
> > > > NOTRY=true
> > > > BUG=webrtc:4867
> > > > 
> > > > Review-Url: https://codereview.webrtc.org/2890733003
> > > > Cr-Commit-Position: refs/heads/master@{#18174}
> > > > Committed: https://chromium.googlesource.com/external/webrtc/+/d51e042492bedd057bc0cac7828979d5c7369cea
> > > 
> > > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org
> > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=webrtc:4867
> > > 
> > > Review-Url: https://codereview.webrtc.org/2893593002
> > > Cr-Commit-Position: refs/heads/master@{#18182}
> > > Committed: https://chromium.googlesource.com/external/webrtc/+/37144b214e2baf62ecb262ab878dde8c59cdd6a3
> > 
> > TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=webrtc:4867
> > 
> > Review-Url: https://codereview.webrtc.org/2893843003
> > Cr-Commit-Position: refs/heads/master@{#18303}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/580c3522d294c877adfe555048c675bd8d166657
> 
> TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,kthelgason@webrtc.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:4867
> 
> Review-Url: https://codereview.webrtc.org/2911053002
> Cr-Commit-Position: refs/heads/master@{#18309}
> Committed: https://chromium.googlesource.com/external/webrtc/+/af5c05540cc8208f682cafe88c5c16a505479196

TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.org,charujain@webrtc.org,mbonadei@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4867
Review-Url: https://codereview.webrtc.org/2913753003
Cr-Commit-Position: refs/heads/master@{#18319}
Committed: https://chromium.googlesource.com/external/webrtc/+/2f08879fb19db40cc1c35c8233103006219db3fe

[kthelgason, 2017-05-30 08:02:48]

Created Reland of Split iOS sdk in to separate targets

[mbonadei, 2017-05-30 08:47:40]

The CQ bit was checked by mbonadei@webrtc.org

[commit-bot: I haz the power, 2017-05-30 08:47:54]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-05-30 08:48:48]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1496134060349770, "parent_rev":
"11fb472ae40de4e03e5b12aa0bb3f99d7e9c1a69", "commit_rev":
"2f08879fb19db40cc1c35c8233103006219db3fe"}

[commit-bot: I haz the power, 2017-05-30 08:48:51]

Description was changed from

==========
Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of
https://codereview.webrtc.org/2911053002/ )

Reason for revert:
Take three of relanding this after all internal issues have been resolved.

Original issue's description:
> Revert of Split iOS sdk in to separate targets (patchset #3 id:320001 of
https://codereview.webrtc.org/2893843003/ )
> 
> Reason for revert:
> Breaks downstream project.
> 
> Original issue's description:
> > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of
https://codereview.webrtc.org/2893593002/ )
> > 
> > Reason for revert:
> > Take two of fixing downstream issues?
> > 
> > Original issue's description:
> > > Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of
https://codereview.webrtc.org/2890733003/ )
> > > 
> > > Reason for revert:
> > > Still problems with downstream projects
> > > 
> > > Original issue's description:
> > > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of
https://codereview.webrtc.org/2890513002/ )
> > > > 
> > > > Reason for revert:
> > > > Fixing downstream breakages
> > > > 
> > > > Original issue's description:
> > > > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001
of https://codereview.webrtc.org/2862543002/ )
> > > > > 
> > > > > Reason for revert:
> > > > > Breaking downstream projects.
> > > > > 
> > > > > Original issue's description:
> > > > > > Split iOS sdk in to separate targets
> > > > > > 
> > > > > > This CL splits the iOS sdk into separate static libraries for video,
> > > > > > audio, ui, common, and peerconnection-related code. This will in the
> > > > > > future make it easier to compile WebRTC without unneeded components.
> > > > > > 
> > > > > > BUG=webrtc:4867
> > > > > > 
> > > > > > Review-Url: https://codereview.webrtc.org/2862543002
> > > > > > Cr-Commit-Position: refs/heads/master@{#18166}
> > > > > > Committed:
https://chromium.googlesource.com/external/webrtc/+/52c83fe7102f566cf35a75330...
> > > > > 
> > > > >
TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.or...
> > > > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > > > NOPRESUBMIT=true
> > > > > NOTREECHECKS=true
> > > > > NOTRY=true
> > > > > BUG=webrtc:4867
> > > > > 
> > > > > Review-Url: https://codereview.webrtc.org/2890513002
> > > > > Cr-Commit-Position: refs/heads/master@{#18170}
> > > > > Committed:
https://chromium.googlesource.com/external/webrtc/+/9756238084707787f735e1294...
> > > > 
> > > >
TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.or...
> > > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > > NOPRESUBMIT=true
> > > > NOTREECHECKS=true
> > > > NOTRY=true
> > > > BUG=webrtc:4867
> > > > 
> > > > Review-Url: https://codereview.webrtc.org/2890733003
> > > > Cr-Commit-Position: refs/heads/master@{#18174}
> > > > Committed:
https://chromium.googlesource.com/external/webrtc/+/d51e042492bedd057bc0cac78...
> > > 
> > >
TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.or...
> > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=webrtc:4867
> > > 
> > > Review-Url: https://codereview.webrtc.org/2893593002
> > > Cr-Commit-Position: refs/heads/master@{#18182}
> > > Committed:
https://chromium.googlesource.com/external/webrtc/+/37144b214e2baf62ecb262ab8...
> > 
> >
TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.or...
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=webrtc:4867
> > 
> > Review-Url: https://codereview.webrtc.org/2893843003
> > Cr-Commit-Position: refs/heads/master@{#18303}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/580c3522d294c877adfe55504...
> 
>
TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.or...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:4867
> 
> Review-Url: https://codereview.webrtc.org/2911053002
> Cr-Commit-Position: refs/heads/master@{#18309}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/af5c05540cc8208f682cafe88...

TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.or...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4867
==========

to

==========
Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of
https://codereview.webrtc.org/2911053002/ )

Reason for revert:
Take three of relanding this after all internal issues have been resolved.

Original issue's description:
> Revert of Split iOS sdk in to separate targets (patchset #3 id:320001 of
https://codereview.webrtc.org/2893843003/ )
> 
> Reason for revert:
> Breaks downstream project.
> 
> Original issue's description:
> > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of
https://codereview.webrtc.org/2893593002/ )
> > 
> > Reason for revert:
> > Take two of fixing downstream issues?
> > 
> > Original issue's description:
> > > Revert of Split iOS sdk in to separate targets (patchset #1 id:1 of
https://codereview.webrtc.org/2890733003/ )
> > > 
> > > Reason for revert:
> > > Still problems with downstream projects
> > > 
> > > Original issue's description:
> > > > Reland of Split iOS sdk in to separate targets (patchset #1 id:1 of
https://codereview.webrtc.org/2890513002/ )
> > > > 
> > > > Reason for revert:
> > > > Fixing downstream breakages
> > > > 
> > > > Original issue's description:
> > > > > Revert of Split iOS sdk in to separate targets (patchset #13 id:280001
of https://codereview.webrtc.org/2862543002/ )
> > > > > 
> > > > > Reason for revert:
> > > > > Breaking downstream projects.
> > > > > 
> > > > > Original issue's description:
> > > > > > Split iOS sdk in to separate targets
> > > > > > 
> > > > > > This CL splits the iOS sdk into separate static libraries for video,
> > > > > > audio, ui, common, and peerconnection-related code. This will in the
> > > > > > future make it easier to compile WebRTC without unneeded components.
> > > > > > 
> > > > > > BUG=webrtc:4867
> > > > > > 
> > > > > > Review-Url: https://codereview.webrtc.org/2862543002
> > > > > > Cr-Commit-Position: refs/heads/master@{#18166}
> > > > > > Committed:
https://chromium.googlesource.com/external/webrtc/+/52c83fe7102f566cf35a75330...
> > > > > 
> > > > >
TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.or...
> > > > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > > > NOPRESUBMIT=true
> > > > > NOTREECHECKS=true
> > > > > NOTRY=true
> > > > > BUG=webrtc:4867
> > > > > 
> > > > > Review-Url: https://codereview.webrtc.org/2890513002
> > > > > Cr-Commit-Position: refs/heads/master@{#18170}
> > > > > Committed:
https://chromium.googlesource.com/external/webrtc/+/9756238084707787f735e1294...
> > > > 
> > > >
TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.or...
> > > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > > NOPRESUBMIT=true
> > > > NOTREECHECKS=true
> > > > NOTRY=true
> > > > BUG=webrtc:4867
> > > > 
> > > > Review-Url: https://codereview.webrtc.org/2890733003
> > > > Cr-Commit-Position: refs/heads/master@{#18174}
> > > > Committed:
https://chromium.googlesource.com/external/webrtc/+/d51e042492bedd057bc0cac78...
> > > 
> > >
TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.or...
> > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=webrtc:4867
> > > 
> > > Review-Url: https://codereview.webrtc.org/2893593002
> > > Cr-Commit-Position: refs/heads/master@{#18182}
> > > Committed:
https://chromium.googlesource.com/external/webrtc/+/37144b214e2baf62ecb262ab8...
> > 
> >
TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.or...
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=webrtc:4867
> > 
> > Review-Url: https://codereview.webrtc.org/2893843003
> > Cr-Commit-Position: refs/heads/master@{#18303}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/580c3522d294c877adfe55504...
> 
>
TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.or...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=webrtc:4867
> 
> Review-Url: https://codereview.webrtc.org/2911053002
> Cr-Commit-Position: refs/heads/master@{#18309}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/af5c05540cc8208f682cafe88...

TBR=magjed@webrtc.org,denicija@webrtc.org,tkchin@webrtc.org,henrika@webrtc.or...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:4867

Review-Url: https://codereview.webrtc.org/2913753003
Cr-Commit-Position: refs/heads/master@{#18319}
Committed:
https://chromium.googlesource.com/external/webrtc/+/2f08879fb19db40cc1c35c823...
==========

[commit-bot: I haz the power, 2017-05-30 08:48:53]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/2f08879fb19db40cc1c35c823...

[hbos, 2017-05-30 12:20:59]

hbos@webrtc.org changed reviewers:
+ hbos@webrtc.org

[hbos, 2017-05-30 12:21:01]

https://codereview.webrtc.org/2913753003/diff/1/webrtc/test/BUILD.gn
File webrtc/test/BUILD.gn (right):

https://codereview.webrtc.org/2913753003/diff/1/webrtc/test/BUILD.gn#newcode320
webrtc/test/BUILD.gn:320: "//webrtc/sdk:objc_common",
This breaks webrtc into chromium preventing roll:

/b/build/slave/ios-simulator/build/src/buildtools/mac/gn gen
//out/Debug-iphonesimulator --check
  -> returned 1
ERROR at //third_party/webrtc/test/BUILD.gn:320:7: Can't load input file.
      "//webrtc/sdk:objc_common",
      ^-------------------------
Unable to load:
  /b/build/slave/ios-simulator/build/src/webrtc/sdk/BUILD.gn
I also checked in the secondary tree for:
  /b/build/slave/ios-simulator/build/src/build/secondary/webrtc/sdk/BUILD.gn
GN gen failed: 1

On ios bots:
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2...

See roll CL:
https://codereview.chromium.org/2907393002/

Could it be that the absolute filepath "//" refers to chromium/src instead of
chromium/third_party/ where webrtc is located?

[mbonadei, 2017-05-30 12:24:20]

On 2017/05/30 12:21:01, hbos wrote:
> https://codereview.webrtc.org/2913753003/diff/1/webrtc/test/BUILD.gn
> File webrtc/test/BUILD.gn (right):
> 
>
https://codereview.webrtc.org/2913753003/diff/1/webrtc/test/BUILD.gn#newcode320
> webrtc/test/BUILD.gn:320: "//webrtc/sdk:objc_common",
> This breaks webrtc into chromium preventing roll:
> 
> /b/build/slave/ios-simulator/build/src/buildtools/mac/gn gen
> //out/Debug-iphonesimulator --check
>   -> returned 1
> ERROR at //third_party/webrtc/test/BUILD.gn:320:7: Can't load input file.
>       "//webrtc/sdk:objc_common",
>       ^-------------------------
> Unable to load:
>   /b/build/slave/ios-simulator/build/src/webrtc/sdk/BUILD.gn
> I also checked in the secondary tree for:
>   /b/build/slave/ios-simulator/build/src/build/secondary/webrtc/sdk/BUILD.gn
> GN gen failed: 1
> 
> On ios bots:
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2...
> 
> See roll CL:
> https://codereview.chromium.org/2907393002/
> 
> Could it be that the absolute filepath "//" refers to chromium/src instead of
> chromium/third_party/ where webrtc is located?

Yep, I think it should a relative path.
Let me create a CL for this so we can fix without revert.

[hbos, 2017-05-30 12:27:06]

On 2017/05/30 12:24:20, mbonadei wrote:
> On 2017/05/30 12:21:01, hbos wrote:
> > https://codereview.webrtc.org/2913753003/diff/1/webrtc/test/BUILD.gn
> > File webrtc/test/BUILD.gn (right):
> > 
> >
>
https://codereview.webrtc.org/2913753003/diff/1/webrtc/test/BUILD.gn#newcode320
> > webrtc/test/BUILD.gn:320: "//webrtc/sdk:objc_common",
> > This breaks webrtc into chromium preventing roll:
> > 
> > /b/build/slave/ios-simulator/build/src/buildtools/mac/gn gen
> > //out/Debug-iphonesimulator --check
> >   -> returned 1
> > ERROR at //third_party/webrtc/test/BUILD.gn:320:7: Can't load input file.
> >       "//webrtc/sdk:objc_common",
> >       ^-------------------------
> > Unable to load:
> >   /b/build/slave/ios-simulator/build/src/webrtc/sdk/BUILD.gn
> > I also checked in the secondary tree for:
> >   /b/build/slave/ios-simulator/build/src/build/secondary/webrtc/sdk/BUILD.gn
> > GN gen failed: 1
> > 
> > On ios bots:
> >
>
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.mac%2...
> > 
> > See roll CL:
> > https://codereview.chromium.org/2907393002/
> > 
> > Could it be that the absolute filepath "//" refers to chromium/src instead
of
> > chromium/third_party/ where webrtc is located?
> 
> Yep, I think it should a relative path.
> Let me create a CL for this so we can fix without revert.

OK, keep me updated!

[VladimirTechMan, 2017-05-31 01:13:16]

On 2017/05/30 08:02:48, kthelgason wrote:
> Created Reland of Split iOS sdk in to separate targets

Hi Kári,

I am wondering if and why all of the following header files needed to be removed
from the list of public headers (i.e. from common_objc_headers inside
webrtc/sdk/BUILD.gn):
RTCAudioSource.h, RTCAudioTrack.h, RTCCameraPreviewView.h,
RTCCameraVideoCapturer.h, RTCMTLVideoView.h

For example, is it planned to remove RTCCameraPreviewView completely, going
forward? (I don't see why yet. But if that is the plan, it would be useful to
document it in CL description or comments, for future reference.)

In any case, those header files that are not supposed to be public anymore need
to be removed from WebRTC.h as well; otherwise, Xcode complains about it
(considering it "an error", thus aborting the compilation) for Swift-based
application code.

[kthelgason, 2017-05-31 08:16:30]

On 2017/05/31 01:13:16, VladimirTechMan wrote:
> On 2017/05/30 08:02:48, kthelgason wrote:
> > Created Reland of Split iOS sdk in to separate targets
> 
> Hi Kári,
> 
> I am wondering if and why all of the following header files needed to be
removed
> from the list of public headers (i.e. from common_objc_headers inside
> webrtc/sdk/BUILD.gn):
> RTCAudioSource.h, RTCAudioTrack.h, RTCCameraPreviewView.h,
> RTCCameraVideoCapturer.h, RTCMTLVideoView.h
> 
> For example, is it planned to remove RTCCameraPreviewView completely, going
> forward? (I don't see why yet. But if that is the plan, it would be useful to
> document it in CL description or comments, for future reference.)
> 
> In any case, those header files that are not supposed to be public anymore
need
> to be removed from WebRTC.h as well; otherwise, Xcode complains about it
> (considering it "an error", thus aborting the compilation) for Swift-based
> application code.

Hi Vladimir, I'm glad you noticed this. This is actually a bug and I have
submitted a CL to re-add the removed headers.
See here: https://chromium-review.googlesource.com/c/518942/

[hbos, 2017-05-31 08:48:27]

This CL broke chromium, with attempted fixes
https://codereview.webrtc.org/2908973005/ and now
https://chromium-review.googlesource.com/c/518942/.
These do not seem to fix the problem for ios-simulator bot, see
https://codereview.webrtc.org/2912313002/.

The more CLs we make the harder it gets to revert, and it's blocking rolling in
the meantime. If we don't understand what's going on shortly I think we should
revert.