Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2842533002: Revert of Enabling 'gn check' on //webrtc/test. (Closed)

Created:
3 years, 7 months ago by mbonadei
Modified:
3 years, 5 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Enabling 'gn check' on //webrtc/test. (patchset #3 id:90001 of https://codereview.webrtc.org/2815103005/ ) Reason for revert: Breaks Chromium because in Chromium we import WebRTC with rtc_include_tests=false (https://bugs.chromium.org/p/chromium/issues/detail?id=713179#c6). Chromium uses webrtc/test/fuzzers and this CL adds test dependencies to neteq_rtc_fuzzer. Original issue's description: > Reland of Enabling 'gn check' on //webrtc/test. (patchset #1 id:1 of https://codereview.webrtc.org/2817003002/ ) > > Reason for revert: > The original CL was breaking a downstream buildbot: https://build.chromium.org/p/client.webrtc/builders/Linux64%20Release%20%28Libfuzzer%29/builds/5429 > > This CL fixes some dependencies in: webrtc/test/fuzzers/BUILD.gn > (PS #2 and PS #3). > > BUG=webrtc:6828 > > Original issue's description: > > Revert of Enabling 'gn check' on //webrtc/test. (patchset #10 id:180001 of https://codereview.webrtc.org/2796363003/ ) > > > > Reason for revert: > > It is breaking a downstream bot. > > > > Original issue's description: > > > Enabling 'gn check' on //webrtc/test. > > > > > > BUG=webrtc:6828 > > > NOTRY=True > > > > > > Review-Url: https://codereview.webrtc.org/2796363003 > > > Cr-Commit-Position: refs/heads/master@{#17689} > > > Committed: https://chromium.googlesource.com/external/webrtc/+/b41445858e23fb757e5e10ac5631aa80e9e5eea9 > > > > TBR=kjellander@webrtc.org > > # Skipping CQ checks because original CL landed less than 1 days ago. > > NOPRESUBMIT=true > > NOTREECHECKS=true > > NOTRY=true > > BUG=webrtc:6828 > > > > Review-Url: https://codereview.webrtc.org/2817003002 > > Cr-Commit-Position: refs/heads/master@{#17690} > > Committed: https://chromium.googlesource.com/external/webrtc/+/8a24f47bad6eebb0fba10c3bbdb9556e43e19379 > > Review-Url: https://codereview.webrtc.org/2815103005 > Cr-Commit-Position: refs/heads/master@{#17758} > Committed: https://chromium.googlesource.com/external/webrtc/+/6f27633f47d0192f7cb04852be0988013e6c19dd TBR=kjellander@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:6828 NOTRY=True Review-Url: https://codereview.webrtc.org/2842533002 Cr-Commit-Position: refs/heads/master@{#17851} Committed: https://chromium.googlesource.com/external/webrtc/+/b80ef8c46ee12cf95cd6ca16af9d268a7b5fad8e

Patch Set 1 #

Patch Set 2 : Rebasing #

Patch Set 3 : running chromium trybots #

Patch Set 4 : Revert "running chromium trybots" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -93 lines) Patch
M .gn View 1 3 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/BUILD.gn View 1 13 chunks +1 line, -57 lines 0 comments Download
M webrtc/test/fuzzers/BUILD.gn View 1 17 chunks +10 lines, -35 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
mbonadei
Created Revert of Enabling 'gn check' on //webrtc/test.
3 years, 7 months ago (2017-04-24 19:10:40 UTC) #1
kjellander_webrtc
lgtm
3 years, 7 months ago (2017-04-24 19:34:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2842533002/140001
3 years, 7 months ago (2017-04-24 19:59:57 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2842533002/140001
3 years, 7 months ago (2017-04-24 20:00:57 UTC) #9
commit-bot: I haz the power
3 years, 7 months ago (2017-04-24 20:05:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #4 (id:140001) as
https://chromium.googlesource.com/external/webrtc/+/b80ef8c46ee12cf95cd6ca16a...

Powered by Google App Engine
This is Rietveld 408576698