Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 2817003002: Revert of Enabling 'gn check' on //webrtc/test. (Closed)

Created:
3 years, 8 months ago by mbonadei
Modified:
3 years, 8 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Enabling 'gn check' on //webrtc/test. (patchset #10 id:180001 of https://codereview.webrtc.org/2796363003/ ) Reason for revert: It is breaking a downstream bot. Original issue's description: > Enabling 'gn check' on //webrtc/test. > > BUG=webrtc:6828 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2796363003 > Cr-Commit-Position: refs/heads/master@{#17689} > Committed: https://chromium.googlesource.com/external/webrtc/+/b41445858e23fb757e5e10ac5631aa80e9e5eea9 TBR=kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6828 Review-Url: https://codereview.webrtc.org/2817003002 Cr-Commit-Position: refs/heads/master@{#17690} Committed: https://chromium.googlesource.com/external/webrtc/+/8a24f47bad6eebb0fba10c3bbdb9556e43e19379

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -59 lines) Patch
M .gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/BUILD.gn View 13 chunks +2 lines, -58 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mbonadei
Created Revert of Enabling 'gn check' on //webrtc/test.
3 years, 8 months ago (2017-04-13 09:13:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2817003002/1
3 years, 8 months ago (2017-04-13 09:13:06 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/8a24f47bad6eebb0fba10c3bbdb9556e43e19379
3 years, 8 months ago (2017-04-13 09:13:13 UTC) #6
mbonadei
3 years, 8 months ago (2017-04-13 09:15:44 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2815103005/ by mbonadei@webrtc.org.

The reason for reverting is: The original CL was breaking a downstream buildbot.

We have to fix some dependencies in: webrtc/test/fuzzers/..

Powered by Google App Engine
This is Rietveld 408576698