Enabling 'gn check' on //webrtc/test.

Enabling 'gn check' on //webrtc/test.

BUG=webrtc:6828
NOTRY=True

Review-Url: https://codereview.webrtc.org/2796363003
Cr-Commit-Position: refs/heads/master@{#17689}
Committed: https://chromium.googlesource.com/external/webrtc/+/b41445858e23fb757e5e10ac5631aa80e9e5eea9

[mbonadei, 2017-04-12 12:41:26]

mbonadei@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[kjellander_webrtc, 2017-04-12 13:15:01]

https://codereview.webrtc.org/2796363003/diff/80001/webrtc/test/BUILD.gn
File webrtc/test/BUILD.gn (right):

https://codereview.webrtc.org/2796363003/diff/80001/webrtc/test/BUILD.gn#newc...
webrtc/test/BUILD.gn:279: ":fake_audio_device",
Move these to line 327+.
According to the GN style guide targets should have sources in the beginning and
deps at the end.
They only ended up here because the empty deps list was put here.

https://codereview.webrtc.org/2796363003/diff/80001/webrtc/test/BUILD.gn#newc...
webrtc/test/BUILD.gn:453: "../modules/rtp_rtcp:rtp_rtcp",
whoa, does test_common really pull in this much? I guess it'll improve as more
stuff is moved into api/ in the future.

[kjellander_webrtc, 2017-04-12 13:15:21]

I'd suggest to make a PS to run chromium trybots as well.

[mbonadei, 2017-04-12 13:51:44]

On 2017/04/12 13:15:21, kjellander_webrtc wrote:
> I'd suggest to make a PS to run chromium trybots as well.

Ok.

Patch sets #6 and #7 are identical (I don't know why they have been 
uploaded twice). I have fixed the coding standard and I have also
fixed other 'gn check' problems on recently added code.

[mbonadei, 2017-04-12 13:51:55]

https://codereview.webrtc.org/2796363003/diff/80001/webrtc/test/BUILD.gn
File webrtc/test/BUILD.gn (right):

https://codereview.webrtc.org/2796363003/diff/80001/webrtc/test/BUILD.gn#newc...
webrtc/test/BUILD.gn:279: ":fake_audio_device",
On 2017/04/12 13:15:01, kjellander_webrtc wrote:
> Move these to line 327+.
> According to the GN style guide targets should have sources in the beginning
and
> deps at the end.
> They only ended up here because the empty deps list was put here.

Done, good catch!

[kjellander_webrtc, 2017-04-12 13:59:28]

lgtm

[mbonadei, 2017-04-13 08:24:05]

On 2017/04/12 13:59:28, kjellander_webrtc wrote:
> lgtm

In patch set #10 I have only fixed some coding standards like:

deps = ["a:a"] --> deps = ["a"]

[mbonadei, 2017-04-13 08:39:52]

The CQ bit was checked by mbonadei@webrtc.org

[mbonadei, 2017-04-13 08:39:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2796363003/#ps180001 (title:
"Fixing Gn coding standards")

[commit-bot: I haz the power, 2017-04-13 08:40:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-13 08:42:14]

CQ is committing da patch.

Bot data: {"patchset_id": 180001, "attempt_start_ts": 1492072792798270,
"parent_rev": "cb067fa117afd9ef4e1e18daf97a7bdd35888a75", "commit_rev":
"b41445858e23fb757e5e10ac5631aa80e9e5eea9"}

[commit-bot: I haz the power, 2017-04-13 08:42:17]

Description was changed from

==========
Enabling 'gn check' on //webrtc/test.

BUG=webrtc:6828
NOTRY=True
==========

to

==========
Enabling 'gn check' on //webrtc/test.

BUG=webrtc:6828
NOTRY=True

Review-Url: https://codereview.webrtc.org/2796363003
Cr-Commit-Position: refs/heads/master@{#17689}
Committed:
https://chromium.googlesource.com/external/webrtc/+/b41445858e23fb757e5e10ac5...
==========

[commit-bot: I haz the power, 2017-04-13 08:42:18]

Committed patchset #10 (id:180001) as
https://chromium.googlesource.com/external/webrtc/+/b41445858e23fb757e5e10ac5...

[mbonadei, 2017-04-13 09:13:01]

A revert of this CL (patchset #10 id:180001) has been created in
https://codereview.webrtc.org/2817003002/ by mbonadei@webrtc.org.

The reason for reverting is: It is breaking a downstream bot..