Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2815103005: Reland of Enabling 'gn check' on //webrtc/test. (Closed)

Created:
3 years, 8 months ago by mbonadei
Modified:
3 years, 8 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Enabling 'gn check' on //webrtc/test. (patchset #1 id:1 of https://codereview.webrtc.org/2817003002/ ) Reason for revert: The original CL was breaking a downstream buildbot: https://build.chromium.org/p/client.webrtc/builders/Linux64%20Release%20%28Libfuzzer%29/builds/5429 This CL fixes some dependencies in: webrtc/test/fuzzers/BUILD.gn (PS #2 and PS #3). BUG=webrtc:6828 Original issue's description: > Revert of Enabling 'gn check' on //webrtc/test. (patchset #10 id:180001 of https://codereview.webrtc.org/2796363003/ ) > > Reason for revert: > It is breaking a downstream bot. > > Original issue's description: > > Enabling 'gn check' on //webrtc/test. > > > > BUG=webrtc:6828 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2796363003 > > Cr-Commit-Position: refs/heads/master@{#17689} > > Committed: https://chromium.googlesource.com/external/webrtc/+/b41445858e23fb757e5e10ac5631aa80e9e5eea9 > > TBR=kjellander@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:6828 > > Review-Url: https://codereview.webrtc.org/2817003002 > Cr-Commit-Position: refs/heads/master@{#17690} > Committed: https://chromium.googlesource.com/external/webrtc/+/8a24f47bad6eebb0fba10c3bbdb9556e43e19379 Review-Url: https://codereview.webrtc.org/2815103005 Cr-Commit-Position: refs/heads/master@{#17758} Committed: https://chromium.googlesource.com/external/webrtc/+/6f27633f47d0192f7cb04852be0988013e6c19dd

Patch Set 1 #

Patch Set 2 : Fixing deps in webrtc/test/fuzzer/BUILD.gn #

Patch Set 3 : Adding rtc_event_log_impl dep #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -11 lines) Patch
M .gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/test/BUILD.gn View 1 13 chunks +57 lines, -1 line 0 comments Download
M webrtc/test/fuzzers/BUILD.gn View 1 2 17 chunks +35 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
mbonadei
Created Reland of Enabling 'gn check' on //webrtc/test.
3 years, 8 months ago (2017-04-13 09:15:44 UTC) #1
mbonadei
On 2017/04/13 09:15:44, mbonadei wrote: > Created Reland of Enabling 'gn check' on //webrtc/test. PTAL.
3 years, 8 months ago (2017-04-18 10:04:12 UTC) #4
kjellander_webrtc
lgtm
3 years, 8 months ago (2017-04-19 09:29:37 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2815103005/90001
3 years, 8 months ago (2017-04-19 09:32:03 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:90001) as https://chromium.googlesource.com/external/webrtc/+/6f27633f47d0192f7cb04852be0988013e6c19dd
3 years, 8 months ago (2017-04-19 09:58:38 UTC) #10
mbonadei
A revert of this CL (patchset #3 id:90001) has been created in https://codereview.webrtc.org/2833303005/ by mbonadei@webrtc.org. ...
3 years, 8 months ago (2017-04-24 18:51:02 UTC) #11
mbonadei
3 years, 8 months ago (2017-04-24 19:10:39 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:90001) has been created in
https://codereview.webrtc.org/2842533002/ by mbonadei@webrtc.org.

The reason for reverting is: Breaks Chromium because in Chromium we import
WebRTC with rtc_include_tests=false
(https://bugs.chromium.org/p/chromium/issues/detail?id=713179#c6)..

Powered by Google App Engine
This is Rietveld 408576698