Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2792103002: Reland of Adding PRESUBMIT check on google::protobuf (Closed)

Created:
3 years, 8 months ago by mbonadei
Modified:
3 years, 8 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Adding PRESUBMIT check on google::protobuf (patchset #1 id:1 of https://codereview.webrtc.org/2791583002/ ) Reason for revert: This should be landed after https://codereview.webrtc.org/2791963003. Original issue's description: > Revert of Adding PRESUBMIT check on google::protobuf (patchset #2 id:20001 of https://codereview.webrtc.org/2753823003/ ) > > Reason for revert: > We have to revert https://codereview.webrtc.org/2747863003 and this CL depends on it. > > Original issue's description: > > Adding PRESUBMIT check on google::protobuf > > > > The goal is to avoid direct usage of google::protobuf. > > > > It should only be used with a 'using' directive in the header file: > > //webrtc/base/protobuf_utils.h. > > > > BUG=webrtc:7340 > > NOTRY=True > > > > Review-Url: https://codereview.webrtc.org/2753823003 > > Cr-Commit-Position: refs/heads/master@{#17467} > > Committed: https://chromium.googlesource.com/external/webrtc/+/dd27055cb78aa839659ed9e9f0656a265c285ae7 > > TBR=kjellander@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=webrtc:7340 > > Review-Url: https://codereview.webrtc.org/2791583002 > Cr-Commit-Position: refs/heads/master@{#17481} > Committed: https://chromium.googlesource.com/external/webrtc/+/515dff40b711c70780612f2a4850e151a28bacde TBR=kjellander@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7340 Review-Url: https://codereview.webrtc.org/2792103002 Cr-Commit-Position: refs/heads/master@{#17588} Committed: https://chromium.googlesource.com/external/webrtc/+/38415b2d8e7a4a5a3c4ac52e24c6ecc31c2da007

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M PRESUBMIT.py View 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mbonadei
Created Reland of Adding PRESUBMIT check on google::protobuf
3 years, 8 months ago (2017-04-03 18:31:34 UTC) #1
kjellander_webrtc
lgtm
3 years, 8 months ago (2017-04-04 05:41:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2792103002/1
3 years, 8 months ago (2017-04-07 12:16:35 UTC) #4
commit-bot: I haz the power
3 years, 8 months ago (2017-04-07 12:38:10 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/38415b2d8e7a4a5a3c4ac52e2...

Powered by Google App Engine
This is Rietveld 408576698