Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Issue 2791583002: Revert of Adding PRESUBMIT check on google::protobuf (Closed)

Created:
3 years, 8 months ago by mbonadei
Modified:
3 years, 8 months ago
Reviewers:
kjellander_webrtc
CC:
webrtc-reviews_webrtc.org, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Adding PRESUBMIT check on google::protobuf (patchset #2 id:20001 of https://codereview.webrtc.org/2753823003/ ) Reason for revert: We have to revert https://codereview.webrtc.org/2747863003 and this CL depends on it. Original issue's description: > Adding PRESUBMIT check on google::protobuf > > The goal is to avoid direct usage of google::protobuf. > > It should only be used with a 'using' directive in the header file: > //webrtc/base/protobuf_utils.h. > > BUG=webrtc:7340 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2753823003 > Cr-Commit-Position: refs/heads/master@{#17467} > Committed: https://chromium.googlesource.com/external/webrtc/+/dd27055cb78aa839659ed9e9f0656a265c285ae7 TBR=kjellander@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7340 Review-Url: https://codereview.webrtc.org/2791583002 Cr-Commit-Position: refs/heads/master@{#17481} Committed: https://chromium.googlesource.com/external/webrtc/+/515dff40b711c70780612f2a4850e151a28bacde

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M PRESUBMIT.py View 2 chunks +0 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mbonadei
Created Revert of Adding PRESUBMIT check on google::protobuf
3 years, 8 months ago (2017-03-31 08:53:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2791583002/1
3 years, 8 months ago (2017-03-31 08:53:18 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/515dff40b711c70780612f2a4850e151a28bacde
3 years, 8 months ago (2017-03-31 09:36:32 UTC) #6
mbonadei
3 years, 8 months ago (2017-04-03 18:31:33 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2792103002/ by mbonadei@webrtc.org.

The reason for reverting is: This should be landed after
https://codereview.webrtc.org/2791963003..

Powered by Google App Engine
This is Rietveld 408576698