Adding PRESUBMIT check on google::protobuf

Adding PRESUBMIT check on google::protobuf

The goal is to avoid direct usage of google::protobuf.

It should only be used with a 'using' directive in the header file:
//webrtc/base/protobuf_utils.h.

BUG=webrtc:7340
NOTRY=True

Review-Url: https://codereview.webrtc.org/2753823003
Cr-Commit-Position: refs/heads/master@{#17467}
Committed: https://chromium.googlesource.com/external/webrtc/+/dd27055cb78aa839659ed9e9f0656a265c285ae7

[mbonadei, 2017-03-16 13:11:08]

Description was changed from

==========
Adding PRESUBMIT check

The goal is to avoid direct usage of google::protobuf.
It should be only used with a 'using' directive in the header:
//webrtc/base/protobuf_utils.h.

BUG=webrtc:7340
NOTRY=True
==========

to

==========
Adding PRESUBMIT check on google::protobuf

The goal is to avoid direct usage of google::protobuf.

It should only be used with a 'using' directive in the header file:
//webrtc/base/protobuf_utils.h.

BUG=webrtc:7340
NOTRY=True
==========

[mbonadei, 2017-03-16 13:11:08]

mbonadei@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[kjellander_webrtc, 2017-03-16 16:41:04]

lgtm with a comment. I assume you tested this on some local changes?

https://codereview.webrtc.org/2753823003/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/2753823003/diff/1/PRESUBMIT.py#newcode491
PRESUBMIT.py:491: 'Add a using directive to `%s`. Affected files:\n' %
proto_utils_path,
How about a minor change to:
Add a using directive in `%s` and include that header instead.

[mbonadei, 2017-03-16 19:15:42]

On 2017/03/16 16:41:04, kjellander_webrtc wrote:
> lgtm with a comment. I assume you tested this on some local changes?
> 
> https://codereview.webrtc.org/2753823003/diff/1/PRESUBMIT.py
> File PRESUBMIT.py (right):
> 
> https://codereview.webrtc.org/2753823003/diff/1/PRESUBMIT.py#newcode491
> PRESUBMIT.py:491: 'Add a using directive to `%s`. Affected files:\n' %
> proto_utils_path,
> How about a minor change to:
> Add a using directive in `%s` and include that header instead.

Yep, I tried that on the other CL. But I have just tested it again with a fake
commit:

** Presubmit ERRORS **
Please avoid to use namespace `google::protobuf` directly.
Add a using directive in `webrtc/base/protobuf_utils.h` and include that header
instead.
  webrtc/logging/rtc_event_log/rtc_event_log_parser.cc

When I reset to HEAD^ then the error goes away.

[mbonadei, 2017-03-16 19:15:53]

https://codereview.webrtc.org/2753823003/diff/1/PRESUBMIT.py
File PRESUBMIT.py (right):

https://codereview.webrtc.org/2753823003/diff/1/PRESUBMIT.py#newcode491
PRESUBMIT.py:491: 'Add a using directive to `%s`. Affected files:\n' %
proto_utils_path,
On 2017/03/16 16:41:04, kjellander_webrtc wrote:
> How about a minor change to:
> Add a using directive in `%s` and include that header instead.
> 

Done.

[mbonadei, 2017-03-30 08:27:19]

The CQ bit was checked by mbonadei@webrtc.org

[mbonadei, 2017-03-30 08:27:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2753823003/#ps20001 (title:
"Updating error message")

[commit-bot: I haz the power, 2017-03-30 08:27:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-30 08:30:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490862439694550,
"parent_rev": "16ab93b952f9e8268f2e663ffe49548e8043d5af", "commit_rev":
"dd27055cb78aa839659ed9e9f0656a265c285ae7"}

[commit-bot: I haz the power, 2017-03-30 08:30:16]

Description was changed from

==========
Adding PRESUBMIT check on google::protobuf

The goal is to avoid direct usage of google::protobuf.

It should only be used with a 'using' directive in the header file:
//webrtc/base/protobuf_utils.h.

BUG=webrtc:7340
NOTRY=True
==========

to

==========
Adding PRESUBMIT check on google::protobuf

The goal is to avoid direct usage of google::protobuf.

It should only be used with a 'using' directive in the header file:
//webrtc/base/protobuf_utils.h.

BUG=webrtc:7340
NOTRY=True

Review-Url: https://codereview.webrtc.org/2753823003
Cr-Commit-Position: refs/heads/master@{#17467}
Committed:
https://chromium.googlesource.com/external/webrtc/+/dd27055cb78aa839659ed9e9f...
==========

[commit-bot: I haz the power, 2017-03-30 08:30:17]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/dd27055cb78aa839659ed9e9f...

[mbonadei, 2017-03-31 08:53:14]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/2791583002/ by mbonadei@webrtc.org.

The reason for reverting is: We have to revert
https://codereview.webrtc.org/2747863003 and this CL depends on it..