Reland of Loosening the coupling between WebRTC and //third_party/protobuf

Reland of Loosening the coupling between WebRTC and //third_party/protobuf (patchset #1 id:1 of https://codereview.webrtc.org/2786363002/ )

Reason for revert:
Trying to re-land after solving some related issues.

There are no changes compared to the original CL.

Original issue's description:
> Revert of Loosening the coupling between WebRTC and //third_party/protobuf (patchset #16 id:300001 of https://codereview.webrtc.org/2747863003/ )
> 
> Reason for revert:
> I will try to reland next week because it is causing some problems.
> 
> Original issue's description:
> > To accommodate some downstream WebRTC users we need to loosen
> > the coupling between our code and the //third_party/protobuf.
> > 
> > This includes using typedefs to define strings instead of
> > assuming std::string.
> > 
> > After this refactoring it will be possible to link with other
> > protobuf implementations than the current one.
> > 
> > We moved the PRESUBMIT check to another CL [1]. The goal of this
> > presubmit is to avoid the direct usage of google::protobuf outside
> > of the webrtc/base/protobuf_utils.h header file.
> > 
> > [1] - https://codereview.webrtc.org/2753823003/
> > 
> > BUG=webrtc:7340
> > NOTRY=True
> > 
> > Review-Url: https://codereview.webrtc.org/2747863003
> > Cr-Commit-Position: refs/heads/master@{#17466}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/16ab93b952f9e8268f2e663ffe49548e8043d5af
> 
> TBR=kjellander@webrtc.org,henrik.lundin@webrtc.org,kwiberg@webrtc.org,michaelt@webrtc.org,peah@webrtc.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=webrtc:7340
> 
> Review-Url: https://codereview.webrtc.org/2786363002
> Cr-Commit-Position: refs/heads/master@{#17483}
> Committed: https://chromium.googlesource.com/external/webrtc/+/d00aad5eb2fa5a7b5aeda714f7702b50cd26ee28

TBR=kjellander@webrtc.org,henrik.lundin@webrtc.org,kwiberg@webrtc.org,michaelt@webrtc.org,peah@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:7340
NOTRY=True

Review-Url: https://codereview.webrtc.org/2791963003
Cr-Commit-Position: refs/heads/master@{#17584}
Committed: https://chromium.googlesource.com/external/webrtc/+/7c2c8438f1356a4f4311e4ba35c2c45209ad431d

[mbonadei, 2017-04-03 18:30:40]

Created Reland of Loosening the coupling between WebRTC and
//third_party/protobuf

[kwiberg-webrtc, 2017-04-03 19:49:02]

On 2017/04/03 18:30:40, mbonadei wrote:
> Created Reland of Loosening the coupling between WebRTC and
> //third_party/protobuf

When re-landing a CL, please upload the unmodified original CL as patch set #1,
and the new changes in patch set #2. That makes it *much* easier to review.

Also, please state in the commit message what the changes are relative to the
original CL. If there are no changes, state that.

[mbonadei, 2017-04-03 20:16:38]

Description was changed from

==========
Reland of Loosening the coupling between WebRTC and //third_party/protobuf
(patchset #1 id:1 of https://codereview.webrtc.org/2786363002/ )

Reason for revert:
Trying to re-land after solving some related issues.

Original issue's description:
> Revert of Loosening the coupling between WebRTC and //third_party/protobuf
(patchset #16 id:300001 of https://codereview.webrtc.org/2747863003/ )
> 
> Reason for revert:
> I will try to reland next week because it is causing some problems.
> 
> Original issue's description:
> > To accommodate some downstream WebRTC users we need to loosen
> > the coupling between our code and the //third_party/protobuf.
> > 
> > This includes using typedefs to define strings instead of
> > assuming std::string.
> > 
> > After this refactoring it will be possible to link with other
> > protobuf implementations than the current one.
> > 
> > We moved the PRESUBMIT check to another CL [1]. The goal of this
> > presubmit is to avoid the direct usage of google::protobuf outside
> > of the webrtc/base/protobuf_utils.h header file.
> > 
> > [1] - https://codereview.webrtc.org/2753823003/
> > 
> > BUG=webrtc:7340
> > NOTRY=True
> > 
> > Review-Url: https://codereview.webrtc.org/2747863003
> > Cr-Commit-Position: refs/heads/master@{#17466}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/16ab93b952f9e8268f2e663ff...
> 
>
TBR=kjellander@webrtc.org,henrik.lundin@webrtc.org,kwiberg@webrtc.org,michael...
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=webrtc:7340
> 
> Review-Url: https://codereview.webrtc.org/2786363002
> Cr-Commit-Position: refs/heads/master@{#17483}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/d00aad5eb2fa5a7b5aeda714f...

TBR=kjellander@webrtc.org,henrik.lundin@webrtc.org,kwiberg@webrtc.org,michael...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:7340
==========

to

==========
Reland of Loosening the coupling between WebRTC and //third_party/protobuf
(patchset #1 id:1 of https://codereview.webrtc.org/2786363002/ )

Reason for revert:
Trying to re-land after solving some related issues.

There are no changes compared to the original CL.

Original issue's description:
> Revert of Loosening the coupling between WebRTC and //third_party/protobuf
(patchset #16 id:300001 of https://codereview.webrtc.org/2747863003/ )
> 
> Reason for revert:
> I will try to reland next week because it is causing some problems.
> 
> Original issue's description:
> > To accommodate some downstream WebRTC users we need to loosen
> > the coupling between our code and the //third_party/protobuf.
> > 
> > This includes using typedefs to define strings instead of
> > assuming std::string.
> > 
> > After this refactoring it will be possible to link with other
> > protobuf implementations than the current one.
> > 
> > We moved the PRESUBMIT check to another CL [1]. The goal of this
> > presubmit is to avoid the direct usage of google::protobuf outside
> > of the webrtc/base/protobuf_utils.h header file.
> > 
> > [1] - https://codereview.webrtc.org/2753823003/
> > 
> > BUG=webrtc:7340
> > NOTRY=True
> > 
> > Review-Url: https://codereview.webrtc.org/2747863003
> > Cr-Commit-Position: refs/heads/master@{#17466}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/16ab93b952f9e8268f2e663ff...
> 
>
TBR=kjellander@webrtc.org,henrik.lundin@webrtc.org,kwiberg@webrtc.org,michael...
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=webrtc:7340
> 
> Review-Url: https://codereview.webrtc.org/2786363002
> Cr-Commit-Position: refs/heads/master@{#17483}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/d00aad5eb2fa5a7b5aeda714f...

TBR=kjellander@webrtc.org,henrik.lundin@webrtc.org,kwiberg@webrtc.org,michael...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:7340
==========

[mbonadei, 2017-04-03 20:20:55]

On 2017/04/03 19:49:02, kwiberg-webrtc wrote:
> On 2017/04/03 18:30:40, mbonadei wrote:
> > Created Reland of Loosening the coupling between WebRTC and
> > //third_party/protobuf
> 
> When re-landing a CL, please upload the unmodified original CL as patch set
#1,
> and the new changes in patch set #2. That makes it *much* easier to review.
> 
> Also, please state in the commit message what the changes are relative to the
> original CL. If there are no changes, state that.

Yes, sorry for the poor CL description. I have just updated that. 
There are no changes compared to the original CL. The issues were in downstream
projects.

[kwiberg-webrtc, 2017-04-03 20:46:25]

On 2017/04/03 20:20:55, mbonadei wrote:
> On 2017/04/03 19:49:02, kwiberg-webrtc wrote:
> > On 2017/04/03 18:30:40, mbonadei wrote:
> > > Created Reland of Loosening the coupling between WebRTC and
> > > //third_party/protobuf
> > 
> > When re-landing a CL, please upload the unmodified original CL as patch set
> #1,
> > and the new changes in patch set #2. That makes it *much* easier to review.
> > 
> > Also, please state in the commit message what the changes are relative to
the
> > original CL. If there are no changes, state that.
> 
> Yes, sorry for the poor CL description. I have just updated that. 
> There are no changes compared to the original CL. The issues were in
downstream
> projects.

Excellent. Thanks!

[kwiberg-webrtc, 2017-04-03 20:46:33]

lgtm

[kjellander_webrtc, 2017-04-04 05:38:34]

On 2017/04/03 20:46:25, kwiberg-webrtc wrote:
> On 2017/04/03 20:20:55, mbonadei wrote:
> > On 2017/04/03 19:49:02, kwiberg-webrtc wrote:
> > > On 2017/04/03 18:30:40, mbonadei wrote:
> > > > Created Reland of Loosening the coupling between WebRTC and
> > > > //third_party/protobuf
> > > 
> > > When re-landing a CL, please upload the unmodified original CL as patch
set
> > #1,
> > > and the new changes in patch set #2. That makes it *much* easier to
review.
> > > 
> > > Also, please state in the commit message what the changes are relative to
> the
> > > original CL. If there are no changes, state that.
> > 
> > Yes, sorry for the poor CL description. I have just updated that. 
> > There are no changes compared to the original CL. The issues were in
> downstream
> > projects.
> 
> Excellent. Thanks!

It is annoying that Rietveld decides it's a good idea to send out an e-mail to
all reviewers as soon you revert a revert CL. I think it's a good habit to use
that method to create a nice template CL with a pristine revert in PS#1.
I've filed https://bugs.chromium.org/p/chromium/issues/detail?id=708071
requesting this to be fixed.

lgtm

[michaelt, 2017-04-04 06:30:20]

lgtm

[kwiberg-webrtc, 2017-04-04 08:08:27]

On 2017/04/04 05:38:34, kjellander_webrtc wrote:
> On 2017/04/03 20:46:25, kwiberg-webrtc wrote:
> > On 2017/04/03 20:20:55, mbonadei wrote:
> > > On 2017/04/03 19:49:02, kwiberg-webrtc wrote:
> > > > On 2017/04/03 18:30:40, mbonadei wrote:
> > > > > Created Reland of Loosening the coupling between WebRTC and
> > > > > //third_party/protobuf
> > > > 
> > > > When re-landing a CL, please upload the unmodified original CL as patch
> set
> > > #1,
> > > > and the new changes in patch set #2. That makes it *much* easier to
> review.
> > > > 
> > > > Also, please state in the commit message what the changes are relative
to
> > the
> > > > original CL. If there are no changes, state that.
> > > 
> > > Yes, sorry for the poor CL description. I have just updated that. 
> > > There are no changes compared to the original CL. The issues were in
> > downstream
> > > projects.
> > 
> > Excellent. Thanks!
> 
> It is annoying that Rietveld decides it's a good idea to send out an e-mail to
> all reviewers as soon you revert a revert CL. I think it's a good habit to use
> that method to create a nice template CL with a pristine revert in PS#1.
> I've filed https://bugs.chromium.org/p/chromium/issues/detail?id=708071
> requesting this to be fixed.

Yeah, I never use Rietveld to revert reverts---I never saw the point of not just
doing it locally with git.

[kjellander_webrtc, 2017-04-04 08:39:37]

On 2017/04/04 08:08:27, kwiberg-webrtc wrote:
> On 2017/04/04 05:38:34, kjellander_webrtc wrote:
> > On 2017/04/03 20:46:25, kwiberg-webrtc wrote:
> > > On 2017/04/03 20:20:55, mbonadei wrote:
> > > > On 2017/04/03 19:49:02, kwiberg-webrtc wrote:
> > > > > On 2017/04/03 18:30:40, mbonadei wrote:
> > > > > > Created Reland of Loosening the coupling between WebRTC and
> > > > > > //third_party/protobuf
> > > > > 
> > > > > When re-landing a CL, please upload the unmodified original CL as
patch
> > set
> > > > #1,
> > > > > and the new changes in patch set #2. That makes it *much* easier to
> > review.
> > > > > 
> > > > > Also, please state in the commit message what the changes are relative
> to
> > > the
> > > > > original CL. If there are no changes, state that.
> > > > 
> > > > Yes, sorry for the poor CL description. I have just updated that. 
> > > > There are no changes compared to the original CL. The issues were in
> > > downstream
> > > > projects.
> > > 
> > > Excellent. Thanks!
> > 
> > It is annoying that Rietveld decides it's a good idea to send out an e-mail
to
> > all reviewers as soon you revert a revert CL. I think it's a good habit to
use
> > that method to create a nice template CL with a pristine revert in PS#1.
> > I've filed https://bugs.chromium.org/p/chromium/issues/detail?id=708071
> > requesting this to be fixed.
> 
> Yeah, I never use Rietveld to revert reverts---I never saw the point of not
just
> doing it locally with git.

You get the nice commit message filled out for you + a pristine patch set
already uploaded so diffs for the reviewer is easier.
But sure, it can be done by locally using git revert, but it takes more effort.
Another advantage is that you get a message posted in the revert CL, informing
people that might want to follow the track.

[mbonadei, 2017-04-07 06:26:56]

The CQ bit was checked by mbonadei@webrtc.org

[mbonadei, 2017-04-07 06:26:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org, kwiberg@webrtc.org, michaelt@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2791963003/#ps270001 (title:
"Rebasing")

[commit-bot: I haz the power, 2017-04-07 06:27:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-07 06:31:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-07 06:31:34]

Try jobs failed on following builders:
  linux_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_arm64_dbg/builds/190)

[mbonadei, 2017-04-07 07:24:10]

On 2017/04/07 06:31:34, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_arm64_dbg on master.tryserver.webrtc (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.webrtc/builders/linux_arm64_dbg/builds/190)

Added a dependency on //webrtc/base/protobuf_utils in 
//webrtc/modules/audio_coding:builtin_audio_encoder_factory because it was
failing
to build.

I will follow up why it is needed because it seems strange that we need this.

[mbonadei, 2017-04-07 07:24:45]

Description was changed from

==========
Reland of Loosening the coupling between WebRTC and //third_party/protobuf
(patchset #1 id:1 of https://codereview.webrtc.org/2786363002/ )

Reason for revert:
Trying to re-land after solving some related issues.

There are no changes compared to the original CL.

Original issue's description:
> Revert of Loosening the coupling between WebRTC and //third_party/protobuf
(patchset #16 id:300001 of https://codereview.webrtc.org/2747863003/ )
> 
> Reason for revert:
> I will try to reland next week because it is causing some problems.
> 
> Original issue's description:
> > To accommodate some downstream WebRTC users we need to loosen
> > the coupling between our code and the //third_party/protobuf.
> > 
> > This includes using typedefs to define strings instead of
> > assuming std::string.
> > 
> > After this refactoring it will be possible to link with other
> > protobuf implementations than the current one.
> > 
> > We moved the PRESUBMIT check to another CL [1]. The goal of this
> > presubmit is to avoid the direct usage of google::protobuf outside
> > of the webrtc/base/protobuf_utils.h header file.
> > 
> > [1] - https://codereview.webrtc.org/2753823003/
> > 
> > BUG=webrtc:7340
> > NOTRY=True
> > 
> > Review-Url: https://codereview.webrtc.org/2747863003
> > Cr-Commit-Position: refs/heads/master@{#17466}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/16ab93b952f9e8268f2e663ff...
> 
>
TBR=kjellander@webrtc.org,henrik.lundin@webrtc.org,kwiberg@webrtc.org,michael...
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=webrtc:7340
> 
> Review-Url: https://codereview.webrtc.org/2786363002
> Cr-Commit-Position: refs/heads/master@{#17483}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/d00aad5eb2fa5a7b5aeda714f...

TBR=kjellander@webrtc.org,henrik.lundin@webrtc.org,kwiberg@webrtc.org,michael...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:7340
==========

to

==========
Reland of Loosening the coupling between WebRTC and //third_party/protobuf
(patchset #1 id:1 of https://codereview.webrtc.org/2786363002/ )

Reason for revert:
Trying to re-land after solving some related issues.

There are no changes compared to the original CL.

Original issue's description:
> Revert of Loosening the coupling between WebRTC and //third_party/protobuf
(patchset #16 id:300001 of https://codereview.webrtc.org/2747863003/ )
> 
> Reason for revert:
> I will try to reland next week because it is causing some problems.
> 
> Original issue's description:
> > To accommodate some downstream WebRTC users we need to loosen
> > the coupling between our code and the //third_party/protobuf.
> > 
> > This includes using typedefs to define strings instead of
> > assuming std::string.
> > 
> > After this refactoring it will be possible to link with other
> > protobuf implementations than the current one.
> > 
> > We moved the PRESUBMIT check to another CL [1]. The goal of this
> > presubmit is to avoid the direct usage of google::protobuf outside
> > of the webrtc/base/protobuf_utils.h header file.
> > 
> > [1] - https://codereview.webrtc.org/2753823003/
> > 
> > BUG=webrtc:7340
> > NOTRY=True
> > 
> > Review-Url: https://codereview.webrtc.org/2747863003
> > Cr-Commit-Position: refs/heads/master@{#17466}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/16ab93b952f9e8268f2e663ff...
> 
>
TBR=kjellander@webrtc.org,henrik.lundin@webrtc.org,kwiberg@webrtc.org,michael...
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=webrtc:7340
> 
> Review-Url: https://codereview.webrtc.org/2786363002
> Cr-Commit-Position: refs/heads/master@{#17483}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/d00aad5eb2fa5a7b5aeda714f...

TBR=kjellander@webrtc.org,henrik.lundin@webrtc.org,kwiberg@webrtc.org,michael...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:7340
NOTRY=True
==========

[mbonadei, 2017-04-07 07:56:04]

The CQ bit was checked by mbonadei@webrtc.org

[mbonadei, 2017-04-07 07:56:04]

The patchset sent to the CQ was uploaded after l-g-t-m from
kjellander@webrtc.org, kwiberg@webrtc.org, michaelt@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2791963003/#ps290001 (title:
"Fixing webrtc/modules/audio_coding:builtin_audio_encoder_factory")

[commit-bot: I haz the power, 2017-04-07 07:56:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-04-07 07:59:13]

CQ is committing da patch.

Bot data: {"patchset_id": 290001, "attempt_start_ts": 1491551764099840,
"parent_rev": "0944a80f3e12fd877e5856e68d941699d8f3e8c3", "commit_rev":
"7c2c8438f1356a4f4311e4ba35c2c45209ad431d"}

[commit-bot: I haz the power, 2017-04-07 07:59:17]

Description was changed from

==========
Reland of Loosening the coupling between WebRTC and //third_party/protobuf
(patchset #1 id:1 of https://codereview.webrtc.org/2786363002/ )

Reason for revert:
Trying to re-land after solving some related issues.

There are no changes compared to the original CL.

Original issue's description:
> Revert of Loosening the coupling between WebRTC and //third_party/protobuf
(patchset #16 id:300001 of https://codereview.webrtc.org/2747863003/ )
> 
> Reason for revert:
> I will try to reland next week because it is causing some problems.
> 
> Original issue's description:
> > To accommodate some downstream WebRTC users we need to loosen
> > the coupling between our code and the //third_party/protobuf.
> > 
> > This includes using typedefs to define strings instead of
> > assuming std::string.
> > 
> > After this refactoring it will be possible to link with other
> > protobuf implementations than the current one.
> > 
> > We moved the PRESUBMIT check to another CL [1]. The goal of this
> > presubmit is to avoid the direct usage of google::protobuf outside
> > of the webrtc/base/protobuf_utils.h header file.
> > 
> > [1] - https://codereview.webrtc.org/2753823003/
> > 
> > BUG=webrtc:7340
> > NOTRY=True
> > 
> > Review-Url: https://codereview.webrtc.org/2747863003
> > Cr-Commit-Position: refs/heads/master@{#17466}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/16ab93b952f9e8268f2e663ff...
> 
>
TBR=kjellander@webrtc.org,henrik.lundin@webrtc.org,kwiberg@webrtc.org,michael...
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=webrtc:7340
> 
> Review-Url: https://codereview.webrtc.org/2786363002
> Cr-Commit-Position: refs/heads/master@{#17483}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/d00aad5eb2fa5a7b5aeda714f...

TBR=kjellander@webrtc.org,henrik.lundin@webrtc.org,kwiberg@webrtc.org,michael...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:7340
NOTRY=True
==========

to

==========
Reland of Loosening the coupling between WebRTC and //third_party/protobuf
(patchset #1 id:1 of https://codereview.webrtc.org/2786363002/ )

Reason for revert:
Trying to re-land after solving some related issues.

There are no changes compared to the original CL.

Original issue's description:
> Revert of Loosening the coupling between WebRTC and //third_party/protobuf
(patchset #16 id:300001 of https://codereview.webrtc.org/2747863003/ )
> 
> Reason for revert:
> I will try to reland next week because it is causing some problems.
> 
> Original issue's description:
> > To accommodate some downstream WebRTC users we need to loosen
> > the coupling between our code and the //third_party/protobuf.
> > 
> > This includes using typedefs to define strings instead of
> > assuming std::string.
> > 
> > After this refactoring it will be possible to link with other
> > protobuf implementations than the current one.
> > 
> > We moved the PRESUBMIT check to another CL [1]. The goal of this
> > presubmit is to avoid the direct usage of google::protobuf outside
> > of the webrtc/base/protobuf_utils.h header file.
> > 
> > [1] - https://codereview.webrtc.org/2753823003/
> > 
> > BUG=webrtc:7340
> > NOTRY=True
> > 
> > Review-Url: https://codereview.webrtc.org/2747863003
> > Cr-Commit-Position: refs/heads/master@{#17466}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/16ab93b952f9e8268f2e663ff...
> 
>
TBR=kjellander@webrtc.org,henrik.lundin@webrtc.org,kwiberg@webrtc.org,michael...
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=webrtc:7340
> 
> Review-Url: https://codereview.webrtc.org/2786363002
> Cr-Commit-Position: refs/heads/master@{#17483}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/d00aad5eb2fa5a7b5aeda714f...

TBR=kjellander@webrtc.org,henrik.lundin@webrtc.org,kwiberg@webrtc.org,michael...
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:7340
NOTRY=True

Review-Url: https://codereview.webrtc.org/2791963003
Cr-Commit-Position: refs/heads/master@{#17584}
Committed:
https://chromium.googlesource.com/external/webrtc/+/7c2c8438f1356a4f4311e4ba3...
==========

[commit-bot: I haz the power, 2017-04-07 07:59:18]

Committed patchset #4 (id:290001) as
https://chromium.googlesource.com/external/webrtc/+/7c2c8438f1356a4f4311e4ba3...