Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2786363002: Revert of Loosening the coupling between WebRTC and //third_party/protobuf (Closed)

Created:
3 years, 8 months ago by mbonadei
Modified:
3 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, AleBzk, peah-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Loosening the coupling between WebRTC and //third_party/protobuf (patchset #16 id:300001 of https://codereview.webrtc.org/2747863003/ ) Reason for revert: I will try to reland next week because it is causing some problems. Original issue's description: > To accommodate some downstream WebRTC users we need to loosen > the coupling between our code and the //third_party/protobuf. > > This includes using typedefs to define strings instead of > assuming std::string. > > After this refactoring it will be possible to link with other > protobuf implementations than the current one. > > We moved the PRESUBMIT check to another CL [1]. The goal of this > presubmit is to avoid the direct usage of google::protobuf outside > of the webrtc/base/protobuf_utils.h header file. > > [1] - https://codereview.webrtc.org/2753823003/ > > BUG=webrtc:7340 > NOTRY=True > > Review-Url: https://codereview.webrtc.org/2747863003 > Cr-Commit-Position: refs/heads/master@{#17466} > Committed: https://chromium.googlesource.com/external/webrtc/+/16ab93b952f9e8268f2e663ffe49548e8043d5af TBR=kjellander@webrtc.org,henrik.lundin@webrtc.org,kwiberg@webrtc.org,michaelt@webrtc.org,peah@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=webrtc:7340 Review-Url: https://codereview.webrtc.org/2786363002 Cr-Commit-Position: refs/heads/master@{#17483} Committed: https://chromium.googlesource.com/external/webrtc/+/d00aad5eb2fa5a7b5aeda714f7702b50cd26ee28

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -117 lines) Patch
M webrtc/BUILD.gn View 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/base/BUILD.gn View 1 chunk +0 lines, -11 lines 0 comments Download
M webrtc/base/DEPS View 1 chunk +0 lines, -3 lines 0 comments Download
D webrtc/base/protobuf_utils.h View 1 chunk +0 lines, -36 lines 0 comments Download
M webrtc/logging/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_helper_thread.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/logging/rtc_event_log/rtc_event_log_parser.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/BUILD.gn View 7 chunks +0 lines, -8 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/controller_manager.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/controller_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/controller_manager_unittest.cc View 4 chunks +3 lines, -4 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/audio_coding/audio_network_adaptor/debug_dump_writer.cc View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/opus/audio_encoder_opus.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_unittest.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M webrtc/modules/audio_processing/BUILD.gn View 6 chunks +0 lines, -7 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.h View 3 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/audio_processing_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/audio_processing/test/protobuf_utils.h View 2 chunks +1 line, -2 lines 0 comments Download
M webrtc/modules/audio_processing/test/protobuf_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/tools/BUILD.gn View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mbonadei
Created Revert of Loosening the coupling between WebRTC and //third_party/protobuf
3 years, 8 months ago (2017-03-31 09:43:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2786363002/1
3 years, 8 months ago (2017-03-31 09:43:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/d00aad5eb2fa5a7b5aeda714f7702b50cd26ee28
3 years, 8 months ago (2017-03-31 10:08:11 UTC) #6
mbonadei
3 years, 8 months ago (2017-04-03 18:30:40 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2791963003/ by mbonadei@webrtc.org.

The reason for reverting is: Trying to re-land after solving some related
issues..

Powered by Google App Engine
This is Rietveld 408576698