Reland of write frame generator capturer to use TaskQueue instead of EventTimeWrapper

Reland of write frame generator capturer to use TaskQueue instead of EventTimeWrapper (patchset #1 id:1 of https://codereview.webrtc.org/2751063005/ )

Fix reduced frame-rate on Mac and Android.

Also enable huge full-stack test Largeroom_50thumbs on Windows.
 
BUG=webrtc:7301
Review-Url: https://codereview.webrtc.org/2760583003
Cr-Commit-Position: refs/heads/master@{#17288}
Committed: https://chromium.googlesource.com/external/webrtc/+/baded15381fc16c5a19cc4b567617a1d948a2f18

[ilnik, 2017-03-17 10:48:41]

Created Reland of write frame generator capturer to use TaskQueue instead of
EventTimeWrapper

[ilnik, 2017-03-17 10:49:05]

Description was changed from

==========
Reland of write frame generator capturer to use TaskQueue instead of
EventTimeWrapper (patchset #1 id:1 of https://codereview.webrtc.org/2751063005/
)

Reason for revert:
Reland with fixes to reduced frame-rate on Mac and Android.

Original issue's description:
> Revert of write frame generator capturer to use TaskQueue instead of
EventTimeWrapper (patchset #11 id:300001 of
https://codereview.webrtc.org/2750473002/ )
> 
> Reason for revert:
> Changes to frame-generator resulted in reduced fps on android and Mac on all
tests.
> 
> Original issue's description:
> > Reland of write frame generator capturer to use TaskQueue instead of
EventTimeWrapper (patchset #1 id:1 of https://codereview.webrtc.org/2748643002/
)
> > 
> > Reason for revert:
> > Reland with fixes to the failing perf tests.
> > 
> > Original issue's description:
> > > Revert of rewrite frame generator capturer to use TaskQueue instead of
EventTimeWrapper (patchset #2 id:90001 of
https://codereview.webrtc.org/2744003002/ )
> > > 
> > > Reason for revert:
> > > CallPerfTest.ReceivesCpuOveruseAndUnderuse perf test fails due to this CL.
It requires very accurate frame rate, which may not be so accurate now.
> > > 
> > > Original issue's description:
> > > > Reland of rewrite frame generator capturer to use TaskQueue instead of
EventTimeWrapper (patchset #1 id:1 of https://codereview.webrtc.org/2743993002/
)
> > > > 
> > > > And enable large full-stack test depending on that change (Reland of
https://codereview.webrtc.org/2741823003/)
> > > > TBR=stefan@webrtc.org,tommi@webrtc.org
> > > > BUG=webrtc:7301,webrtc:7325
> > > > 
> > > > Review-Url: https://codereview.webrtc.org/2744003002
> > > > Cr-Commit-Position: refs/heads/master@{#17196}
> > > > Committed:
https://chromium.googlesource.com/external/webrtc/+/8c0a5896d1cdc7bb81307c33f...
> > > 
> > > TBR=stefan@webrtc.org,tommi@webrtc.org,sprang@webrtc.org
> > > # Skipping CQ checks because original CL landed less than 1 days ago.
> > > NOPRESUBMIT=true
> > > NOTREECHECKS=true
> > > NOTRY=true
> > > BUG=webrtc:7301,webrtc:7325
> > > 
> > > Review-Url: https://codereview.webrtc.org/2748643002
> > > Cr-Commit-Position: refs/heads/master@{#17198}
> > > Committed:
https://chromium.googlesource.com/external/webrtc/+/382a72a0d321f19ac9cdc9bb3...
> > 
> > BUG=webrtc:7301,webrtc:7325
> > 
> > Review-Url: https://codereview.webrtc.org/2750473002
> > Cr-Commit-Position: refs/heads/master@{#17253}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/2549ad4fef419a055671c5be3...
> 
> TBR=sprang@webrtc.org,tommi@webrtc.org,stefan@webrtc.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=webrtc:7301,webrtc:7325
> 
> Review-Url: https://codereview.webrtc.org/2751063005
> Cr-Commit-Position: refs/heads/master@{#17276}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/2a420ce8c4dcb2c277707585e...

TBR=sprang@webrtc.org,tommi@webrtc.org,stefan@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=webrtc:7301,webrtc:7325
==========

to

==========
Reland of write frame generator capturer to use TaskQueue instead of
EventTimeWrapper (patchset #1 id:1 of https://codereview.webrtc.org/2751063005/
)

Reason for revert:
Reland with fixes to reduced frame-rate on Mac and Android.

BUG=webrtc:7301,webrtc:7325
==========

[ilnik, 2017-03-17 11:05:22]

Description was changed from

==========
Reland of write frame generator capturer to use TaskQueue instead of
EventTimeWrapper (patchset #1 id:1 of https://codereview.webrtc.org/2751063005/
)

Reason for revert:
Reland with fixes to reduced frame-rate on Mac and Android.

BUG=webrtc:7301,webrtc:7325
==========

to

==========
Reland of write frame generator capturer to use TaskQueue instead of
EventTimeWrapper (patchset #1 id:1 of https://codereview.webrtc.org/2751063005/
)

Fix reduced frame-rate on Mac and Android.

Also enable huge full-stack test Largeroom_50thumbs on Windows.
 
BUG=webrtc:7301,webrtc:7325
==========

[ilnik, 2017-03-17 11:05:38]

Description was changed from

==========
Reland of write frame generator capturer to use TaskQueue instead of
EventTimeWrapper (patchset #1 id:1 of https://codereview.webrtc.org/2751063005/
)

Fix reduced frame-rate on Mac and Android.

Also enable huge full-stack test Largeroom_50thumbs on Windows.
 
BUG=webrtc:7301,webrtc:7325
==========

to

==========
Reland of write frame generator capturer to use TaskQueue instead of
EventTimeWrapper (patchset #1 id:1 of https://codereview.webrtc.org/2751063005/
)

Fix reduced frame-rate on Mac and Android.

Also enable huge full-stack test Largeroom_50thumbs on Windows.
 
BUG=webrtc:7301
==========

[tommi, 2017-03-17 12:28:46]

lgtm % couple of minor comments.

https://codereview.webrtc.org/2760583003/diff/120001/webrtc/test/frame_genera...
File webrtc/test/frame_generator_capturer.cc (right):

https://codereview.webrtc.org/2760583003/diff/120001/webrtc/test/frame_genera...
webrtc/test/frame_generator_capturer.cc:40: int64_t delay_ms;
should all these delay calculations be inside the |if (repeat_interval_ms_ > 0)
{| condition?

https://codereview.webrtc.org/2760583003/diff/120001/webrtc/test/frame_genera...
webrtc/test/frame_generator_capturer.cc:114:
task_queue_("FrameGeneratorCapturerQueue",
fyi - we're probably going to clamp down the name length to 15 in the near
future, since that's a thread name limitation on linux. You could e.g. name this
"FrameGenCapQ" :)

[ilnik, 2017-03-17 12:34:38]

https://codereview.webrtc.org/2760583003/diff/120001/webrtc/test/frame_genera...
File webrtc/test/frame_generator_capturer.cc (right):

https://codereview.webrtc.org/2760583003/diff/120001/webrtc/test/frame_genera...
webrtc/test/frame_generator_capturer.cc:40: int64_t delay_ms;
On 2017/03/17 12:28:45, tommi (webrtc) wrote:
> should all these delay calculations be inside the |if (repeat_interval_ms_ >
0)
> {| condition?

Probably, yes. It doesn't affect anything really, but will be more clear that
way.

https://codereview.webrtc.org/2760583003/diff/120001/webrtc/test/frame_genera...
webrtc/test/frame_generator_capturer.cc:114:
task_queue_("FrameGeneratorCapturerQueue",
On 2017/03/17 12:28:46, tommi (webrtc) wrote:
> fyi - we're probably going to clamp down the name length to 15 in the near
> future, since that's a thread name limitation on linux. You could e.g. name
this
> "FrameGenCapQ" :)

Done.

[ilnik, 2017-03-17 12:36:08]

The CQ bit was checked by ilnik@webrtc.org

[ilnik, 2017-03-17 12:36:08]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2760583003/#ps140001 (title:
"Implement Tommi@ comments")

[commit-bot: I haz the power, 2017-03-17 12:36:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-17 12:55:25]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1489754168249980,
"parent_rev": "05e908b10bb32869c41dc96f980a2fbeae208f16", "commit_rev":
"baded15381fc16c5a19cc4b567617a1d948a2f18"}

[commit-bot: I haz the power, 2017-03-17 12:55:28]

Description was changed from

==========
Reland of write frame generator capturer to use TaskQueue instead of
EventTimeWrapper (patchset #1 id:1 of https://codereview.webrtc.org/2751063005/
)

Fix reduced frame-rate on Mac and Android.

Also enable huge full-stack test Largeroom_50thumbs on Windows.
 
BUG=webrtc:7301
==========

to

==========
Reland of write frame generator capturer to use TaskQueue instead of
EventTimeWrapper (patchset #1 id:1 of https://codereview.webrtc.org/2751063005/
)

Fix reduced frame-rate on Mac and Android.

Also enable huge full-stack test Largeroom_50thumbs on Windows.
 
BUG=webrtc:7301

Review-Url: https://codereview.webrtc.org/2760583003
Cr-Commit-Position: refs/heads/master@{#17288}
Committed:
https://chromium.googlesource.com/external/webrtc/+/baded15381fc16c5a19cc4b56...
==========

[commit-bot: I haz the power, 2017-03-17 12:55:29]

Committed patchset #3 (id:140001) as
https://chromium.googlesource.com/external/webrtc/+/baded15381fc16c5a19cc4b56...