Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 2748643002: Revert of rewrite frame generator capturer to use TaskQueue instead of EventTimeWrapper (Closed)

Created:
3 years, 9 months ago by ilnik
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kjellander_webrtc, sprang_webrtc, tommi, stefan-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of rewrite frame generator capturer to use TaskQueue instead of EventTimeWrapper (patchset #2 id:90001 of https://codereview.webrtc.org/2744003002/ ) Reason for revert: CallPerfTest.ReceivesCpuOveruseAndUnderuse perf test fails due to this CL. It requires very accurate frame rate, which may not be so accurate now. Original issue's description: > Reland of rewrite frame generator capturer to use TaskQueue instead of EventTimeWrapper (patchset #1 id:1 of https://codereview.webrtc.org/2743993002/ ) > > And enable large full-stack test depending on that change (Reland of https://codereview.webrtc.org/2741823003/) > TBR=stefan@webrtc.org,tommi@webrtc.org > BUG=webrtc:7301, webrtc:7325 > > Review-Url: https://codereview.webrtc.org/2744003002 > Cr-Commit-Position: refs/heads/master@{#17196} > Committed: https://chromium.googlesource.com/external/webrtc/+/8c0a5896d1cdc7bb81307c33fa4b3538d8160a0f TBR=stefan@webrtc.org,tommi@webrtc.org,sprang@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7301, webrtc:7325 Review-Url: https://codereview.webrtc.org/2748643002 Cr-Commit-Position: refs/heads/master@{#17198} Committed: https://chromium.googlesource.com/external/webrtc/+/382a72a0d321f19ac9cdc9bb30712cefe2639f88

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -53 lines) Patch
M webrtc/call/call_perf_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/frame_generator_capturer.h View 3 chunks +5 lines, -8 lines 0 comments Download
M webrtc/test/frame_generator_capturer.cc View 5 chunks +18 lines, -42 lines 0 comments Download
M webrtc/video/full_stack_tests.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
ilnik
Created Revert of rewrite frame generator capturer to use TaskQueue instead of EventTimeWrapper
3 years, 9 months ago (2017-03-13 08:53:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2748643002/1
3 years, 9 months ago (2017-03-13 08:54:08 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/382a72a0d321f19ac9cdc9bb30712cefe2639f88
3 years, 9 months ago (2017-03-13 08:54:16 UTC) #6
ilnik
3 years, 9 months ago (2017-03-13 09:19:22 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2750473002/ by ilnik@webrtc.org.

The reason for reverting is: Reland with fixes to the failing perf tests..

Powered by Google App Engine
This is Rietveld 408576698