Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issue 2744003002: Reland of rewrite frame generator capturer to use TaskQueue instead of EventTimeWrapper (Closed)

Created:
3 years, 9 months ago by ilnik
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kjellander_webrtc, sprang_webrtc, tommi, stefan-webrtc
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of rewrite frame generator capturer to use TaskQueue instead of EventTimeWrapper (patchset #1 id:1 of https://codereview.webrtc.org/2743993002/ ) And enable large full-stack test depending on that change (Reland of https://codereview.webrtc.org/2741823003/) TBR=stefan@webrtc.org,tommi@webrtc.org BUG=webrtc:7301, webrtc:7325 Review-Url: https://codereview.webrtc.org/2744003002 Cr-Commit-Position: refs/heads/master@{#17196} Committed: https://chromium.googlesource.com/external/webrtc/+/8c0a5896d1cdc7bb81307c33fa4b3538d8160a0f

Patch Set 1 : Original reverted CL #

Patch Set 2 : Fix race condition in FrameGeneratorCapturer and enable huge largeroom FullStack test on windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -26 lines) Patch
M webrtc/call/call_perf_tests.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/frame_generator_capturer.h View 1 3 chunks +8 lines, -5 lines 0 comments Download
M webrtc/test/frame_generator_capturer.cc View 1 6 chunks +42 lines, -18 lines 0 comments Download
M webrtc/video/full_stack_tests.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
ilnik
Created Reland of write frame generator capturer to use TaskQueue instead of EventTimeWrapper
3 years, 9 months ago (2017-03-10 17:53:53 UTC) #1
ilnik
3 years, 9 months ago (2017-03-10 21:05:47 UTC) #8
tommi
lgtm
3 years, 9 months ago (2017-03-10 23:21:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2744003002/90001
3 years, 9 months ago (2017-03-13 07:43:38 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:90001) as https://chromium.googlesource.com/external/webrtc/+/8c0a5896d1cdc7bb81307c33fa4b3538d8160a0f
3 years, 9 months ago (2017-03-13 08:03:11 UTC) #16
ilnik
3 years, 9 months ago (2017-03-13 08:53:57 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:90001) has been created in
https://codereview.webrtc.org/2748643002/ by ilnik@webrtc.org.

The reason for reverting is: CallPerfTest.ReceivesCpuOveruseAndUnderuse perf
test fails due to this CL. It requires very accurate frame rate, which may not
be so accurate now..

Powered by Google App Engine
This is Rietveld 408576698