Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2743993002: Revert of rewrite frame generator capturer to use TaskQueue instead of EventTimeWrapper (Closed)

Created:
3 years, 9 months ago by ilnik
Modified:
3 years, 9 months ago
Reviewers:
tommi, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, kjellander_webrtc, sprang_webrtc, tommi
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of rewrite frame generator capturer to use TaskQueue instead of EventTimeWrapper (patchset #2 id:70001 of https://codereview.webrtc.org/2745583006/ ) Reason for revert: Causes problems with TSAN: https://bugs.chromium.org/p/webrtc/issues/detail?id=7325 Original issue's description: > Reland of rewrite frame generator capturer to use TaskQueue instead of EventTimeWrapper. > > Fix CallPerfTest.ReceivesCpuOveruseAndUnderuse to not fail on Android with new FrameGeneratorCapturer. > > BUG=webrtc:7301 > > Review-Url: https://codereview.webrtc.org/2745583006 > Cr-Commit-Position: refs/heads/master@{#17168} > Committed: https://chromium.googlesource.com/external/webrtc/+/b00742508ae9320ce86ad2963c18443a83976999 TBR=stefan@webrtc.org,tommi@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:7301 Review-Url: https://codereview.webrtc.org/2743993002 Cr-Commit-Position: refs/heads/master@{#17173} Committed: https://chromium.googlesource.com/external/webrtc/+/1cb27c221e2805a86ea3d23d233ca467564881ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -48 lines) Patch
M webrtc/call/call_perf_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/test/frame_generator_capturer.h View 4 chunks +5 lines, -6 lines 0 comments Download
M webrtc/test/frame_generator_capturer.cc View 6 chunks +17 lines, -41 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
ilnik
Created Revert of rewrite frame generator capturer to use TaskQueue instead of EventTimeWrapper
3 years, 9 months ago (2017-03-10 17:49:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2743993002/1
3 years, 9 months ago (2017-03-10 17:49:39 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/1cb27c221e2805a86ea3d23d233ca467564881ac
3 years, 9 months ago (2017-03-10 17:49:45 UTC) #6
ilnik
3 years, 9 months ago (2017-03-10 17:53:53 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2744003002/ by ilnik@webrtc.org.

The reason for reverting is: Reland fixed version.

Powered by Google App Engine
This is Rietveld 408576698