Revert of write frame generator capturer to use TaskQueue instead of EventTimeWrapper

Revert of write frame generator capturer to use TaskQueue instead of EventTimeWrapper (patchset #11 id:300001 of https://codereview.webrtc.org/2750473002/ )

Reason for revert:
Changes to frame-generator resulted in reduced fps on android and Mac on all tests.

Original issue's description:
> Reland of write frame generator capturer to use TaskQueue instead of EventTimeWrapper (patchset #1 id:1 of https://codereview.webrtc.org/2748643002/ )
> 
> Reason for revert:
> Reland with fixes to the failing perf tests.
> 
> Original issue's description:
> > Revert of rewrite frame generator capturer to use TaskQueue instead of EventTimeWrapper (patchset #2 id:90001 of https://codereview.webrtc.org/2744003002/ )
> > 
> > Reason for revert:
> > CallPerfTest.ReceivesCpuOveruseAndUnderuse perf test fails due to this CL. It requires very accurate frame rate, which may not be so accurate now.
> > 
> > Original issue's description:
> > > Reland of rewrite frame generator capturer to use TaskQueue instead of EventTimeWrapper (patchset #1 id:1 of https://codereview.webrtc.org/2743993002/ )
> > > 
> > > And enable large full-stack test depending on that change (Reland of https://codereview.webrtc.org/2741823003/)
> > > TBR=stefan@webrtc.org,tommi@webrtc.org
> > > BUG=webrtc:7301, webrtc:7325
> > > 
> > > Review-Url: https://codereview.webrtc.org/2744003002
> > > Cr-Commit-Position: refs/heads/master@{#17196}
> > > Committed: https://chromium.googlesource.com/external/webrtc/+/8c0a5896d1cdc7bb81307c33fa4b3538d8160a0f
> > 
> > TBR=stefan@webrtc.org,tommi@webrtc.org,sprang@webrtc.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=webrtc:7301, webrtc:7325
> > 
> > Review-Url: https://codereview.webrtc.org/2748643002
> > Cr-Commit-Position: refs/heads/master@{#17198}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/382a72a0d321f19ac9cdc9bb30712cefe2639f88
> 
> BUG=webrtc:7301, webrtc:7325
> 
> Review-Url: https://codereview.webrtc.org/2750473002
> Cr-Commit-Position: refs/heads/master@{#17253}
> Committed: https://chromium.googlesource.com/external/webrtc/+/2549ad4fef419a055671c5be39fcfa27ba573c3b

TBR=sprang@webrtc.org,tommi@webrtc.org,stefan@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:7301, webrtc:7325
Review-Url: https://codereview.webrtc.org/2751063005
Cr-Commit-Position: refs/heads/master@{#17276}
Committed: https://chromium.googlesource.com/external/webrtc/+/2a420ce8c4dcb2c277707585e00d56ca306ed38c

[ilnik, 2017-03-16 15:52:20]

The CQ bit was checked by ilnik@webrtc.org

[ilnik, 2017-03-16 15:52:20]

Created Revert of write frame generator capturer to use TaskQueue instead of
EventTimeWrapper

[commit-bot: I haz the power, 2017-03-16 15:52:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[tommi, 2017-03-16 16:41:04]

How big was the regression?  I thought I saw some improvements on the perf bots
- maybe those were simply because we were dealing with fewer frames?

[commit-bot: I haz the power, 2017-03-16 16:43:45]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489679540595980, "parent_rev":
"c90d3a73955c399751e97df67dcaf78136782a86", "commit_rev":
"2a420ce8c4dcb2c277707585e00d56ca306ed38c"}

[commit-bot: I haz the power, 2017-03-16 16:43:50]

Description was changed from

==========
Revert of write frame generator capturer to use TaskQueue instead of
EventTimeWrapper (patchset #11 id:300001 of
https://codereview.webrtc.org/2750473002/ )

Reason for revert:
Changes to frame-generator resulted in reduced fps on android and Mac on all
tests.

Original issue's description:
> Reland of write frame generator capturer to use TaskQueue instead of
EventTimeWrapper (patchset #1 id:1 of https://codereview.webrtc.org/2748643002/
)
> 
> Reason for revert:
> Reland with fixes to the failing perf tests.
> 
> Original issue's description:
> > Revert of rewrite frame generator capturer to use TaskQueue instead of
EventTimeWrapper (patchset #2 id:90001 of
https://codereview.webrtc.org/2744003002/ )
> > 
> > Reason for revert:
> > CallPerfTest.ReceivesCpuOveruseAndUnderuse perf test fails due to this CL.
It requires very accurate frame rate, which may not be so accurate now.
> > 
> > Original issue's description:
> > > Reland of rewrite frame generator capturer to use TaskQueue instead of
EventTimeWrapper (patchset #1 id:1 of https://codereview.webrtc.org/2743993002/
)
> > > 
> > > And enable large full-stack test depending on that change (Reland of
https://codereview.webrtc.org/2741823003/)
> > > TBR=stefan@webrtc.org,tommi@webrtc.org
> > > BUG=webrtc:7301,webrtc:7325
> > > 
> > > Review-Url: https://codereview.webrtc.org/2744003002
> > > Cr-Commit-Position: refs/heads/master@{#17196}
> > > Committed:
https://chromium.googlesource.com/external/webrtc/+/8c0a5896d1cdc7bb81307c33f...
> > 
> > TBR=stefan@webrtc.org,tommi@webrtc.org,sprang@webrtc.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=webrtc:7301,webrtc:7325
> > 
> > Review-Url: https://codereview.webrtc.org/2748643002
> > Cr-Commit-Position: refs/heads/master@{#17198}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/382a72a0d321f19ac9cdc9bb3...
> 
> BUG=webrtc:7301,webrtc:7325
> 
> Review-Url: https://codereview.webrtc.org/2750473002
> Cr-Commit-Position: refs/heads/master@{#17253}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/2549ad4fef419a055671c5be3...

TBR=sprang@webrtc.org,tommi@webrtc.org,stefan@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:7301,webrtc:7325
==========

to

==========
Revert of write frame generator capturer to use TaskQueue instead of
EventTimeWrapper (patchset #11 id:300001 of
https://codereview.webrtc.org/2750473002/ )

Reason for revert:
Changes to frame-generator resulted in reduced fps on android and Mac on all
tests.

Original issue's description:
> Reland of write frame generator capturer to use TaskQueue instead of
EventTimeWrapper (patchset #1 id:1 of https://codereview.webrtc.org/2748643002/
)
> 
> Reason for revert:
> Reland with fixes to the failing perf tests.
> 
> Original issue's description:
> > Revert of rewrite frame generator capturer to use TaskQueue instead of
EventTimeWrapper (patchset #2 id:90001 of
https://codereview.webrtc.org/2744003002/ )
> > 
> > Reason for revert:
> > CallPerfTest.ReceivesCpuOveruseAndUnderuse perf test fails due to this CL.
It requires very accurate frame rate, which may not be so accurate now.
> > 
> > Original issue's description:
> > > Reland of rewrite frame generator capturer to use TaskQueue instead of
EventTimeWrapper (patchset #1 id:1 of https://codereview.webrtc.org/2743993002/
)
> > > 
> > > And enable large full-stack test depending on that change (Reland of
https://codereview.webrtc.org/2741823003/)
> > > TBR=stefan@webrtc.org,tommi@webrtc.org
> > > BUG=webrtc:7301,webrtc:7325
> > > 
> > > Review-Url: https://codereview.webrtc.org/2744003002
> > > Cr-Commit-Position: refs/heads/master@{#17196}
> > > Committed:
https://chromium.googlesource.com/external/webrtc/+/8c0a5896d1cdc7bb81307c33f...
> > 
> > TBR=stefan@webrtc.org,tommi@webrtc.org,sprang@webrtc.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=webrtc:7301,webrtc:7325
> > 
> > Review-Url: https://codereview.webrtc.org/2748643002
> > Cr-Commit-Position: refs/heads/master@{#17198}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/382a72a0d321f19ac9cdc9bb3...
> 
> BUG=webrtc:7301,webrtc:7325
> 
> Review-Url: https://codereview.webrtc.org/2750473002
> Cr-Commit-Position: refs/heads/master@{#17253}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/2549ad4fef419a055671c5be3...

TBR=sprang@webrtc.org,tommi@webrtc.org,stefan@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:7301,webrtc:7325

Review-Url: https://codereview.webrtc.org/2751063005
Cr-Commit-Position: refs/heads/master@{#17276}
Committed:
https://chromium.googlesource.com/external/webrtc/+/2a420ce8c4dcb2c277707585e...
==========

[commit-bot: I haz the power, 2017-03-16 16:43:51]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/2a420ce8c4dcb2c277707585e...

[ilnik, 2017-03-16 19:18:02]

On 2017/03/16 16:41:04, tommi (webrtc) wrote:
> How big was the regression?  I thought I saw some improvements on the perf
bots
> - maybe those were simply because we were dealing with fewer frames?

It was not big at all. 10-20% of FPS reduction. Like from 50fps to 40 and from
30 to 26. That gave rise to all kind of improvements. I have one idea why it's
happening, will investigate tomorrow. Looks like delay between end of all task
to the start of the next is set to 1000/fps, but that should be time between
starts of the tasks. I try to reschedule the task at the beginning of itself,
but that is somehow not processed until the tasks completes. Easy to make a
workaround for that, but proper fix will require some more investigation.

[ilnik, 2017-03-17 10:48:41]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2760583003/ by ilnik@webrtc.org.

The reason for reverting is: Reland with fixes to reduced frame-rate on Mac and
Android..