Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1109)

Issue 2750283003: Make ModuleRtpRtcpImpl member variables private. (Closed)

Created:
3 years, 9 months ago by nisse-webrtc
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Make ModuleRtpRtcpImpl member variables private. This is a follow-up to https://codereview.webrtc.org/2747743002. BUG=webrtc:7135 Review-Url: https://codereview.webrtc.org/2750283003 Cr-Commit-Position: refs/heads/master@{#17271} Committed: https://chromium.googlesource.com/external/webrtc/+/150708e061b88c1e7c02aba13d4196a4913f99cc

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix ordering in private section. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h View 1 2 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
nisse-webrtc
PTAL. I hope this is landable as soon as danil's application update is landed.
3 years, 9 months ago (2017-03-16 08:46:07 UTC) #2
stefan-webrtc
lgtm
3 years, 9 months ago (2017-03-16 08:47:55 UTC) #3
danilchap
lgtm https://codereview.webrtc.org/2750283003/diff/1/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h File webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h (right): https://codereview.webrtc.org/2750283003/diff/1/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h#newcode322 webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h:322: RTPSender rtp_sender_; put members in private section below ...
3 years, 9 months ago (2017-03-16 10:16:27 UTC) #4
nisse-webrtc
https://codereview.webrtc.org/2750283003/diff/1/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h File webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h (right): https://codereview.webrtc.org/2750283003/diff/1/webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h#newcode322 webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h:322: RTPSender rtp_sender_; On 2017/03/16 10:16:26, danilchap wrote: > put ...
3 years, 9 months ago (2017-03-16 10:20:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2750283003/20001
3 years, 9 months ago (2017-03-16 12:00:57 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-03-16 12:02:57 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/150708e061b88c1e7c02aba13...

Powered by Google App Engine
This is Rietveld 408576698