Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2747743002:
Add accessor functions for protected member variables of ModuleRtpRtcpImpl. (Closed)
|
Created:
3 years, 9 months ago by nisse-webrtc Modified:
3 years, 9 months ago Reviewers:
danilchap CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhuangzesen_agora.io, danilchap, stefan-webrtc, mflodman Target Ref:
refs/heads/master Project:
webrtc Visibility:
Public. |
DescriptionAdd accessor functions for protected member variables of ModuleRtpRtcpImpl.
BUG=webrtc:7135
Review-Url: https://codereview.webrtc.org/2747743002
Cr-Commit-Position: refs/heads/master@{#17220}
Committed: https://chromium.googlesource.com/external/webrtc/+/a33c62ee65e86d01beba9e74bc12644e2e1e0444
Patch Set 1 #
Total comments: 2
Patch Set 2 : Made the clock_ member and clock() accessor const. #Messages
Total messages: 18 (13 generated)
The CQ bit was checked by nisse@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
nisse@webrtc.org changed reviewers: + danilchap@webrtc.org
PTAL.
lgtm https://codereview.webrtc.org/2747743002/diff/1/webrtc/modules/rtp_rtcp/sourc... File webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h (right): https://codereview.webrtc.org/2747743002/diff/1/webrtc/modules/rtp_rtcp/sourc... webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h:324: Clock* clock() { return clock_; } since Clock interface has only const functions, it might be better to make this accessor const: const Clock* clock() const { return clock_; }
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by nisse@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
https://codereview.webrtc.org/2747743002/diff/1/webrtc/modules/rtp_rtcp/sourc... File webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h (right): https://codereview.webrtc.org/2747743002/diff/1/webrtc/modules/rtp_rtcp/sourc... webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h:324: Clock* clock() { return clock_; } On 2017/03/13 12:57:19, danilchap wrote: > since Clock interface has only const functions, it might be better to make this > accessor const: > const Clock* clock() const { return clock_; } Done. Made the |clock_| member const const as well.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by nisse@webrtc.org
The patchset sent to the CQ was uploaded after l-g-t-m from danilchap@webrtc.org Link to the patchset: https://codereview.webrtc.org/2747743002/#ps20001 (title: "Made the clock_ member and clock() accessor const.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1489477642768810,
"parent_rev": "bb2f1c81f2141aa5ded273a123a886f49cbb942d", "commit_rev":
"a33c62ee65e86d01beba9e74bc12644e2e1e0444"}
Message was sent while issue was closed.
Description was changed from ========== Add accessor functions for protected member variables of ModuleRtpRtcpImpl. BUG=webrtc:7135 ========== to ========== Add accessor functions for protected member variables of ModuleRtpRtcpImpl. BUG=webrtc:7135 Review-Url: https://codereview.webrtc.org/2747743002 Cr-Commit-Position: refs/heads/master@{#17220} Committed: https://chromium.googlesource.com/external/webrtc/+/a33c62ee65e86d01beba9e74b... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/webrtc/+/a33c62ee65e86d01beba9e74b... |
