Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1025)

Side by Side Diff: webrtc/modules/rtp_rtcp/source/rtp_rtcp_impl.h

Issue 2750283003: Make ModuleRtpRtcpImpl member variables private. (Closed)
Patch Set: Fix ordering in private section. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 300 matching lines...) Expand 10 before | Expand all | Expand 10 after
311 const RTPSender* rtp_sender() const { return &rtp_sender_; } 311 const RTPSender* rtp_sender() const { return &rtp_sender_; }
312 312
313 RTCPSender* rtcp_sender() { return &rtcp_sender_; } 313 RTCPSender* rtcp_sender() { return &rtcp_sender_; }
314 const RTCPSender* rtcp_sender() const { return &rtcp_sender_; } 314 const RTCPSender* rtcp_sender() const { return &rtcp_sender_; }
315 315
316 RTCPReceiver* rtcp_receiver() { return &rtcp_receiver_; } 316 RTCPReceiver* rtcp_receiver() { return &rtcp_receiver_; }
317 const RTCPReceiver* rtcp_receiver() const { return &rtcp_receiver_; } 317 const RTCPReceiver* rtcp_receiver() const { return &rtcp_receiver_; }
318 318
319 const Clock* clock() const { return clock_; } 319 const Clock* clock() const { return clock_; }
320 320
321 // TODO(nisse): Demote all member variables to private, as soon as
322 // downstream code is updated to use the above accessor methods.
323 RTPSender rtp_sender_;
324
325 RTCPSender rtcp_sender_;
326 RTCPReceiver rtcp_receiver_;
327
328 const Clock* const clock_;
329
330 private: 321 private:
331 FRIEND_TEST_ALL_PREFIXES(RtpRtcpImplTest, Rtt); 322 FRIEND_TEST_ALL_PREFIXES(RtpRtcpImplTest, Rtt);
332 FRIEND_TEST_ALL_PREFIXES(RtpRtcpImplTest, RttForReceiverOnly); 323 FRIEND_TEST_ALL_PREFIXES(RtpRtcpImplTest, RttForReceiverOnly);
333 int64_t RtcpReportInterval(); 324 int64_t RtcpReportInterval();
334 void SetRtcpReceiverSsrcs(uint32_t main_ssrc); 325 void SetRtcpReceiverSsrcs(uint32_t main_ssrc);
335 326
336 void set_rtt_ms(int64_t rtt_ms); 327 void set_rtt_ms(int64_t rtt_ms);
337 int64_t rtt_ms() const; 328 int64_t rtt_ms() const;
338 329
339 bool TimeToSendFullNackList(int64_t now) const; 330 bool TimeToSendFullNackList(int64_t now) const;
340 331
332 RTPSender rtp_sender_;
333 RTCPSender rtcp_sender_;
334 RTCPReceiver rtcp_receiver_;
335
336 const Clock* const clock_;
337
341 const bool audio_; 338 const bool audio_;
342 int64_t last_process_time_; 339 int64_t last_process_time_;
343 int64_t last_bitrate_process_time_; 340 int64_t last_bitrate_process_time_;
344 int64_t last_rtt_process_time_; 341 int64_t last_rtt_process_time_;
345 uint16_t packet_overhead_; 342 uint16_t packet_overhead_;
346 343
347 // Send side 344 // Send side
348 int64_t nack_last_time_sent_full_; 345 int64_t nack_last_time_sent_full_;
349 uint32_t nack_last_time_sent_full_prev_; 346 uint32_t nack_last_time_sent_full_prev_;
350 uint16_t nack_last_seq_number_sent_; 347 uint16_t nack_last_seq_number_sent_;
351 348
352 KeyFrameRequestMethod key_frame_req_method_; 349 KeyFrameRequestMethod key_frame_req_method_;
353 350
354 RemoteBitrateEstimator* remote_bitrate_; 351 RemoteBitrateEstimator* remote_bitrate_;
355 352
356 RtcpRttStats* rtt_stats_; 353 RtcpRttStats* rtt_stats_;
357 354
358 PacketLossStats send_loss_stats_; 355 PacketLossStats send_loss_stats_;
359 PacketLossStats receive_loss_stats_; 356 PacketLossStats receive_loss_stats_;
360 357
361 // The processed RTT from RtcpRttStats. 358 // The processed RTT from RtcpRttStats.
362 rtc::CriticalSection critical_section_rtt_; 359 rtc::CriticalSection critical_section_rtt_;
363 int64_t rtt_ms_; 360 int64_t rtt_ms_;
364 }; 361 };
365 362
366 } // namespace webrtc 363 } // namespace webrtc
367 364
368 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTP_RTCP_IMPL_H_ 365 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTP_RTCP_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698