Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 /* | 1 /* |
| 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. | 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. |
| 3 * | 3 * |
| 4 * Use of this source code is governed by a BSD-style license | 4 * Use of this source code is governed by a BSD-style license |
| 5 * that can be found in the LICENSE file in the root of the source | 5 * that can be found in the LICENSE file in the root of the source |
| 6 * tree. An additional intellectual property rights grant can be found | 6 * tree. An additional intellectual property rights grant can be found |
| 7 * in the file PATENTS. All contributing project authors may | 7 * in the file PATENTS. All contributing project authors may |
| 8 * be found in the AUTHORS file in the root of the source tree. | 8 * be found in the AUTHORS file in the root of the source tree. |
| 9 */ | 9 */ |
| 10 | 10 |
| (...skipping 300 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 311 const RTPSender* rtp_sender() const { return &rtp_sender_; } | 311 const RTPSender* rtp_sender() const { return &rtp_sender_; } |
| 312 | 312 |
| 313 RTCPSender* rtcp_sender() { return &rtcp_sender_; } | 313 RTCPSender* rtcp_sender() { return &rtcp_sender_; } |
| 314 const RTCPSender* rtcp_sender() const { return &rtcp_sender_; } | 314 const RTCPSender* rtcp_sender() const { return &rtcp_sender_; } |
| 315 | 315 |
| 316 RTCPReceiver* rtcp_receiver() { return &rtcp_receiver_; } | 316 RTCPReceiver* rtcp_receiver() { return &rtcp_receiver_; } |
| 317 const RTCPReceiver* rtcp_receiver() const { return &rtcp_receiver_; } | 317 const RTCPReceiver* rtcp_receiver() const { return &rtcp_receiver_; } |
| 318 | 318 |
| 319 const Clock* clock() const { return clock_; } | 319 const Clock* clock() const { return clock_; } |
| 320 | 320 |
| 321 // TODO(nisse): Demote all member variables to private, as soon as | 321 private: |
| 322 // downstream code is updated to use the above accessor methods. | |
| 323 RTPSender rtp_sender_; | 322 RTPSender rtp_sender_; |
|
danilchap
2017/03/16 10:16:26
put members in private section below functions.
i.
nisse-webrtc
2017/03/16 10:20:50
Done.
| |
| 324 | |
| 325 RTCPSender rtcp_sender_; | 323 RTCPSender rtcp_sender_; |
| 326 RTCPReceiver rtcp_receiver_; | 324 RTCPReceiver rtcp_receiver_; |
| 327 | 325 |
| 328 const Clock* const clock_; | 326 const Clock* const clock_; |
| 329 | 327 |
| 330 private: | |
| 331 FRIEND_TEST_ALL_PREFIXES(RtpRtcpImplTest, Rtt); | 328 FRIEND_TEST_ALL_PREFIXES(RtpRtcpImplTest, Rtt); |
| 332 FRIEND_TEST_ALL_PREFIXES(RtpRtcpImplTest, RttForReceiverOnly); | 329 FRIEND_TEST_ALL_PREFIXES(RtpRtcpImplTest, RttForReceiverOnly); |
| 333 int64_t RtcpReportInterval(); | 330 int64_t RtcpReportInterval(); |
| 334 void SetRtcpReceiverSsrcs(uint32_t main_ssrc); | 331 void SetRtcpReceiverSsrcs(uint32_t main_ssrc); |
| 335 | 332 |
| 336 void set_rtt_ms(int64_t rtt_ms); | 333 void set_rtt_ms(int64_t rtt_ms); |
| 337 int64_t rtt_ms() const; | 334 int64_t rtt_ms() const; |
| 338 | 335 |
| 339 bool TimeToSendFullNackList(int64_t now) const; | 336 bool TimeToSendFullNackList(int64_t now) const; |
| 340 | 337 |
| (...skipping 18 matching lines...) Expand all Loading... | |
| 359 PacketLossStats receive_loss_stats_; | 356 PacketLossStats receive_loss_stats_; |
| 360 | 357 |
| 361 // The processed RTT from RtcpRttStats. | 358 // The processed RTT from RtcpRttStats. |
| 362 rtc::CriticalSection critical_section_rtt_; | 359 rtc::CriticalSection critical_section_rtt_; |
| 363 int64_t rtt_ms_; | 360 int64_t rtt_ms_; |
| 364 }; | 361 }; |
| 365 | 362 |
| 366 } // namespace webrtc | 363 } // namespace webrtc |
| 367 | 364 |
| 368 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTP_RTCP_IMPL_H_ | 365 #endif // WEBRTC_MODULES_RTP_RTCP_SOURCE_RTP_RTCP_IMPL_H_ |
| OLD | NEW |