Drop VP8 frames in case of duplicates in RtpFrameReferenceFinder.

Drop VP8 frames in case of duplicates in RtpFrameReferenceFinder.

BUG=webrtc:5514, webrtc:7308
Review-Url: https://codereview.webrtc.org/2734453002
Cr-Commit-Position: refs/heads/master@{#17090}
Committed: https://chromium.googlesource.com/external/webrtc/+/57f19cc0cdd295ec409b0a05b67c0e993419f181

[philipel, 2017-03-03 14:12:23]

philipel@webrtc.org changed reviewers:
+ sprang@webrtc.org

[philipel, 2017-03-03 14:12:33]

The CQ bit was checked by philipel@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-03 14:12:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-03 15:19:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 15:19:33]

Dry run: This issue passed the CQ dry run.

[philipel, 2017-03-06 09:47:30]

philipel@webrtc.org changed reviewers:
+ stefan@webrtc.org

[sprang_webrtc, 2017-03-06 09:52:52]

Don't know this code at all, I'll let stefan be the main reviewer

https://codereview.webrtc.org/2734453002/diff/1/webrtc/modules/video_coding/r...
File webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc (right):

https://codereview.webrtc.org/2734453002/diff/1/webrtc/modules/video_coding/r...
webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc:439:
InsertVp8(sn + 3, sn + 3, false, pid + 3, 1, 1);
Should you add something new after this one to make sure it doesn't get stuck in
a weird state?

[stefan-webrtc, 2017-03-06 15:49:26]

https://codereview.webrtc.org/2734453002/diff/1/webrtc/modules/video_coding/r...
File webrtc/modules/video_coding/rtp_frame_reference_finder.cc (right):

https://codereview.webrtc.org/2734453002/diff/1/webrtc/modules/video_coding/r...
webrtc/modules/video_coding/rtp_frame_reference_finder.cc:344: }
Seems like we can get a lot of these logs on a network with some packet loss,
especially if we have FEC. Should we throttle the logs a bit, or do you think it
isn't an issue?

[philipel, 2017-03-07 10:47:12]

https://codereview.webrtc.org/2734453002/diff/1/webrtc/modules/video_coding/r...
File webrtc/modules/video_coding/rtp_frame_reference_finder.cc (right):

https://codereview.webrtc.org/2734453002/diff/1/webrtc/modules/video_coding/r...
webrtc/modules/video_coding/rtp_frame_reference_finder.cc:344: }
On 2017/03/06 15:49:26, stefan-webrtc wrote:
> Seems like we can get a lot of these logs on a network with some packet loss,
> especially if we have FEC. Should we throttle the logs a bit, or do you think
it
> isn't an issue?

I don't think it will be an issue since we need to decode a frame and then
receive it again for it to happen.

https://codereview.webrtc.org/2734453002/diff/1/webrtc/modules/video_coding/r...
File webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc (right):

https://codereview.webrtc.org/2734453002/diff/1/webrtc/modules/video_coding/r...
webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc:439:
InsertVp8(sn + 3, sn + 3, false, pid + 3, 1, 1);
On 2017/03/06 09:52:52, språng wrote:
> Should you add something new after this one to make sure it doesn't get stuck
in
> a weird state?

Done.

[stefan-webrtc, 2017-03-07 10:56:44]

lgtm

[philipel, 2017-03-07 11:33:40]

The CQ bit was checked by philipel@webrtc.org

[commit-bot: I haz the power, 2017-03-07 11:33:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-07 11:54:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488886420621680,
"parent_rev": "2150ac2a436b7a9aabc284bd62d16e79ebc633bf", "commit_rev":
"57f19cc0cdd295ec409b0a05b67c0e993419f181"}

[commit-bot: I haz the power, 2017-03-07 11:54:08]

Description was changed from

==========
Drop VP8 frames in case of duplicates in RtpFrameReferenceFinder.

BUG=webrtc:5514
==========

to

==========
Drop VP8 frames in case of duplicates in RtpFrameReferenceFinder.

BUG=webrtc:5514

Review-Url: https://codereview.webrtc.org/2734453002
Cr-Commit-Position: refs/heads/master@{#17090}
Committed:
https://chromium.googlesource.com/external/webrtc/+/57f19cc0cdd295ec409b0a05b...
==========

[commit-bot: I haz the power, 2017-03-07 11:54:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/57f19cc0cdd295ec409b0a05b...

[philipel, 2017-03-08 10:33:12]

Description was changed from

==========
Drop VP8 frames in case of duplicates in RtpFrameReferenceFinder.

BUG=webrtc:5514

Review-Url: https://codereview.webrtc.org/2734453002
Cr-Commit-Position: refs/heads/master@{#17090}
Committed:
https://chromium.googlesource.com/external/webrtc/+/57f19cc0cdd295ec409b0a05b...
==========

to

==========
Drop VP8 frames in case of duplicates in RtpFrameReferenceFinder.

BUG=webrtc:5514, webrtc:7308

Review-Url: https://codereview.webrtc.org/2734453002
Cr-Commit-Position: refs/heads/master@{#17090}
Committed:
https://chromium.googlesource.com/external/webrtc/+/57f19cc0cdd295ec409b0a05b...
==========