Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: webrtc/modules/video_coding/rtp_frame_reference_finder.cc

Issue 2734453002: Drop VP8 frames in case of duplicates in RtpFrameReferenceFinder. (Closed)
Patch Set: Feedback. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/video_coding/rtp_frame_reference_finder.cc
diff --git a/webrtc/modules/video_coding/rtp_frame_reference_finder.cc b/webrtc/modules/video_coding/rtp_frame_reference_finder.cc
index e49a81d7588227f58f113ac886033f360a08a194..5926c524bea672302d3dff22d661472570abf38d 100644
--- a/webrtc/modules/video_coding/rtp_frame_reference_finder.cc
+++ b/webrtc/modules/video_coding/rtp_frame_reference_finder.cc
@@ -334,8 +334,15 @@ void RtpFrameReferenceFinder::ManageFrameVp8(
return;
}
- RTC_DCHECK((AheadOf<uint16_t, kPicIdLength>(frame->picture_id,
- layer_info_it->second[layer])));
+ if (!(AheadOf<uint16_t, kPicIdLength>(frame->picture_id,
+ layer_info_it->second[layer]))) {
+ LOG(LS_WARNING) << "Frame with picture id " << frame->picture_id
+ << " and packet range [" << frame->first_seq_num() << ", "
+ << frame->last_seq_num() << "] already received, "
+ << " dropping frame.";
+ return;
+ }
+
++frame->num_references;
frame->references[layer] = layer_info_it->second[layer];
}
« no previous file with comments | « no previous file | webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698