Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Unified Diff: webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc

Issue 2734453002: Drop VP8 frames in case of duplicates in RtpFrameReferenceFinder. (Closed)
Patch Set: Feedback. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/video_coding/rtp_frame_reference_finder.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc
diff --git a/webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc b/webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc
index 5fa88802a6bb03e33d964d3c097a01b559d9d343..cc361ec25863fdacb8c33c5fccecf8880031f697 100644
--- a/webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc
+++ b/webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc
@@ -428,6 +428,27 @@ TEST_F(TestRtpFrameReferenceFinder, Vp8TemporalLayers_0) {
CheckReferencesVp8(pid + 3, pid + 2);
}
+TEST_F(TestRtpFrameReferenceFinder, Vp8DuplicateTl1Frames) {
+ uint16_t pid = Rand();
+ uint16_t sn = Rand();
+
+ InsertVp8(sn, sn, true, pid, 0, 0);
+ InsertVp8(sn + 1, sn + 1, false, pid + 1, 1, 0, true);
+ InsertVp8(sn + 2, sn + 2, false, pid + 2, 0, 1);
+ InsertVp8(sn + 3, sn + 3, false, pid + 3, 1, 1);
+ InsertVp8(sn + 3, sn + 3, false, pid + 3, 1, 1);
+ InsertVp8(sn + 4, sn + 4, false, pid + 4, 0, 2);
+ InsertVp8(sn + 5, sn + 5, false, pid + 5, 1, 2);
+
+ ASSERT_EQ(6UL, frames_from_callback_.size());
+ CheckReferencesVp8(pid);
+ CheckReferencesVp8(pid + 1, pid);
+ CheckReferencesVp8(pid + 2, pid);
+ CheckReferencesVp8(pid + 3, pid + 1, pid + 2);
+ CheckReferencesVp8(pid + 4, pid + 2);
+ CheckReferencesVp8(pid + 5, pid + 3, pid + 4);
+}
+
// Test with 1 temporal layer.
TEST_F(TestRtpFrameReferenceFinder, Vp8TemporalLayersReordering_0) {
uint16_t pid = Rand();
« no previous file with comments | « webrtc/modules/video_coding/rtp_frame_reference_finder.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698