Drop VP8 frames in case of duplicates in RtpFrameReferenceFinder.

webrtc/modules/video_coding/rtp_frame_reference_finder_unittest.cc

 /*
  *  Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 410 matching lines @@
   InsertVp8(sn + 2, sn + 2, false, pid + 2, 0, 3);
   InsertVp8(sn + 3, sn + 3, false, pid + 3, 0, 4);
 
   ASSERT_EQ(4UL, frames_from_callback_.size());
   CheckReferencesVp8(pid);
   CheckReferencesVp8(pid + 1, pid);
   CheckReferencesVp8(pid + 2, pid + 1);
   CheckReferencesVp8(pid + 3, pid + 2);
 }
 
+TEST_F(TestRtpFrameReferenceFinder, Vp8DuplicateTl1Frames) {
+  uint16_t pid = Rand();
+  uint16_t sn = Rand();
+
+  InsertVp8(sn, sn, true, pid, 0, 0);
+  InsertVp8(sn + 1, sn + 1, false, pid + 1, 1, 0, true);
+  InsertVp8(sn + 2, sn + 2, false, pid + 2, 0, 1);
+  InsertVp8(sn + 3, sn + 3, false, pid + 3, 1, 1);
+  InsertVp8(sn + 3, sn + 3, false, pid + 3, 1, 1);

[sprang_webrtc, 2017/03/06 09:52:52]

Should you add something new after this one to make sure it doesn't get stuck in
a weird state?

[philipel, 2017/03/07 10:47:11]

Done.

+
+  ASSERT_EQ(4UL, frames_from_callback_.size());
+  CheckReferencesVp8(pid);
+  CheckReferencesVp8(pid + 1, pid);
+  CheckReferencesVp8(pid + 2, pid);
+  CheckReferencesVp8(pid + 3, pid + 1, pid + 2);
+}
+
 // Test with 1 temporal layer.
 TEST_F(TestRtpFrameReferenceFinder, Vp8TemporalLayersReordering_0) {
   uint16_t pid = Rand();
   uint16_t sn = Rand();
 
   InsertVp8(sn, sn, true, pid, 0, 1);
   InsertVp8(sn + 1, sn + 1, false, pid + 1, 0, 2);
   InsertVp8(sn + 3, sn + 3, false, pid + 3, 0, 4);
   InsertVp8(sn + 2, sn + 2, false, pid + 2, 0, 3);
   InsertVp8(sn + 5, sn + 5, false, pid + 5, 0, 6);
@@ skipping 1050 matching lines @@
     reference_finder_->ManageFrame(std::move(frame));
   }
 
   ASSERT_EQ(2UL, frames_from_callback_.size());
   CheckReferencesVp9(1, 0);
   CheckReferencesVp9(129, 0);
 }
 
 }  // namespace video_coding
 }  // namespace webrtc