Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2732363004: Revert of Delete unused TaskRunner abstraction. (Closed)

Created:
3 years, 9 months ago by nisse-webrtc
Modified:
3 years, 9 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Delete unused TaskRunner abstraction. (patchset #2 id:20001 of https://codereview.webrtc.org/2622923002/ ) Reason for revert: I had missed updating a few of Chrome's #includes, breaking the build. Original issue's description: > Delete unused TaskRunner abstraction. > > This is the fifth and final step in the process started in cl https://codereview.webrtc.org/2696703009/ > > Depends on the landing of a copy of this code in Chrome (step 4), cl > https://codereview.chromium.org/2694903005/ > > BUG=webrtc:6424 > > Review-Url: https://codereview.webrtc.org/2622923002 > Cr-Commit-Position: refs/heads/master@{#17107} > Committed: https://chromium.googlesource.com/external/webrtc/+/2d15fdd91bc8b63a5659a8d48b7460cb2308e7a2 TBR=pthatcher@webrtc.org,kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:6424 Review-Url: https://codereview.webrtc.org/2732363004 Cr-Commit-Position: refs/heads/master@{#17109} Committed: https://chromium.googlesource.com/external/webrtc/+/9900be313c212c276377d406585b706079f8bc41

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1495 lines, -0 lines) Patch
M webrtc/base/BUILD.gn View 3 chunks +15 lines, -0 lines 0 comments Download
A webrtc/base/task.h View 1 chunk +175 lines, -0 lines 0 comments Download
A webrtc/base/task.cc View 1 chunk +283 lines, -0 lines 0 comments Download
A webrtc/base/task_unittest.cc View 1 chunk +542 lines, -0 lines 0 comments Download
A webrtc/base/taskparent.h View 1 chunk +63 lines, -0 lines 0 comments Download
A webrtc/base/taskparent.cc View 1 chunk +98 lines, -0 lines 0 comments Download
A webrtc/base/taskrunner.h View 1 chunk +102 lines, -0 lines 0 comments Download
A webrtc/base/taskrunner.cc View 1 chunk +217 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
nisse-webrtc
Created Revert of Delete unused TaskRunner abstraction.
3 years, 9 months ago (2017-03-08 10:00:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2732363004/1
3 years, 9 months ago (2017-03-08 10:00:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/9900be313c212c276377d406585b706079f8bc41
3 years, 9 months ago (2017-03-08 10:01:13 UTC) #6
nisse-webrtc
3 years, 9 months ago (2017-03-09 08:37:10 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2740063002/ by nisse@webrtc.org.

The reason for reverting is: Chrome includes now updated, see cl
https://codereview.chromium.org/2737133002/.

Powered by Google App Engine
This is Rietveld 408576698