Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Issue 2696703009: Add gn target rtc_task_runner. (Closed)

Created:
3 years, 10 months ago by nisse-webrtc
Modified:
3 years, 10 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add gn target rtc_task_runner. This is step 1 in the following process to move the task runner abstraction over to Chrome, without gettings link errors on duplicate symbols. 1. Move files from the rtc_base target to a new target rtc_task_runner, and let rtc_base publicly depend on it. 2. In Chrome, add an explicit dependency on rtc_task_runner where it depends on rtc_base. 3. Drop the webrtc dependency rtc_base --> rtc_task_runner. 4. Copy task runner code to Chrome (cl https://codereview.chromium.org/2694903005/), and drop its dependency on webrtc's rtc_task_runner target. 5. Delete the rtc_task_runner target and corresponding source files from webrtc. Mission accomplished! BUG=webrtc:6424 Review-Url: https://codereview.webrtc.org/2696703009 Cr-Commit-Position: refs/heads/master@{#16710} Committed: https://chromium.googlesource.com/external/webrtc/+/915bbd53e477d86515b9782d66b3a7275a172fa5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -6 lines) Patch
M webrtc/base/BUILD.gn View 3 chunks +14 lines, -6 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
nisse-webrtc
I can't convince gn/ninja to produce a working link library order in the presence of ...
3 years, 10 months ago (2017-02-16 13:32:18 UTC) #2
kjellander_webrtc
lgtm, thanks for taking the time to do this!
3 years, 10 months ago (2017-02-16 14:37:16 UTC) #3
pthatcher1
lgtm
3 years, 10 months ago (2017-02-17 18:20:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2696703009/1
3 years, 10 months ago (2017-02-20 07:40:16 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-20 08:50:26 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/915bbd53e477d86515b9782d6...

Powered by Google App Engine
This is Rietveld 408576698