Delete unused TaskRunner abstraction.

Delete unused TaskRunner abstraction.

This is the fifth and final step in the process started in cl https://codereview.webrtc.org/2696703009/

Depends on the landing of a copy of this code in Chrome (step 4), cl 
https://codereview.chromium.org/2694903005/

BUG=webrtc:6424
Review-Url: https://codereview.webrtc.org/2622923002
Cr-Commit-Position: refs/heads/master@{#17107}
Committed: https://chromium.googlesource.com/external/webrtc/+/2d15fdd91bc8b63a5659a8d48b7460cb2308e7a2

[nisse-webrtc, 2017-01-10 15:14:02]

nisse@webrtc.org changed reviewers:
+ kjellander@webrtc.org, pthatcher@webrtc.org

[nisse-webrtc, 2017-01-10 15:14:02]

Hi,

I have little clue what this code is about, but it isn't used anywhere in
webrtc.

It appears used in a couple of places in chrome, though:

$ git grep '#include.*/base/task\.'
jingle/glue/mock_task.h:#include "third_party/webrtc/base/task.h"
jingle/notifier/listener/push_notifications_listen_task.cc:#include
"webrtc/base/task.h"
jingle/notifier/listener/push_notifications_subscribe_task.cc:#include
"webrtc/base/task.h"
third_party/libjingle_xmpp/xmpp/xmppclient.h:#include
"third_party/webrtc/base/task.h"
third_party/libjingle_xmpp/xmpp/xmpptask.h:#include
"third_party/webrtc/base/task.h"
$ git grep '#include.*/base/taskrunner\.'
jingle/glue/task_pump.h:#include "third_party/webrtc/base/taskrunner.h"
jingle/notifier/communicator/login.cc:#include "webrtc/base/taskrunner.h"

Can we move it over to chrome? Or is it easy to move chrome over to using some
abstractions of its own?

[pthatcher1, 2017-01-10 17:27:31]

This is still used by
https://cs.chromium.org/chromium/src/jingle/glue/task_pump.cc which is used by 
https://cs.chromium.org/chromium/src/jingle/notifier/base/xmpp_connection.cc

They recently moved this old libjingle/xmpp code into
https://cs.chromium.org/chromium/src/third_party/libjingle_xmpp/.  Perhaps they
can move these files over there since nothing else uses it.  But if you check
this in as-is, I believe you will break their build.

[kjellander_webrtc, 2017-02-15 07:32:56]

On 2017/01/10 17:27:31, pthatcher1 wrote:
> This is still used by
> https://cs.chromium.org/chromium/src/jingle/glue/task_pump.cc which is used by

> https://cs.chromium.org/chromium/src/jingle/notifier/base/xmpp_connection.cc
> 
> They recently moved this old libjingle/xmpp code into
> https://cs.chromium.org/chromium/src/third_party/libjingle_xmpp/.  Perhaps
they
> can move these files over there since nothing else uses it.  But if you check
> this in as-is, I believe you will break their build.

Any update on this? It seems like a good idea to move this into Chromium's
src/third_party/libjingle_xmpp if Chromium's src/jingle is the only user.

[nisse-webrtc, 2017-02-15 08:09:07]

On 2017/02/15 07:32:56, kjellander_webrtc wrote:
> On 2017/01/10 17:27:31, pthatcher1 wrote:
> > This is still used by
> > https://cs.chromium.org/chromium/src/jingle/glue/task_pump.cc which is used
by
> 
> > https://cs.chromium.org/chromium/src/jingle/notifier/base/xmpp_connection.cc
> > 
> > They recently moved this old libjingle/xmpp code into
> > https://cs.chromium.org/chromium/src/third_party/libjingle_xmpp/.  Perhaps
> they
> > can move these files over there since nothing else uses it.  But if you
check
> > this in as-is, I believe you will break their build.
> 
> Any update on this? It seems like a good idea to move this into Chromium's
> src/third_party/libjingle_xmpp if Chromium's src/jingle is the only user.

I'm not familiar with the organization of the chrome code. I you have a precise
suggestion on which subdirectory I should put the files in (inside
third_party/libjingle_xmpp/xmpp, or a new subdir there, or somewhere under
src/jingle closer to 
task_pump.cc...?), I can give it a try.

[kjellander_webrtc, 2017-02-15 08:30:04]

On 2017/02/15 08:09:07, nisse-webrtc wrote:
> On 2017/02/15 07:32:56, kjellander_webrtc wrote:
> > On 2017/01/10 17:27:31, pthatcher1 wrote:
> > > This is still used by
> > > https://cs.chromium.org/chromium/src/jingle/glue/task_pump.cc which is
used
> by
> > 
> > >
https://cs.chromium.org/chromium/src/jingle/notifier/base/xmpp_connection.cc
> > > 
> > > They recently moved this old libjingle/xmpp code into
> > > https://cs.chromium.org/chromium/src/third_party/libjingle_xmpp/.  Perhaps
> > they
> > > can move these files over there since nothing else uses it.  But if you
> check
> > > this in as-is, I believe you will break their build.
> > 
> > Any update on this? It seems like a good idea to move this into Chromium's
> > src/third_party/libjingle_xmpp if Chromium's src/jingle is the only user.
> 
> I'm not familiar with the organization of the chrome code. I you have a
precise
> suggestion on which subdirectory I should put the files in (inside
> third_party/libjingle_xmpp/xmpp, or a new subdir there, or somewhere under
> src/jingle closer to 
> task_pump.cc...?), I can give it a try.

I dunno, but since you're going to have to fix a ton of Clang warnings if you
put it into src/jingle I'd suggest something like
src/third_party/libjingle_xmpp/task_runner.
We can always change that later as part of the review of the CL.

[nisse-webrtc, 2017-02-24 08:38:23]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 08:38:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[nisse-webrtc, 2017-02-24 08:50:19]

Description was changed from

==========
Delete unused TaskRunner abstraction.

BUG=webrtc:6424
==========

to

==========
Delete unused TaskRunner abstraction.

This is the fifth and final step in the process started in cl
https://codereview.webrtc.org/2696703009/

Depends on the landing of a copy of this code in Chrome (step 4), cl 
https://codereview.chromium.org/2694903005/

BUG=webrtc:6424
==========

[nisse-webrtc, 2017-02-24 08:52:47]

The chrome cl this depends on is being landed.

[commit-bot: I haz the power, 2017-02-24 09:39:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 09:39:15]

Dry run: This issue passed the CQ dry run.

[pthatcher1, 2017-03-03 06:54:43]

lgtm

Looks like the copy landed.

[kjellander_webrtc, 2017-03-08 09:23:40]

lgtm

[nisse-webrtc, 2017-03-08 09:25:09]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2017-03-08 09:25:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-08 09:45:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488965109219900,
"parent_rev": "34b7a9186269b5ce8ac84c285715679f7edd37ef", "commit_rev":
"2d15fdd91bc8b63a5659a8d48b7460cb2308e7a2"}

[commit-bot: I haz the power, 2017-03-08 09:45:11]

Description was changed from

==========
Delete unused TaskRunner abstraction.

This is the fifth and final step in the process started in cl
https://codereview.webrtc.org/2696703009/

Depends on the landing of a copy of this code in Chrome (step 4), cl 
https://codereview.chromium.org/2694903005/

BUG=webrtc:6424
==========

to

==========
Delete unused TaskRunner abstraction.

This is the fifth and final step in the process started in cl
https://codereview.webrtc.org/2696703009/

Depends on the landing of a copy of this code in Chrome (step 4), cl 
https://codereview.chromium.org/2694903005/

BUG=webrtc:6424

Review-Url: https://codereview.webrtc.org/2622923002
Cr-Commit-Position: refs/heads/master@{#17107}
Committed:
https://chromium.googlesource.com/external/webrtc/+/2d15fdd91bc8b63a5659a8d48...
==========

[commit-bot: I haz the power, 2017-03-08 09:45:12]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/2d15fdd91bc8b63a5659a8d48...

[nisse-webrtc, 2017-03-08 10:00:51]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.webrtc.org/2732363004/ by nisse@webrtc.org.

The reason for reverting is: I had missed updating a few of Chrome's #includes,
breaking the build..