Revert of Use sched_yield on all POSIX platforms in PlatformThread.

Revert of Use sched_yield on all POSIX platforms in PlatformThread. (patchset #1 id:1 of https://codereview.webrtc.org/2725573002/ )

Reason for revert:
breaks linux_ubsan bots.

Original issue's description:
> Reland of Use sched_yield on all POSIX platforms in PlatformThread. (patchset #1 id:1 of https://codereview.webrtc.org/2712133003/ )
> 
> Reason for revert:
> Relanding - using sched_yield() in PlatformThread on all posix platforms.
> 
> Original issue's description:
> > Revert of Use sched_yield on all POSIX platforms in PlatformThread. (patchset #1 id:1 of https://codereview.webrtc.org/2716683002/ )
> > 
> > Reason for revert:
> > Reverting this change since it didn't affect the perf regressions we were seeing and actually seems to have caused more regressions as per comment in the bug.
> > 
> > Original issue's description:
> > > Use sched_yield on all POSIX platforms in PlatformThread.
> > > (not only MacOS)
> > > 
> > > This is a test to see if perf regressions we're seeing may be related to the use of nanosleep().
> > > 
> > > BUG=695438
> > > TBR=solenberg@webrtc.org
> > > 
> > > Review-Url: https://codereview.webrtc.org/2716683002 .
> > > Cr-Commit-Position: refs/heads/master@{#16807}
> > > Committed: https://chromium.googlesource.com/external/webrtc/+/384498abb5a0dc3e871e437e56b4a556c3ec1023
> > 
> > TBR=solenberg@webrtc.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=695438
> > 
> > Review-Url: https://codereview.webrtc.org/2712133003
> > Cr-Commit-Position: refs/heads/master@{#16833}
> > Committed: https://chromium.googlesource.com/external/webrtc/+/3ba1a8cd1b875dc7bfcb7075fe4f78d0dfe0ff98
> 
> TBR=solenberg@webrtc.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=695438
> 
> Review-Url: https://codereview.webrtc.org/2725573002
> Cr-Commit-Position: refs/heads/master@{#16899}
> Committed: https://chromium.googlesource.com/external/webrtc/+/4974df41838367e4d50c42bef3be121c7ac6e331

TBR=solenberg@webrtc.org,tommi@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=695438
Review-Url: https://codereview.webrtc.org/2721893002
Cr-Commit-Position: refs/heads/master@{#16903}
Committed: https://chromium.googlesource.com/external/webrtc/+/275234763b50c059dbf173e00294d0ea7f452d92

[danilchap, 2017-02-28 14:20:27]

The CQ bit was checked by danilchap@webrtc.org

[danilchap, 2017-02-28 14:20:27]

Created Revert of Use sched_yield on all POSIX platforms in PlatformThread.

[commit-bot: I haz the power, 2017-02-28 14:20:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-28 14:20:39]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1488291627414390, "parent_rev":
"b1629cf5d604363dd902b8ec2454ef279353c81f", "commit_rev":
"275234763b50c059dbf173e00294d0ea7f452d92"}

[commit-bot: I haz the power, 2017-02-28 14:20:41]

Description was changed from

==========
Revert of Use sched_yield on all POSIX platforms in PlatformThread. (patchset #1
id:1 of https://codereview.webrtc.org/2725573002/ )

Reason for revert:
breaks linux_ubsan bots.

Original issue's description:
> Reland of Use sched_yield on all POSIX platforms in PlatformThread. (patchset
#1 id:1 of https://codereview.webrtc.org/2712133003/ )
> 
> Reason for revert:
> Relanding - using sched_yield() in PlatformThread on all posix platforms.
> 
> Original issue's description:
> > Revert of Use sched_yield on all POSIX platforms in PlatformThread.
(patchset #1 id:1 of https://codereview.webrtc.org/2716683002/ )
> > 
> > Reason for revert:
> > Reverting this change since it didn't affect the perf regressions we were
seeing and actually seems to have caused more regressions as per comment in the
bug.
> > 
> > Original issue's description:
> > > Use sched_yield on all POSIX platforms in PlatformThread.
> > > (not only MacOS)
> > > 
> > > This is a test to see if perf regressions we're seeing may be related to
the use of nanosleep().
> > > 
> > > BUG=695438
> > > TBR=solenberg@webrtc.org
> > > 
> > > Review-Url: https://codereview.webrtc.org/2716683002 .
> > > Cr-Commit-Position: refs/heads/master@{#16807}
> > > Committed:
https://chromium.googlesource.com/external/webrtc/+/384498abb5a0dc3e871e437e5...
> > 
> > TBR=solenberg@webrtc.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=695438
> > 
> > Review-Url: https://codereview.webrtc.org/2712133003
> > Cr-Commit-Position: refs/heads/master@{#16833}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/3ba1a8cd1b875dc7bfcb7075f...
> 
> TBR=solenberg@webrtc.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=695438
> 
> Review-Url: https://codereview.webrtc.org/2725573002
> Cr-Commit-Position: refs/heads/master@{#16899}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/4974df41838367e4d50c42bef...

TBR=solenberg@webrtc.org,tommi@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=695438
==========

to

==========
Revert of Use sched_yield on all POSIX platforms in PlatformThread. (patchset #1
id:1 of https://codereview.webrtc.org/2725573002/ )

Reason for revert:
breaks linux_ubsan bots.

Original issue's description:
> Reland of Use sched_yield on all POSIX platforms in PlatformThread. (patchset
#1 id:1 of https://codereview.webrtc.org/2712133003/ )
> 
> Reason for revert:
> Relanding - using sched_yield() in PlatformThread on all posix platforms.
> 
> Original issue's description:
> > Revert of Use sched_yield on all POSIX platforms in PlatformThread.
(patchset #1 id:1 of https://codereview.webrtc.org/2716683002/ )
> > 
> > Reason for revert:
> > Reverting this change since it didn't affect the perf regressions we were
seeing and actually seems to have caused more regressions as per comment in the
bug.
> > 
> > Original issue's description:
> > > Use sched_yield on all POSIX platforms in PlatformThread.
> > > (not only MacOS)
> > > 
> > > This is a test to see if perf regressions we're seeing may be related to
the use of nanosleep().
> > > 
> > > BUG=695438
> > > TBR=solenberg@webrtc.org
> > > 
> > > Review-Url: https://codereview.webrtc.org/2716683002 .
> > > Cr-Commit-Position: refs/heads/master@{#16807}
> > > Committed:
https://chromium.googlesource.com/external/webrtc/+/384498abb5a0dc3e871e437e5...
> > 
> > TBR=solenberg@webrtc.org
> > # Skipping CQ checks because original CL landed less than 1 days ago.
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=695438
> > 
> > Review-Url: https://codereview.webrtc.org/2712133003
> > Cr-Commit-Position: refs/heads/master@{#16833}
> > Committed:
https://chromium.googlesource.com/external/webrtc/+/3ba1a8cd1b875dc7bfcb7075f...
> 
> TBR=solenberg@webrtc.org
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=695438
> 
> Review-Url: https://codereview.webrtc.org/2725573002
> Cr-Commit-Position: refs/heads/master@{#16899}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/4974df41838367e4d50c42bef...

TBR=solenberg@webrtc.org,tommi@webrtc.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=695438

Review-Url: https://codereview.webrtc.org/2721893002
Cr-Commit-Position: refs/heads/master@{#16903}
Committed:
https://chromium.googlesource.com/external/webrtc/+/275234763b50c059dbf173e00...
==========

[commit-bot: I haz the power, 2017-02-28 14:20:42]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/275234763b50c059dbf173e00...

[tommi, 2017-02-28 23:23:39]

On 2017/02/28 14:20:42, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/external/webrtc/+/275234763b50c059dbf173e00...

Can you include a link to the failure?  I'm looking here:
https://build.chromium.org/p/client.webrtc/builders/Linux%20UBSan?numbuilds=200
Those builds are all green.

[tommi, 2017-02-28 23:24:48]

On 2017/02/28 23:23:39, tommi (webrtc) wrote:
> On 2017/02/28 14:20:42, commit-bot: I haz the power wrote:
> > Committed patchset #1 (id:1) as
> >
>
https://chromium.googlesource.com/external/webrtc/+/275234763b50c059dbf173e00...
> 
> Can you include a link to the failure?  I'm looking here:
>
https://build.chromium.org/p/client.webrtc/builders/Linux%20UBSan?numbuilds=200
> Those builds are all green.

Ah, nevermind, it's the "Linux UBSan vptr" bot.

[tommi, 2017-03-01 10:02:35]

On 2017/02/28 23:24:48, tommi (webrtc) wrote:
> On 2017/02/28 23:23:39, tommi (webrtc) wrote:
> > On 2017/02/28 14:20:42, commit-bot: I haz the power wrote:
> > > Committed patchset #1 (id:1) as
> > >
> >
>
https://chromium.googlesource.com/external/webrtc/+/275234763b50c059dbf173e00...
> > 
> > Can you include a link to the failure?  I'm looking here:
> >
>
https://build.chromium.org/p/client.webrtc/builders/Linux%20UBSan?numbuilds=200
> > Those builds are all green.
> 
> Ah, nevermind, it's the "Linux UBSan vptr" bot.

Looks like ubsan does simply not play nice with sched_yield(). no idea why.