Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Issue 2725573002: Reland of Use sched_yield on all POSIX platforms in PlatformThread. (Closed)

Created:
3 years, 9 months ago by tommi
Modified:
3 years, 9 months ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Use sched_yield on all POSIX platforms in PlatformThread. (patchset #1 id:1 of https://codereview.webrtc.org/2712133003/ ) Reason for revert: Relanding - using sched_yield() in PlatformThread on all posix platforms. Original issue's description: > Revert of Use sched_yield on all POSIX platforms in PlatformThread. (patchset #1 id:1 of https://codereview.webrtc.org/2716683002/ ) > > Reason for revert: > Reverting this change since it didn't affect the perf regressions we were seeing and actually seems to have caused more regressions as per comment in the bug. > > Original issue's description: > > Use sched_yield on all POSIX platforms in PlatformThread. > > (not only MacOS) > > > > This is a test to see if perf regressions we're seeing may be related to the use of nanosleep(). > > > > BUG=695438 > > TBR=solenberg@webrtc.org > > > > Review-Url: https://codereview.webrtc.org/2716683002 . > > Cr-Commit-Position: refs/heads/master@{#16807} > > Committed: https://chromium.googlesource.com/external/webrtc/+/384498abb5a0dc3e871e437e56b4a556c3ec1023 > > TBR=solenberg@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=695438 > > Review-Url: https://codereview.webrtc.org/2712133003 > Cr-Commit-Position: refs/heads/master@{#16833} > Committed: https://chromium.googlesource.com/external/webrtc/+/3ba1a8cd1b875dc7bfcb7075fe4f78d0dfe0ff98 TBR=solenberg@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=695438 Review-Url: https://codereview.webrtc.org/2725573002 Cr-Commit-Position: refs/heads/master@{#16899} Committed: https://chromium.googlesource.com/external/webrtc/+/4974df41838367e4d50c42bef3be121c7ac6e331

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M webrtc/base/platform_thread.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
tommi
Created Reland of Use sched_yield on all POSIX platforms in PlatformThread.
3 years, 9 months ago (2017-02-28 10:22:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2725573002/1
3 years, 9 months ago (2017-02-28 10:22:25 UTC) #3
the sun
lgtm
3 years, 9 months ago (2017-02-28 10:42:17 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_ubsan_vptr on master.tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/linux_ubsan_vptr/builds/10587)
3 years, 9 months ago (2017-02-28 11:01:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2725573002/1
3 years, 9 months ago (2017-02-28 11:04:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/4974df41838367e4d50c42bef3be121c7ac6e331
3 years, 9 months ago (2017-02-28 11:17:39 UTC) #11
danilchap
3 years, 9 months ago (2017-02-28 14:20:27 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2721893002/ by danilchap@webrtc.org.

The reason for reverting is: breaks linux_ubsan bots..

Powered by Google App Engine
This is Rietveld 408576698