Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 2716683002: Use sched_yield on all POSIX platforms in PlatformThread. (Closed)

Created:
3 years, 10 months ago by tommi
Modified:
3 years, 10 months ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use sched_yield on all POSIX platforms in PlatformThread. (not only MacOS) This is a test to see if perf regressions we're seeing may be related to the use of nanosleep(). BUG=695438 TBR=solenberg@webrtc.org Review-Url: https://codereview.webrtc.org/2716683002 . Cr-Commit-Position: refs/heads/master@{#16807} Committed: https://chromium.googlesource.com/external/webrtc/+/384498abb5a0dc3e871e437e56b4a556c3ec1023

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M webrtc/base/platform_thread.cc View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tommi
3 years, 10 months ago (2017-02-23 19:11:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2716683002/1
3 years, 10 months ago (2017-02-23 19:11:18 UTC) #3
tommi
Committed patchset #1 (id:1) manually as 384498abb5a0dc3e871e437e56b4a556c3ec1023 (presubmit successful).
3 years, 10 months ago (2017-02-23 19:23:27 UTC) #5
the sun
lgtm
3 years, 10 months ago (2017-02-23 19:40:38 UTC) #6
tommi
3 years, 10 months ago (2017-02-24 17:12:18 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2712133003/ by tommi@webrtc.org.

The reason for reverting is: Reverting this change since it didn't affect the
perf regressions we were seeing and actually seems to have caused more
regressions as per comment in the bug..

Powered by Google App Engine
This is Rietveld 408576698