Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 2712133003: Revert of Use sched_yield on all POSIX platforms in PlatformThread. (Closed)

Created:
3 years, 10 months ago by tommi
Modified:
3 years, 10 months ago
Reviewers:
the sun
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Use sched_yield on all POSIX platforms in PlatformThread. (patchset #1 id:1 of https://codereview.webrtc.org/2716683002/ ) Reason for revert: Reverting this change since it didn't affect the perf regressions we were seeing and actually seems to have caused more regressions as per comment in the bug. Original issue's description: > Use sched_yield on all POSIX platforms in PlatformThread. > (not only MacOS) > > This is a test to see if perf regressions we're seeing may be related to the use of nanosleep(). > > BUG=695438 > TBR=solenberg@webrtc.org > > Review-Url: https://codereview.webrtc.org/2716683002 . > Cr-Commit-Position: refs/heads/master@{#16807} > Committed: https://chromium.googlesource.com/external/webrtc/+/384498abb5a0dc3e871e437e56b4a556c3ec1023 TBR=solenberg@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=695438 Review-Url: https://codereview.webrtc.org/2712133003 Cr-Commit-Position: refs/heads/master@{#16833} Committed: https://chromium.googlesource.com/external/webrtc/+/3ba1a8cd1b875dc7bfcb7075fe4f78d0dfe0ff98

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M webrtc/base/platform_thread.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
tommi
Created Revert of Use sched_yield on all POSIX platforms in PlatformThread.
3 years, 10 months ago (2017-02-24 17:12:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2712133003/1
3 years, 10 months ago (2017-02-24 17:12:27 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/webrtc/+/3ba1a8cd1b875dc7bfcb7075fe4f78d0dfe0ff98
3 years, 10 months ago (2017-02-24 17:12:36 UTC) #6
tommi
3 years, 9 months ago (2017-02-28 10:22:14 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/2725573002/ by tommi@webrtc.org.

The reason for reverting is: Relanding - using sched_yield() in PlatformThread
on all posix platforms..

Powered by Google App Engine
This is Rietveld 408576698