Enable GN check for webrtc/logging

Enable GN check for webrtc/logging

BUG=webrtc:6828, webrtc:7257
NOTRY=True

Review-Url: https://codereview.webrtc.org/2717903002
Cr-Commit-Position: refs/heads/master@{#17111}
Committed: https://chromium.googlesource.com/external/webrtc/+/727ac1d4c00cb12cd7e8eedfcaa29657eb03cb02

[kjellander_webrtc, 2017-02-26 03:48:58]

Description was changed from

==========
Enable GN check in webrtc/logging

BUG=webrtc:6828
==========

to

==========
Enable GN check for webrtc/logging

BUG=webrtc:6828
==========

[kjellander_webrtc, 2017-02-26 06:56:40]

kjellander@webrtc.org changed reviewers:
+ terelius@webrtc.org

[kjellander_webrtc, 2017-02-26 06:56:50]

Description was changed from

==========
Enable GN check for webrtc/logging

BUG=webrtc:6828
==========

to

==========
Enable GN check for webrtc/logging

BUG=webrtc:6828
NOTRY=True
==========

[terelius, 2017-02-27 17:26:16]

https://codereview.webrtc.org/2717903002/diff/1/webrtc/logging/BUILD.gn
File webrtc/logging/BUILD.gn (right):

https://codereview.webrtc.org/2717903002/diff/1/webrtc/logging/BUILD.gn#newco...
webrtc/logging/BUILD.gn:31: check_includes = false
I don't think this should be needed. I've filed a separate bug to track this
cyclic dependency. https://bugs.chromium.org/p/webrtc/issues/detail?id=7257

https://codereview.webrtc.org/2717903002/diff/1/webrtc/logging/BUILD.gn#newco...
webrtc/logging/BUILD.gn:38: "../system_wrappers",
Why do we need system_wrappers?

[kjellander_webrtc, 2017-02-27 22:33:50]

Description was changed from

==========
Enable GN check for webrtc/logging

BUG=webrtc:6828
NOTRY=True
==========

to

==========
Enable GN check for webrtc/logging

BUG=webrtc:6828, webrtc:7257
NOTRY=True
==========

[kjellander_webrtc, 2017-02-27 22:43:28]

https://codereview.webrtc.org/2717903002/diff/1/webrtc/logging/BUILD.gn
File webrtc/logging/BUILD.gn (right):

https://codereview.webrtc.org/2717903002/diff/1/webrtc/logging/BUILD.gn#newco...
webrtc/logging/BUILD.gn:31: check_includes = false
On 2017/02/27 17:26:16, terelius wrote:
> I don't think this should be needed. I've filed a separate bug to track this
> cyclic dependency. https://bugs.chromium.org/p/webrtc/issues/detail?id=7257

It is. If I remove it I have to add 
//webrtc/modules/audio_coding:audio_network_adaptor
which in turn will cause the cycle described above. Thanks for filing the bug; I
added a reference to it.

https://codereview.webrtc.org/2717903002/diff/1/webrtc/logging/BUILD.gn#newco...
webrtc/logging/BUILD.gn:38: "../system_wrappers",
On 2017/02/27 17:26:16, terelius wrote:
> Why do we need system_wrappers?

Good catch. It seems this particular one is not needed. I must have added it by
accident here when I fixed the missing dependencies below (where it's actually
needed). 

Removed it now.

[terelius, 2017-03-08 08:53:42]

lgtm

[kjellander_webrtc, 2017-03-08 10:09:51]

The CQ bit was checked by kjellander@webrtc.org

[kjellander_webrtc, 2017-03-08 10:09:51]

The patchset sent to the CQ was uploaded after l-g-t-m from terelius@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2717903002/#ps100001 (title:
"Restore .gn change again")

[commit-bot: I haz the power, 2017-03-08 10:09:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-03-08 10:12:12]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1488967791198260,
"parent_rev": "0d4e235a963aa58bd3ae05aece45331a68d83adf", "commit_rev":
"727ac1d4c00cb12cd7e8eedfcaa29657eb03cb02"}

[commit-bot: I haz the power, 2017-03-08 10:12:15]

Description was changed from

==========
Enable GN check for webrtc/logging

BUG=webrtc:6828, webrtc:7257
NOTRY=True
==========

to

==========
Enable GN check for webrtc/logging

BUG=webrtc:6828, webrtc:7257
NOTRY=True

Review-Url: https://codereview.webrtc.org/2717903002
Cr-Commit-Position: refs/heads/master@{#17111}
Committed:
https://chromium.googlesource.com/external/webrtc/+/727ac1d4c00cb12cd7e8eedfc...
==========

[commit-bot: I haz the power, 2017-03-08 10:12:17]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/external/webrtc/+/727ac1d4c00cb12cd7e8eedfc...