Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Side by Side Diff: .gn

Issue 2717903002: Enable GN check for webrtc/logging (Closed)
Patch Set: Restore .gn change again Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | webrtc/logging/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("//build/dotfile_settings.gni") 9 import("//build/dotfile_settings.gni")
10 10
(...skipping 10 matching lines...) Expand all
21 # their includes checked for proper dependencies when you run either 21 # their includes checked for proper dependencies when you run either
22 # "gn check" or "gn gen --check". 22 # "gn check" or "gn gen --check".
23 # TODO(kjellander): Keep adding paths to this list as work in webrtc:5589 is don e. 23 # TODO(kjellander): Keep adding paths to this list as work in webrtc:5589 is don e.
24 check_targets = [ 24 check_targets = [
25 "//webrtc/api/*", 25 "//webrtc/api/*",
26 "//webrtc/audio/*", 26 "//webrtc/audio/*",
27 "//webrtc/call/*", 27 "//webrtc/call/*",
28 "//webrtc/common_video/*", 28 "//webrtc/common_video/*",
29 "//webrtc/common_audio/*", 29 "//webrtc/common_audio/*",
30 "//webrtc/examples/*", 30 "//webrtc/examples/*",
31 "//webrtc/logging/*",
31 "//webrtc/media/*", 32 "//webrtc/media/*",
32 "//webrtc/modules/*", 33 "//webrtc/modules/*",
33 "//webrtc/stats/*", 34 "//webrtc/stats/*",
34 "//webrtc/voice_engine/*", 35 "//webrtc/voice_engine/*",
35 ] 36 ]
36 37
37 # These are the list of GN files that run exec_script. This whitelist exists 38 # These are the list of GN files that run exec_script. This whitelist exists
38 # to force additional review for new uses of exec_script, which is strongly 39 # to force additional review for new uses of exec_script, which is strongly
39 # discouraged except for gypi_to_gn calls. 40 # discouraged except for gypi_to_gn calls.
40 exec_script_whitelist = build_dotfile_settings.exec_script_whitelist 41 exec_script_whitelist = build_dotfile_settings.exec_script_whitelist
41 42
42 default_args = { 43 default_args = {
43 # Webrtc does not support component builds because we are not using the 44 # Webrtc does not support component builds because we are not using the
44 # template "component" but we rely directly on "rtc_static_library" and 45 # template "component" but we rely directly on "rtc_static_library" and
45 # "rtc_shared_library". This means that we cannot use the chromium default 46 # "rtc_shared_library". This means that we cannot use the chromium default
46 # value for this argument. 47 # value for this argument.
47 # This also means that the user can override this value using --args or 48 # This also means that the user can override this value using --args or
48 # the args.gn file but this setting will be ignored because we don't support 49 # the args.gn file but this setting will be ignored because we don't support
49 # component builds. 50 # component builds.
50 is_component_build = false 51 is_component_build = false
51 } 52 }
OLDNEW
« no previous file with comments | « no previous file | webrtc/logging/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698