Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Side by Side Diff: webrtc/logging/BUILD.gn

Issue 2717903002: Enable GN check for webrtc/logging (Closed)
Patch Set: Restore .gn change again Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « .gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved. 1 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
2 # 2 #
3 # Use of this source code is governed by a BSD-style license 3 # Use of this source code is governed by a BSD-style license
4 # that can be found in the LICENSE file in the root of the source 4 # that can be found in the LICENSE file in the root of the source
5 # tree. An additional intellectual property rights grant can be found 5 # tree. An additional intellectual property rights grant can be found
6 # in the file PATENTS. All contributing project authors may 6 # in the file PATENTS. All contributing project authors may
7 # be found in the AUTHORS file in the root of the source tree. 7 # be found in the AUTHORS file in the root of the source tree.
8 8
9 import("../webrtc.gni") 9 import("../webrtc.gni")
10 import("//third_party/protobuf/proto_library.gni") 10 import("//third_party/protobuf/proto_library.gni")
11 if (is_android) { 11 if (is_android) {
12 import("//build/config/android/config.gni") 12 import("//build/config/android/config.gni")
13 import("//build/config/android/rules.gni") 13 import("//build/config/android/rules.gni")
14 } 14 }
15 15
16 group("logging") { 16 group("logging") {
17 public_deps = [ 17 public_deps = [
18 ":rtc_event_log_impl", 18 ":rtc_event_log_impl",
19 ] 19 ]
20 if (rtc_enable_protobuf) { 20 if (rtc_enable_protobuf) {
21 public_deps += [ ":rtc_event_log_parser" ] 21 public_deps += [ ":rtc_event_log_parser" ]
22 } 22 }
23 } 23 }
24 24
25 rtc_source_set("rtc_event_log_api") { 25 rtc_source_set("rtc_event_log_api") {
26 # TODO(kjellander): Remove (bugs.webrtc.org/7257)
27 # Enabling GN check triggers cyclic dependency error:
28 # //webrtc/logging:rtc_event_log_api ->
29 # //webrtc/modules/audio_coding:audio_network_adaptor ->
30 # //webrtc/logging:rtc_event_log_api
31 check_includes = false
26 sources = [ 32 sources = [
27 "rtc_event_log/rtc_event_log.h", 33 "rtc_event_log/rtc_event_log.h",
28 ] 34 ]
35 deps = [
36 "../base:rtc_base_approved",
37 "../call:call_interfaces",
38 ]
29 } 39 }
30 40
31 rtc_static_library("rtc_event_log_impl") { 41 rtc_static_library("rtc_event_log_impl") {
32 sources = [ 42 sources = [
33 "rtc_event_log/ringbuffer.h", 43 "rtc_event_log/ringbuffer.h",
34 "rtc_event_log/rtc_event_log.cc", 44 "rtc_event_log/rtc_event_log.cc",
35 "rtc_event_log/rtc_event_log_helper_thread.cc", 45 "rtc_event_log/rtc_event_log_helper_thread.cc",
36 "rtc_event_log/rtc_event_log_helper_thread.h", 46 "rtc_event_log/rtc_event_log_helper_thread.h",
37 ] 47 ]
38 48
39 defines = [] 49 defines = []
40 50
41 deps = [ 51 deps = [
42 ":rtc_event_log_api", 52 ":rtc_event_log_api",
43 "..:webrtc_common", 53 "..:webrtc_common",
54 "../base:rtc_base_approved",
44 "../call:call_interfaces", 55 "../call:call_interfaces",
45 "../modules/audio_coding:audio_network_adaptor", 56 "../modules/audio_coding:audio_network_adaptor",
46 "../modules/rtp_rtcp", 57 "../modules/rtp_rtcp",
58 "../system_wrappers",
47 ] 59 ]
48 60
49 if (rtc_enable_protobuf) { 61 if (rtc_enable_protobuf) {
50 defines += [ "ENABLE_RTC_EVENT_LOG" ] 62 defines += [ "ENABLE_RTC_EVENT_LOG" ]
51 deps += [ ":rtc_event_log_proto" ] 63 deps += [ ":rtc_event_log_proto" ]
52 } 64 }
53 if (!build_with_chromium && is_clang) { 65 if (!build_with_chromium && is_clang) {
54 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). 66 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
55 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 67 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
56 } 68 }
57 } 69 }
58 70
59 if (rtc_enable_protobuf) { 71 if (rtc_enable_protobuf) {
60 proto_library("rtc_event_log_proto") { 72 proto_library("rtc_event_log_proto") {
61 sources = [ 73 sources = [
62 "rtc_event_log/rtc_event_log.proto", 74 "rtc_event_log/rtc_event_log.proto",
63 ] 75 ]
64 proto_out_dir = "webrtc/logging/rtc_event_log" 76 proto_out_dir = "webrtc/logging/rtc_event_log"
65 } 77 }
66 78
67 rtc_static_library("rtc_event_log_parser") { 79 rtc_static_library("rtc_event_log_parser") {
68 sources = [ 80 sources = [
69 "rtc_event_log/rtc_event_log_parser.cc", 81 "rtc_event_log/rtc_event_log_parser.cc",
70 "rtc_event_log/rtc_event_log_parser.h", 82 "rtc_event_log/rtc_event_log_parser.h",
71 ] 83 ]
72 84
73 public_deps = [ 85 public_deps = [
86 ":rtc_event_log_api",
74 ":rtc_event_log_proto", 87 ":rtc_event_log_proto",
75 "..:webrtc_common", 88 "..:webrtc_common",
89 "../call:call_interfaces",
90 "../modules/rtp_rtcp:rtp_rtcp",
91 "../system_wrappers",
76 ] 92 ]
77 93
78 if (!build_with_chromium && is_clang) { 94 if (!build_with_chromium && is_clang) {
79 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163). 95 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
80 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 96 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
81 } 97 }
98 deps = [
99 "../base:rtc_base_approved",
100 ]
82 } 101 }
83 102
84 if (rtc_include_tests) { 103 if (rtc_include_tests) {
85 rtc_source_set("rtc_event_log_tests") { 104 rtc_source_set("rtc_event_log_tests") {
86 testonly = true 105 testonly = true
87 sources = [ 106 sources = [
88 "rtc_event_log/ringbuffer_unittest.cc", 107 "rtc_event_log/ringbuffer_unittest.cc",
89 "rtc_event_log/rtc_event_log_unittest.cc", 108 "rtc_event_log/rtc_event_log_unittest.cc",
90 "rtc_event_log/rtc_event_log_unittest_helper.cc", 109 "rtc_event_log/rtc_event_log_unittest_helper.cc",
91 ] 110 ]
92 deps = [ 111 deps = [
93 ":rtc_event_log_impl", 112 ":rtc_event_log_impl",
94 ":rtc_event_log_parser", 113 ":rtc_event_log_parser",
114 "../base:rtc_base_approved",
115 "../base:rtc_base_tests_utils",
95 "../call", 116 "../call",
96 "../modules/rtp_rtcp", 117 "../modules/rtp_rtcp",
97 "../system_wrappers:metrics_default", 118 "../system_wrappers:metrics_default",
119 "../test:test_support",
98 "//testing/gmock", 120 "//testing/gmock",
99 "//testing/gtest", 121 "//testing/gtest",
100 ] 122 ]
101 if (!build_with_chromium && is_clang) { 123 if (!build_with_chromium && is_clang) {
102 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163) . 124 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163) .
103 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 125 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
104 } 126 }
105 } 127 }
106 rtc_test("rtc_event_log2rtp_dump") { 128 rtc_test("rtc_event_log2rtp_dump") {
107 testonly = true 129 testonly = true
(...skipping 22 matching lines...) Expand all
130 rtc_executable("rtc_event_log2text") { 152 rtc_executable("rtc_event_log2text") {
131 testonly = true 153 testonly = true
132 sources = [ 154 sources = [
133 "rtc_event_log/rtc_event_log2text.cc", 155 "rtc_event_log/rtc_event_log2text.cc",
134 ] 156 ]
135 deps = [ 157 deps = [
136 ":rtc_event_log_api", 158 ":rtc_event_log_api",
137 ":rtc_event_log_impl", 159 ":rtc_event_log_impl",
138 ":rtc_event_log_parser", 160 ":rtc_event_log_parser",
139 "../base:rtc_base_approved", 161 "../base:rtc_base_approved",
162 "../call:call_interfaces",
140 163
141 # TODO(kwiberg): Remove this dependency. 164 # TODO(kwiberg): Remove this dependency.
142 "../api/audio_codecs:audio_codecs_api", 165 "../api/audio_codecs:audio_codecs_api",
143 "../modules/rtp_rtcp:rtp_rtcp", 166 "../modules/rtp_rtcp:rtp_rtcp",
144 "//third_party/gflags", 167 "//third_party/gflags",
145 ] 168 ]
146 if (!build_with_chromium && is_clang) { 169 if (!build_with_chromium && is_clang) {
147 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163) . 170 # Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163) .
148 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ] 171 suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
149 } 172 }
150 } 173 }
151 } 174 }
152 } 175 }
OLDNEW
« no previous file with comments | « .gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698