Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Unified Diff: webrtc/logging/BUILD.gn

Issue 2717903002: Enable GN check for webrtc/logging (Closed)
Patch Set: Restore .gn change again Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « .gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/logging/BUILD.gn
diff --git a/webrtc/logging/BUILD.gn b/webrtc/logging/BUILD.gn
index 52d421e426e81f04faf822bbd54ad26c1826e225..0cf5731bbc6474852d4c767b4b14dc6df6d3ffca 100644
--- a/webrtc/logging/BUILD.gn
+++ b/webrtc/logging/BUILD.gn
@@ -23,9 +23,19 @@ group("logging") {
}
rtc_source_set("rtc_event_log_api") {
+ # TODO(kjellander): Remove (bugs.webrtc.org/7257)
+ # Enabling GN check triggers cyclic dependency error:
+ # //webrtc/logging:rtc_event_log_api ->
+ # //webrtc/modules/audio_coding:audio_network_adaptor ->
+ # //webrtc/logging:rtc_event_log_api
+ check_includes = false
sources = [
"rtc_event_log/rtc_event_log.h",
]
+ deps = [
+ "../base:rtc_base_approved",
+ "../call:call_interfaces",
+ ]
}
rtc_static_library("rtc_event_log_impl") {
@@ -41,9 +51,11 @@ rtc_static_library("rtc_event_log_impl") {
deps = [
":rtc_event_log_api",
"..:webrtc_common",
+ "../base:rtc_base_approved",
"../call:call_interfaces",
"../modules/audio_coding:audio_network_adaptor",
"../modules/rtp_rtcp",
+ "../system_wrappers",
]
if (rtc_enable_protobuf) {
@@ -71,14 +83,21 @@ if (rtc_enable_protobuf) {
]
public_deps = [
+ ":rtc_event_log_api",
":rtc_event_log_proto",
"..:webrtc_common",
+ "../call:call_interfaces",
+ "../modules/rtp_rtcp:rtp_rtcp",
+ "../system_wrappers",
]
if (!build_with_chromium && is_clang) {
# Suppress warnings from the Chromium Clang plugin (bugs.webrtc.org/163).
suppressed_configs += [ "//build/config/clang:find_bad_constructs" ]
}
+ deps = [
+ "../base:rtc_base_approved",
+ ]
}
if (rtc_include_tests) {
@@ -92,9 +111,12 @@ if (rtc_enable_protobuf) {
deps = [
":rtc_event_log_impl",
":rtc_event_log_parser",
+ "../base:rtc_base_approved",
+ "../base:rtc_base_tests_utils",
"../call",
"../modules/rtp_rtcp",
"../system_wrappers:metrics_default",
+ "../test:test_support",
"//testing/gmock",
"//testing/gtest",
]
@@ -137,6 +159,7 @@ if (rtc_enable_protobuf) {
":rtc_event_log_impl",
":rtc_event_log_parser",
"../base:rtc_base_approved",
+ "../call:call_interfaces",
# TODO(kwiberg): Remove this dependency.
"../api/audio_codecs:audio_codecs_api",
« no previous file with comments | « .gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698