Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2687843002: Remove unused VoiceChannelTransport. (Closed)

Created:
3 years, 10 months ago by the sun
Modified:
3 years, 9 months ago
Reviewers:
tommi, hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove unused VoiceChannelTransport. BUG=webrtc:4690, webrtc:3002 Review-Url: https://codereview.webrtc.org/2687843002 Cr-Commit-Position: refs/heads/master@{#17086} Committed: https://chromium.googlesource.com/external/webrtc/+/759358c9dbc47b22e8e821d5e4cca81d2dcff44f

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8059 lines) Patch
M webrtc/voice_engine/BUILD.gn View 1 3 chunks +0 lines, -69 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/channel_transport.h View 1 chunk +0 lines, -56 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/channel_transport.cc View 1 chunk +0 lines, -83 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/traffic_control_win.h View 1 1 chunk +0 lines, -99 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/traffic_control_win.cc View 1 1 chunk +0 lines, -252 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_socket2_manager_win.h View 1 chunk +0 lines, -162 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_socket2_manager_win.cc View 1 chunk +0 lines, -608 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_socket2_win.h View 1 chunk +0 lines, -174 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_socket2_win.cc View 1 chunk +0 lines, -1353 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_socket_manager_posix.h View 1 chunk +0 lines, -88 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_socket_manager_posix.cc View 1 chunk +0 lines, -392 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_socket_manager_unittest.cc View 1 chunk +0 lines, -84 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_socket_manager_wrapper.h View 1 chunk +0 lines, -70 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_socket_manager_wrapper.cc View 1 chunk +0 lines, -72 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_socket_posix.h View 1 chunk +0 lines, -94 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_socket_posix.cc View 1 chunk +0 lines, -271 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_socket_wrapper.h View 1 chunk +0 lines, -112 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_socket_wrapper.cc View 1 chunk +0 lines, -159 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_socket_wrapper_unittest.cc View 1 chunk +0 lines, -67 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_transport.h View 1 chunk +0 lines, -381 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_transport_impl.h View 1 chunk +0 lines, -259 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_transport_impl.cc View 1 chunk +0 lines, -3009 lines 0 comments Download
D webrtc/voice_engine/test/channel_transport/udp_transport_unittest.cc View 1 chunk +0 lines, -145 lines 0 comments Download

Depends on Patchset:

Issue 2681993004 Patch 40001

Dependent Patchsets:

Issue 2738543002 Patch 1
Issue 2727063004 Patch 60001
Issue 2727063004 Patch 80001
Issue 2738543002 Patch 20001

Messages

Total messages: 15 (10 generated)
the sun
3 years, 9 months ago (2017-03-06 21:01:58 UTC) #2
hlundin-webrtc
lgtm
3 years, 9 months ago (2017-03-07 09:28:04 UTC) #7
tommi
lgtm
3 years, 9 months ago (2017-03-07 09:34:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2687843002/20001
3 years, 9 months ago (2017-03-07 09:45:40 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-07 09:48:02 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/759358c9dbc47b22e8e821d5e...

Powered by Google App Engine
This is Rietveld 408576698