Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 2681993004: Remove voe_cmd_test. (Closed)

Created:
3 years, 10 months ago by the sun
Modified:
3 years, 9 months ago
Reviewers:
tommi, hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, yujie_mao (webrtc), Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, peah-webrtc, minyue-webrtc, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove voe_cmd_test. BUG=webrtc:4690 Review-Url: https://codereview.webrtc.org/2681993004 Cr-Commit-Position: refs/heads/master@{#17085} Committed: https://chromium.googlesource.com/external/webrtc/+/7cb0e55823152480fa4a66f761c842d760b859f7

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -818 lines) Patch
M webrtc/BUILD.gn View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/voice_engine/BUILD.gn View 1 2 1 chunk +0 lines, -27 lines 0 comments Download
D webrtc/voice_engine/test/cmd_test/voe_cmd_test.cc View 1 2 1 chunk +0 lines, -790 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (9 generated)
the sun
3 years, 9 months ago (2017-03-06 21:01:40 UTC) #2
hlundin-webrtc
Poor one out for voe_cmd_test. LGTM!
3 years, 9 months ago (2017-03-07 09:24:47 UTC) #7
hlundin-webrtc
On 2017/03/07 09:24:47, hlundin-webrtc wrote: > Poor one out for voe_cmd_test. > > LGTM! Phatt ...
3 years, 9 months ago (2017-03-07 09:25:49 UTC) #8
henrika_webrtc
Bye, bye :-(
3 years, 9 months ago (2017-03-07 09:26:54 UTC) #9
tommi
lgtm!
3 years, 9 months ago (2017-03-07 09:34:11 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2681993004/40001
3 years, 9 months ago (2017-03-07 09:41:09 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/external/webrtc/+/7cb0e55823152480fa4a66f761c842d760b859f7
3 years, 9 months ago (2017-03-07 09:43:25 UTC) #16
niklas.enbom
3 years, 9 months ago (2017-03-07 17:12:30 UTC) #17
Message was sent while issue was closed.
Nooo!... 
(I actually used as recently as a month ago)

On 2017/03/07 09:43:25, commit-bot: I haz the power wrote:
> Committed patchset #3 (id:40001) as
>
https://chromium.googlesource.com/external/webrtc/+/7cb0e55823152480fa4a66f76...

Powered by Google App Engine
This is Rietveld 408576698