Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2738543002: Remove VoEAudioProcessing interface. (Closed)

Created:
3 years, 9 months ago by the sun
Modified:
3 years, 9 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, AleBzk, henrika_webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove VoEAudioProcessing interface. BUG=webrtc:4690 Review-Url: https://codereview.webrtc.org/2738543002 Cr-Commit-Position: refs/heads/master@{#17185} Committed: https://chromium.googlesource.com/external/webrtc/+/fe7dd6d9ff223eb73da0c5044ccad2952774646d

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase #

Patch Set 4 : delete more #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Total comments: 2

Patch Set 7 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1724 lines) Patch
M webrtc/test/mock_voice_engine.h View 1 2 3 1 chunk +0 lines, -40 lines 0 comments Download
M webrtc/voice_engine/BUILD.gn View 1 2 3 5 chunks +0 lines, -7 lines 0 comments Download
M webrtc/voice_engine/channel.h View 1 2 3 4 5 7 chunks +3 lines, -12 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 2 3 4 5 6 4 chunks +1 line, -19 lines 0 comments Download
D webrtc/voice_engine/include/voe_audio_processing.h View 1 chunk +0 lines, -195 lines 0 comments Download
D webrtc/voice_engine/test/auto_test/extended/agc_config_test.cc View 1 chunk +0 lines, -69 lines 0 comments Download
D webrtc/voice_engine/test/auto_test/extended/ec_metrics_test.cc View 1 chunk +0 lines, -104 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/fixtures/before_initialization_fixture.h View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/fixtures/before_initialization_fixture.cc View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
D webrtc/voice_engine/test/auto_test/standard/audio_processing_test.cc View 1 2 1 chunk +0 lines, -300 lines 0 comments Download
M webrtc/voice_engine/transmit_mixer.h View 1 2 3 1 chunk +0 lines, -10 lines 0 comments Download
M webrtc/voice_engine/transmit_mixer.cc View 1 2 3 1 chunk +0 lines, -27 lines 0 comments Download
D webrtc/voice_engine/voe_audio_processing_impl.h View 1 chunk +0 lines, -94 lines 0 comments Download
D webrtc/voice_engine/voe_audio_processing_impl.cc View 1 chunk +0 lines, -774 lines 0 comments Download
D webrtc/voice_engine/voe_audio_processing_unittest.cc View 1 chunk +0 lines, -66 lines 0 comments Download
M webrtc/voice_engine/voice_engine_impl.h View 1 2 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
the sun
3 years, 9 months ago (2017-03-10 14:18:08 UTC) #6
henrika_webrtc
It looks OK but it is always tricky to review changes based on "remove API ...
3 years, 9 months ago (2017-03-10 14:49:57 UTC) #7
the sun
https://codereview.webrtc.org/2738543002/diff/100001/webrtc/voice_engine/transmit_mixer.h File webrtc/voice_engine/transmit_mixer.h (left): https://codereview.webrtc.org/2738543002/diff/100001/webrtc/voice_engine/transmit_mixer.h#oldcode148 webrtc/voice_engine/transmit_mixer.h:148: #if WEBRTC_VOICE_ENGINE_TYPING_DETECTION On 2017/03/10 14:49:57, henrika_webrtc wrote: > Not ...
3 years, 9 months ago (2017-03-10 20:06:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2738543002/120001
3 years, 9 months ago (2017-03-11 15:48:45 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-11 16:10:48 UTC) #14
Message was sent while issue was closed.
Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/external/webrtc/+/fe7dd6d9ff223eb73da0c5044...

Powered by Google App Engine
This is Rietveld 408576698