Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Unified Diff: webrtc/voice_engine/voe_audio_processing_unittest.cc

Issue 2738543002: Remove VoEAudioProcessing interface. (Closed)
Patch Set: rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/voice_engine/voe_audio_processing_impl.cc ('k') | webrtc/voice_engine/voice_engine_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/voice_engine/voe_audio_processing_unittest.cc
diff --git a/webrtc/voice_engine/voe_audio_processing_unittest.cc b/webrtc/voice_engine/voe_audio_processing_unittest.cc
deleted file mode 100644
index ab4f3cc4fd40ce5870cfb1bef5ec4fabd1b3f6ae..0000000000000000000000000000000000000000
--- a/webrtc/voice_engine/voe_audio_processing_unittest.cc
+++ /dev/null
@@ -1,66 +0,0 @@
-/*
- * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
- *
- * Use of this source code is governed by a BSD-style license
- * that can be found in the LICENSE file in the root of the source
- * tree. An additional intellectual property rights grant can be found
- * in the file PATENTS. All contributing project authors may
- * be found in the AUTHORS file in the root of the source tree.
- */
-
-#include "webrtc/voice_engine/include/voe_audio_processing.h"
-
-#include "webrtc/test/gtest.h"
-#include "webrtc/voice_engine/include/voe_base.h"
-
-namespace webrtc {
-namespace voe {
-namespace {
-
-class VoEAudioProcessingTest : public ::testing::Test {
- protected:
- VoEAudioProcessingTest()
- : voe_(VoiceEngine::Create()),
- base_(VoEBase::GetInterface(voe_)),
- audioproc_(VoEAudioProcessing::GetInterface(voe_)) {}
-
- virtual ~VoEAudioProcessingTest() {
- base_->Terminate();
- audioproc_->Release();
- base_->Release();
- VoiceEngine::Delete(voe_);
- }
-
- VoiceEngine* voe_;
- VoEBase* base_;
- VoEAudioProcessing* audioproc_;
-};
-
-TEST_F(VoEAudioProcessingTest, FailureIfNotInitialized) {
- EXPECT_EQ(-1, audioproc_->EnableDriftCompensation(true));
- EXPECT_EQ(-1, audioproc_->EnableDriftCompensation(false));
- EXPECT_FALSE(audioproc_->DriftCompensationEnabled());
-}
-
-// TODO(andrew): Investigate race conditions triggered by this test:
-// https://code.google.com/p/webrtc/issues/detail?id=788
-TEST_F(VoEAudioProcessingTest, DISABLED_DriftCompensationIsEnabledIfSupported) {
- ASSERT_EQ(0, base_->Init());
- // TODO(andrew): Ideally, DriftCompensationSupported() would be mocked.
- bool supported = VoEAudioProcessing::DriftCompensationSupported();
- if (supported) {
- EXPECT_EQ(0, audioproc_->EnableDriftCompensation(true));
- EXPECT_TRUE(audioproc_->DriftCompensationEnabled());
- EXPECT_EQ(0, audioproc_->EnableDriftCompensation(false));
- EXPECT_FALSE(audioproc_->DriftCompensationEnabled());
- } else {
- EXPECT_EQ(-1, audioproc_->EnableDriftCompensation(true));
- EXPECT_FALSE(audioproc_->DriftCompensationEnabled());
- EXPECT_EQ(-1, audioproc_->EnableDriftCompensation(false));
- EXPECT_FALSE(audioproc_->DriftCompensationEnabled());
- }
-}
-
-} // namespace
-} // namespace voe
-} // namespace webrtc
« no previous file with comments | « webrtc/voice_engine/voe_audio_processing_impl.cc ('k') | webrtc/voice_engine/voice_engine_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698