Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2727063004: Remove VoEVolumeControl interface. (Closed)

Created:
3 years, 9 months ago by the sun
Modified:
3 years, 9 months ago
Reviewers:
henrika_webrtc
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, AleBzk, Andrew MacDonald, henrika_webrtc, hlundin-webrtc, tterriberry_mozilla.com, audio-team_agora.io, qiang.lu, niklas.enbom, peah-webrtc, minyue-webrtc, the sun, yujie_mao (webrtc)
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove VoEVolumeControl interface. BUG=webrtc:4690, webrtc:6206 Review-Url: https://codereview.webrtc.org/2727063004 Cr-Commit-Position: refs/heads/master@{#17108} Committed: https://chromium.googlesource.com/external/webrtc/+/8d73f8c6fafd53b712ac1dc938d4483f1e6c5b47

Patch Set 1 #

Patch Set 2 : reabse #

Patch Set 3 : Less include #

Patch Set 4 : rebase #

Patch Set 5 : tweak #

Patch Set 6 : rebase #

Patch Set 7 : includes #

Patch Set 8 : rebase #

Patch Set 9 : rebase #

Patch Set 10 : fix #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1138 lines) Patch
M webrtc/test/mock_voe_channel_proxy.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/voice_engine/BUILD.gn View 1 2 3 4 5 3 chunks +0 lines, -4 lines 0 comments Download
M webrtc/voice_engine/channel.h View 1 2 3 4 5 6 7 8 9 3 chunks +8 lines, -14 lines 0 comments Download
M webrtc/voice_engine/channel.cc View 1 2 3 4 5 6 7 8 4 chunks +8 lines, -62 lines 0 comments Download
M webrtc/voice_engine/channel_proxy.h View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/voice_engine/channel_proxy.cc View 1 2 3 4 3 chunks +6 lines, -14 lines 0 comments Download
D webrtc/voice_engine/include/voe_volume_control.h View 1 chunk +0 lines, -114 lines 0 comments Download
M webrtc/voice_engine/output_mixer.h View 1 2 3 4 5 6 3 chunks +0 lines, -14 lines 0 comments Download
M webrtc/voice_engine/output_mixer.cc View 5 chunks +0 lines, -64 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/fixtures/before_initialization_fixture.h View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/fixtures/before_initialization_fixture.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/standard/audio_processing_test.cc View 2 chunks +0 lines, -37 lines 0 comments Download
D webrtc/voice_engine/test/auto_test/standard/volume_test.cc View 1 chunk +0 lines, -302 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_standard_test.h View 3 chunks +1 line, -3 lines 0 comments Download
M webrtc/voice_engine/test/auto_test/voe_standard_test.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M webrtc/voice_engine/transmit_mixer.h View 1 2 3 4 5 2 chunks +1 line, -6 lines 0 comments Download
M webrtc/voice_engine/transmit_mixer.cc View 1 2 chunks +0 lines, -18 lines 0 comments Download
D webrtc/voice_engine/voe_volume_control_impl.h View 1 chunk +0 lines, -60 lines 0 comments Download
D webrtc/voice_engine/voe_volume_control_impl.cc View 1 chunk +0 lines, -411 lines 2 comments Download
M webrtc/voice_engine/voice_engine_impl.h View 3 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
the sun
3 years, 9 months ago (2017-03-07 20:20:44 UTC) #3
henrika_webrtc
LGTM https://codereview.webrtc.org/2727063004/diff/180001/webrtc/voice_engine/voe_volume_control_impl.cc File webrtc/voice_engine/voe_volume_control_impl.cc (left): https://codereview.webrtc.org/2727063004/diff/180001/webrtc/voice_engine/voe_volume_control_impl.cc#oldcode60 webrtc/voice_engine/voe_volume_control_impl.cc:60: if (_shared->audio_device()->MaxSpeakerVolume(&maxVol) != 0) { Should we create ...
3 years, 9 months ago (2017-03-08 09:37:36 UTC) #8
the sun
https://codereview.webrtc.org/2727063004/diff/180001/webrtc/voice_engine/voe_volume_control_impl.cc File webrtc/voice_engine/voe_volume_control_impl.cc (left): https://codereview.webrtc.org/2727063004/diff/180001/webrtc/voice_engine/voe_volume_control_impl.cc#oldcode60 webrtc/voice_engine/voe_volume_control_impl.cc:60: if (_shared->audio_device()->MaxSpeakerVolume(&maxVol) != 0) { On 2017/03/08 09:37:36, henrika_webrtc ...
3 years, 9 months ago (2017-03-08 09:49:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2727063004/180001
3 years, 9 months ago (2017-03-08 09:49:59 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-08 09:52:24 UTC) #14
Message was sent while issue was closed. 
Committed patchset #10 (id:180001) as
https://chromium.googlesource.com/external/webrtc/+/8d73f8c6fafd53b712ac1dc93...

Powered by Google App Engine
This is Rietveld 408576698