Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 2679103006: Rename "PacketTransportInterface" to "PacketTransportInternal". (Closed)

Created:
3 years, 10 months ago by Taylor Brandstetter
Modified:
3 years, 10 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Target Ref:
refs/heads/master
Project:
webrtc
Visibility:
Public.

Description

Rename "PacketTransportInterface" to "PacketTransportInternal". This is the naming scheme we've been using for internal interfaces. Also, this CL will introduce a PacketTransportInterface in the webrtc namespace, which would get too easily confused with the rtc:: one: https://codereview.webrtc.org/2675173003/ BUG=None Review-Url: https://codereview.webrtc.org/2679103006 Cr-Commit-Position: refs/heads/master@{#16539} Committed: https://chromium.googlesource.com/external/webrtc/+/5bd5ca344e04106c41c3f3d5c7195db62a5e63a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -238 lines) Patch
M webrtc/media/sctp/sctptransport.h View 4 chunks +6 lines, -6 lines 0 comments Download
M webrtc/media/sctp/sctptransport.cc View 4 chunks +4 lines, -5 lines 0 comments Download
M webrtc/media/sctp/sctptransportinternal.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/p2p/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.h View 2 chunks +6 lines, -6 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M webrtc/p2p/base/dtlstransportchannel_unittest.cc View 4 chunks +9 lines, -10 lines 0 comments Download
M webrtc/p2p/base/dtlstransportinternal.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/fakedtlstransport.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/fakeicetransport.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/p2p/base/fakepackettransport.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/p2p/base/icetransportinternal.h View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/p2ptransportchannel_unittest.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M webrtc/p2p/base/packettransportinterface.h View 2 chunks +9 lines, -82 lines 0 comments Download
A + webrtc/p2p/base/packettransportinternal.h View 5 chunks +12 lines, -12 lines 0 comments Download
M webrtc/p2p/base/transportcontroller.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/p2p/base/transportcontroller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M webrtc/p2p/base/udptransport.h View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/p2p/base/udptransport_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M webrtc/pc/channel.h View 11 chunks +23 lines, -23 lines 0 comments Download
M webrtc/pc/channel.cc View 16 chunks +23 lines, -23 lines 0 comments Download
M webrtc/pc/channel_unittest.cc View 6 chunks +17 lines, -17 lines 0 comments Download
M webrtc/pc/ortcfactory_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/pc/webrtcsession_unittest.cc View 6 chunks +11 lines, -11 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (6 generated)
pthatcher1
lgtm
3 years, 10 months ago (2017-02-10 18:16:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/2679103006/1
3 years, 10 months ago (2017-02-10 18:17:56 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 19:31:54 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/5bd5ca344e04106c41c3f3d5c...

Powered by Google App Engine
This is Rietveld 408576698