Add ability to return moved value from FunctorMessageHandler, Optional.

Add ability to return moved value from FunctorMessageHandler, Optional.

This functionality is desired for this CL:
https://codereview.webrtc.org/2675173003/

BUG=None

Review-Url: https://codereview.webrtc.org/2681283002
Cr-Commit-Position: refs/heads/master@{#16546}
Committed: https://chromium.googlesource.com/external/webrtc/+/81baed36bff0d331c71d2358bfb4e28dd2eb64ab

[pthatcher1, 2017-02-10 18:18:01]

pthatcher@webrtc.org changed reviewers:
+ pthatcher@webrtc.org

[pthatcher1, 2017-02-10 18:18:01]

lgtm, but I'd like it if other owners of base/ look at it too since it can have
wide effects.  Perhaps Tommi?

https://codereview.webrtc.org/2681283002/diff/1/webrtc/base/messagehandler.h
File webrtc/base/messagehandler.h (right):

https://codereview.webrtc.org/2681283002/diff/1/webrtc/base/messagehandler.h#...
webrtc/base/messagehandler.h:49: // after this.
What happens if you do?

[Taylor Brandstetter, 2017-02-10 19:29:41]

deadbeef@webrtc.org changed reviewers:
+ tommi@webrtc.org

[Taylor Brandstetter, 2017-02-10 19:29:42]

PTAL tommi. The only visible effect of this will be that "Invoke" will use a
move constructor, if available, rather than a copy constructor. That shouldn't
cause issues unless an object's move constructor has a bug.

https://codereview.webrtc.org/2681283002/diff/1/webrtc/base/messagehandler.h
File webrtc/base/messagehandler.h (right):

https://codereview.webrtc.org/2681283002/diff/1/webrtc/base/messagehandler.h#...
webrtc/base/messagehandler.h:49: // after this.
On 2017/02/10 18:18:01, pthatcher1 wrote:
> What happens if you do?

Undefined behavior.

[tommi, 2017-02-10 19:38:55]

lgtm with the preference of naming the method MoveResult since I think that move
semantics are generally understood.

https://codereview.webrtc.org/2681283002/diff/1/webrtc/base/messagehandler.h
File webrtc/base/messagehandler.h (right):

https://codereview.webrtc.org/2681283002/diff/1/webrtc/base/messagehandler.h#...
webrtc/base/messagehandler.h:50: ReturnT ConsumeResult() { return
std::move(result_); }
MoveResult() ?

[Taylor Brandstetter, 2017-02-11 01:03:30]

https://codereview.webrtc.org/2681283002/diff/1/webrtc/base/messagehandler.h
File webrtc/base/messagehandler.h (right):

https://codereview.webrtc.org/2681283002/diff/1/webrtc/base/messagehandler.h#...
webrtc/base/messagehandler.h:50: ReturnT ConsumeResult() { return
std::move(result_); }
On 2017/02/10 19:38:55, tommi (webrtc) wrote:
> MoveResult() ?

Done.

[Taylor Brandstetter, 2017-02-11 01:03:34]

The CQ bit was checked by deadbeef@webrtc.org

[Taylor Brandstetter, 2017-02-11 01:03:35]

The patchset sent to the CQ was uploaded after l-g-t-m from tommi@webrtc.org,
pthatcher@webrtc.org
Link to the patchset: https://codereview.webrtc.org/2681283002/#ps20001 (title:
"Rename to MoveValue as suggested.")

[commit-bot: I haz the power, 2017-02-11 01:03:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-02-11 02:11:12]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486775014975360,
"parent_rev": "a4549d6588207a22ec0c5decc2dfc9fc9a1cde70", "commit_rev":
"81baed36bff0d331c71d2358bfb4e28dd2eb64ab"}

[commit-bot: I haz the power, 2017-02-11 02:11:15]

Description was changed from

==========
Add ability to return moved value from FunctorMessageHandler, Optional.

This functionality is desired for this CL:
https://codereview.webrtc.org/2675173003/

BUG=None
==========

to

==========
Add ability to return moved value from FunctorMessageHandler, Optional.

This functionality is desired for this CL:
https://codereview.webrtc.org/2675173003/

BUG=None

Review-Url: https://codereview.webrtc.org/2681283002
Cr-Commit-Position: refs/heads/master@{#16546}
Committed:
https://chromium.googlesource.com/external/webrtc/+/81baed36bff0d331c71d2358b...
==========

[commit-bot: I haz the power, 2017-02-11 02:11:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/webrtc/+/81baed36bff0d331c71d2358b...