Revert of New method StatsObserver::OnCompleteReports, passing ownership.

Revert of New method StatsObserver::OnCompleteReports, passing ownership. (patchset #2 id:20001 of https://codereview.webrtc.org/2584553002/ )

Reason for revert:
The new method doesn't work as intended. 

It can't pass ownership, because the StatsReports is a vector of raw pointers to StatReport objects owned by the StatsCollector.

Original issue's description:
> New method StatsObserver::OnCompleteReports, passing ownership.
> 
> The new name, OnCompleteReports rather than OnComplete, is needed
> because in C++ method lookup, overriding a method hides all otherwise
> inherited methods with the same name, even if they have a different
> signature. And here, the intention is that each subclass should
> override one or the other of the two methods, and inherit the method it
> doesn't override.
> 
> This cl is a prerequisite for
> https://codereview.webrtc.org/2567143003/, because the Chrome glue
> code needs to retain the stats report after the OnComplete method has
> returned.
> 
> Currently, Chrome makes a copy of the stats mapping (which breaks when
> changing ValuePtr from an rtc::linked_ptr to an std::unique_ptr). After
> this cl, Chrome can be fixed to take ownership and no longer needs to
> copy anything, unblocking cl 2567143003.
> 
> BUG=webrtc:6424
> 
> Review-Url: https://codereview.webrtc.org/2584553002
> Cr-Commit-Position: refs/heads/master@{#15708}
> Committed: https://chromium.googlesource.com/external/webrtc/+/b36ee8d498be2fa58fde3f3f3d69a74e4d3b817d

TBR=solenberg@webrtc.org,magjed@webrtc.org,tkchin@webrtc.org,hbos@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:6424
Review-Url: https://codereview.webrtc.org/2641783002
Cr-Commit-Position: refs/heads/master@{#16144}
Committed: https://chromium.googlesource.com/external/webrtc/+/e8abe3ef1b526dc5e6ed50c0b2bd19bab88baf47

[nisse-webrtc, 2017-01-18 09:20:12]

Created Revert of New method StatsObserver::OnCompleteReports, passing
ownership.

[the sun, 2017-01-18 09:44:36]

lgtm

[hbos, 2017-01-18 09:46:12]

lgtm

[nisse-webrtc, 2017-01-18 09:49:03]

The CQ bit was checked by nisse@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 09:49:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-18 10:42:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 10:42:53]

Dry run: This issue passed the CQ dry run.

[magjed_webrtc, 2017-01-18 11:54:33]

lgtm

[nisse-webrtc, 2017-01-18 12:58:10]

The CQ bit was checked by nisse@webrtc.org

[commit-bot: I haz the power, 2017-01-18 12:58:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.webrtc.org/...

[commit-bot: I haz the power, 2017-01-18 13:00:35]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484744290423970, "parent_rev":
"2f67b82e208552ce6aa5bd7d51cc67898a3bca9b", "commit_rev":
"e8abe3ef1b526dc5e6ed50c0b2bd19bab88baf47"}

[commit-bot: I haz the power, 2017-01-18 13:00:37]

Description was changed from

==========
Revert of New method StatsObserver::OnCompleteReports, passing ownership.
(patchset #2 id:20001 of https://codereview.webrtc.org/2584553002/ )

Reason for revert:
The new method doesn't work as intended. 

It can't pass ownership, because the StatsReports is a vector of raw pointers to
StatReport objects owned by the StatsCollector.

Original issue's description:
> New method StatsObserver::OnCompleteReports, passing ownership.
> 
> The new name, OnCompleteReports rather than OnComplete, is needed
> because in C++ method lookup, overriding a method hides all otherwise
> inherited methods with the same name, even if they have a different
> signature. And here, the intention is that each subclass should
> override one or the other of the two methods, and inherit the method it
> doesn't override.
> 
> This cl is a prerequisite for
> https://codereview.webrtc.org/2567143003/, because the Chrome glue
> code needs to retain the stats report after the OnComplete method has
> returned.
> 
> Currently, Chrome makes a copy of the stats mapping (which breaks when
> changing ValuePtr from an rtc::linked_ptr to an std::unique_ptr). After
> this cl, Chrome can be fixed to take ownership and no longer needs to
> copy anything, unblocking cl 2567143003.
> 
> BUG=webrtc:6424
> 
> Review-Url: https://codereview.webrtc.org/2584553002
> Cr-Commit-Position: refs/heads/master@{#15708}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/b36ee8d498be2fa58fde3f3f3...

TBR=solenberg@webrtc.org,magjed@webrtc.org,tkchin@webrtc.org,hbos@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:6424
==========

to

==========
Revert of New method StatsObserver::OnCompleteReports, passing ownership.
(patchset #2 id:20001 of https://codereview.webrtc.org/2584553002/ )

Reason for revert:
The new method doesn't work as intended. 

It can't pass ownership, because the StatsReports is a vector of raw pointers to
StatReport objects owned by the StatsCollector.

Original issue's description:
> New method StatsObserver::OnCompleteReports, passing ownership.
> 
> The new name, OnCompleteReports rather than OnComplete, is needed
> because in C++ method lookup, overriding a method hides all otherwise
> inherited methods with the same name, even if they have a different
> signature. And here, the intention is that each subclass should
> override one or the other of the two methods, and inherit the method it
> doesn't override.
> 
> This cl is a prerequisite for
> https://codereview.webrtc.org/2567143003/, because the Chrome glue
> code needs to retain the stats report after the OnComplete method has
> returned.
> 
> Currently, Chrome makes a copy of the stats mapping (which breaks when
> changing ValuePtr from an rtc::linked_ptr to an std::unique_ptr). After
> this cl, Chrome can be fixed to take ownership and no longer needs to
> copy anything, unblocking cl 2567143003.
> 
> BUG=webrtc:6424
> 
> Review-Url: https://codereview.webrtc.org/2584553002
> Cr-Commit-Position: refs/heads/master@{#15708}
> Committed:
https://chromium.googlesource.com/external/webrtc/+/b36ee8d498be2fa58fde3f3f3...

TBR=solenberg@webrtc.org,magjed@webrtc.org,tkchin@webrtc.org,hbos@webrtc.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=webrtc:6424

Review-Url: https://codereview.webrtc.org/2641783002
Cr-Commit-Position: refs/heads/master@{#16144}
Committed:
https://chromium.googlesource.com/external/webrtc/+/e8abe3ef1b526dc5e6ed50c0b...
==========

[commit-bot: I haz the power, 2017-01-18 13:00:38]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/webrtc/+/e8abe3ef1b526dc5e6ed50c0b...