Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Unified Diff: webrtc/sdk/objc/Framework/Classes/RTCPeerConnection+Stats.mm

Issue 2641783002: Revert of New method StatsObserver::OnCompleteReports, passing ownership. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/sdk/android/src/jni/peerconnection_jni.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/sdk/objc/Framework/Classes/RTCPeerConnection+Stats.mm
diff --git a/webrtc/sdk/objc/Framework/Classes/RTCPeerConnection+Stats.mm b/webrtc/sdk/objc/Framework/Classes/RTCPeerConnection+Stats.mm
index 4eb3e708f1a2543decdde0056086211a30893fa0..2c4571e0b37270198a3fc12fb3923d0cbb7640da 100644
--- a/webrtc/sdk/objc/Framework/Classes/RTCPeerConnection+Stats.mm
+++ b/webrtc/sdk/objc/Framework/Classes/RTCPeerConnection+Stats.mm
@@ -29,10 +29,10 @@
completion_handler_ = nil;
}
- void OnCompleteReports(std::unique_ptr<StatsReports> reports) override {
+ void OnComplete(const StatsReports& reports) override {
RTC_DCHECK(completion_handler_);
- NSMutableArray *stats = [NSMutableArray arrayWithCapacity:reports->size()];
- for (const auto* report : *reports) {
+ NSMutableArray *stats = [NSMutableArray arrayWithCapacity:reports.size()];
+ for (const auto* report : reports) {
RTCLegacyStatsReport *statsReport =
[[RTCLegacyStatsReport alloc] initWithNativeReport:*report];
[stats addObject:statsReport];
« no previous file with comments | « webrtc/sdk/android/src/jni/peerconnection_jni.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698