Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: webrtc/sdk/android/src/jni/peerconnection_jni.cc

Issue 2641783002: Revert of New method StatsObserver::OnCompleteReports, passing ownership. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/sdk/android/src/jni/peerconnection_jni.cc
diff --git a/webrtc/sdk/android/src/jni/peerconnection_jni.cc b/webrtc/sdk/android/src/jni/peerconnection_jni.cc
index c9c8ed35afaa57238fa10b602f02072cba736890..da552997758ae04e9e1cd15939e88ad446b7d74c 100644
--- a/webrtc/sdk/android/src/jni/peerconnection_jni.cc
+++ b/webrtc/sdk/android/src/jni/peerconnection_jni.cc
@@ -671,9 +671,9 @@
virtual ~StatsObserverWrapper() {}
- void OnCompleteReports(std::unique_ptr<StatsReports> reports) override {
+ void OnComplete(const StatsReports& reports) override {
ScopedLocalRefFrame local_ref_frame(jni());
- jobjectArray j_reports = ReportsToJava(jni(), *reports);
+ jobjectArray j_reports = ReportsToJava(jni(), reports);
jmethodID m = GetMethodID(jni(), *j_observer_class_, "onComplete",
"([Lorg/webrtc/StatsReport;)V");
jni()->CallVoidMethod(*j_observer_global_, m, j_reports);
« no previous file with comments | « webrtc/api/test/mockpeerconnectionobservers.h ('k') | webrtc/sdk/objc/Framework/Classes/RTCPeerConnection+Stats.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698